Uh oh!
There was an error while loading. Please reload this page.
add example of using custom resources - #848
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
scottilee
commented
Jul 25, 2019
Contributor
@tomplus Hey this is awesome apart from my one comment above! |
13 tasks
scottilee
commented
Jul 26, 2019
Contributor
@yliaog can you take a look? |
yliaog
commented
Jul 26, 2019
Contributor
it's a nice CRD example, thanks. could you please squash the commits? otherwise looks good |
tomplus
commented
Jul 26, 2019
MemberAuthor
@yliaog squashed, thanks. |
yliaog
commented
Jul 26, 2019
Contributor
/lgtm |
k8s-ci-robot
commented
Jul 26, 2019
Contributor
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tomplus, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replace old example of creating third-party resources with an example of managing "custom resources".
Thanks for merging it.