[DO NOT MERGE] Switch to openapi-generator by roycaihw · Pull Request #926 · kubernetes-client/python

roycaihw · 2019-08-13T01:15:14Z

ref kubernetes-client/gen#93, kubernetes-client/gen#97

This is for reviewing and testing the diff of generated code in master branch. The change is basically:

pick feat: switch python client to use openapi-generator gen#97
run scripts/update-client.sh

but split into logical commits for easier review.

I plan to:

do a 11.0.0a1 release with openapi-generator in release branch (and keep using swagger-codegen in master branch for now)
switch master branch to use openapi-generator and do a 11.0.0b1 release

mostly openapi spec version constant change

to make review easier

k8s-ci-robot · 2019-08-13T01:15:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roycaihw · 2019-08-14T00:55:47Z

Test is green. This is ready for review: 7387639

/cc @micw523 @scottilee @tomplus @yliaog

user-facing changes:

kubernetes.client.apis package is renamed to kubernetes.client.api
- [python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types

non-user-facing changes:

kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

k8s-ci-robot · 2019-08-14T00:55:49Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Test is green. This is ready for review: 7387639
/cc @micw523 @scottilee @tomplus @yliaog
user-facing changes:
kubernetes.client.apis package is renamed to kubernetes.client.api
[python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types
non-user-facing changes:
kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

micw523 · 2019-08-14T14:55:55Z

I remember openapi-generator uses flake8 as the main Python linter and that's why you see the #noqa flags scattered everywhere in the code. We may want to make the switch too in the future since these flags are not recognized by pycodestyle.

The code style test is green right now - I don't think we need to act right now but I may just send in a PR switching us to flake8 when this is merged.

micw523 · 2019-08-14T14:58:21Z

 ## Documentation for API Endpoints

-All URIs are relative to *https://localhost*
+All URIs are relative to *http://localhost*


https -> http?

This is from the code generator. The documentation change looks reasonable to me, since by default the generated client doesn't have TLS set up

micw523 · 2019-08-14T15:05:41Z

-**selector** | [**V1LabelSelector**](V1LabelSelector.md) | Label query over pods whose evictions are managed by the disruption budget. | [optional] 
+**max_unavailable** | [**object**](.md) | An eviction is allowed if at most \&quot;maxUnavailable\&quot; pods selected by \&quot;selector\&quot; are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with \&quot;minAvailable\&quot;. | [optional] 
+**min_available** | [**object**](.md) | An eviction is allowed if at least \&quot;minAvailable\&quot; pods selected by \&quot;selector\&quot; will still be available after the eviction, i.e. even in the absence of the evicted pod. So for example you can prevent all voluntary evictions by specifying \&quot;100%\&quot;. | [optional] 
+**selector** | [**V1LabelSelector**](V1LabelSelector.md) | | [optional] 


Seems like the description of a few parameters have disappeared. The loss of descriptions is very consistent across docs.

The openapi spec didn't change. @tomplus Do you know what may cause the doc change in the generators?

scottilee · 2019-08-15T05:01:17Z

 from kubernetes import config
 from kubernetes.client import Configuration
-from kubernetes.client.apis import core_v1_api
+from kubernetes.client.api import core_v1_api


Is this right? I get an error: ModuleNotFoundError: No module named 'kubernetes.client.api'.

could you print the package info in your code, to see if it's using the updated code from this pull? I suspect you have official kubernetes package installed in your env and the code is using that by default

You can also try modifying your PYTHONPATH variable if you’re under Linux and prioritize searching for the k8s package locally.

roycaihw · 2019-09-13T19:38:27Z

included in #931

/close

k8s-ci-robot · 2019-09-13T19:38:29Z

@roycaihw: Closed this PR.

Details

In response to this:

included in #931
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2019-08-13T01:15:14Z

ref kubernetes-client/gen#93, kubernetes-client/gen#97

This is for reviewing and testing the diff of generated code in master branch. The change is basically:

pick feat: switch python client to use openapi-generator gen#97
run scripts/update-client.sh

but split into logical commits for easier review.

I plan to:

do a 11.0.0a1 release with openapi-generator in release branch (and keep using swagger-codegen in master branch for now)
switch master branch to use openapi-generator and do a 11.0.0b1 release

mostly openapi spec version constant change

to make review easier

k8s-ci-robot · 2019-08-13T01:15:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roycaihw · 2019-08-14T00:55:47Z

Test is green. This is ready for review: 7387639

/cc @micw523 @scottilee @tomplus @yliaog

user-facing changes:

kubernetes.client.apis package is renamed to kubernetes.client.api
- [python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types

non-user-facing changes:

kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

k8s-ci-robot · 2019-08-14T00:55:49Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Test is green. This is ready for review: 7387639
/cc @micw523 @scottilee @tomplus @yliaog
user-facing changes:
kubernetes.client.apis package is renamed to kubernetes.client.api
[python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types
non-user-facing changes:
kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

micw523 · 2019-08-14T14:55:55Z

I remember openapi-generator uses flake8 as the main Python linter and that's why you see the #noqa flags scattered everywhere in the code. We may want to make the switch too in the future since these flags are not recognized by pycodestyle.

The code style test is green right now - I don't think we need to act right now but I may just send in a PR switching us to flake8 when this is merged.

micw523 · 2019-08-14T14:58:21Z

 ## Documentation for API Endpoints

-All URIs are relative to *https://localhost*
+All URIs are relative to *http://localhost*


https -> http?

This is from the code generator. The documentation change looks reasonable to me, since by default the generated client doesn't have TLS set up

micw523 · 2019-08-14T15:05:41Z

-**selector** | [**V1LabelSelector**](V1LabelSelector.md) | Label query over pods whose evictions are managed by the disruption budget. | [optional] 
+**max_unavailable** | [**object**](.md) | An eviction is allowed if at most \&quot;maxUnavailable\&quot; pods selected by \&quot;selector\&quot; are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with \&quot;minAvailable\&quot;. | [optional] 
+**min_available** | [**object**](.md) | An eviction is allowed if at least \&quot;minAvailable\&quot; pods selected by \&quot;selector\&quot; will still be available after the eviction, i.e. even in the absence of the evicted pod. So for example you can prevent all voluntary evictions by specifying \&quot;100%\&quot;. | [optional] 
+**selector** | [**V1LabelSelector**](V1LabelSelector.md) | | [optional] 


Seems like the description of a few parameters have disappeared. The loss of descriptions is very consistent across docs.

The openapi spec didn't change. @tomplus Do you know what may cause the doc change in the generators?

scottilee · 2019-08-15T05:01:17Z

 from kubernetes import config
 from kubernetes.client import Configuration
-from kubernetes.client.apis import core_v1_api
+from kubernetes.client.api import core_v1_api


Is this right? I get an error: ModuleNotFoundError: No module named 'kubernetes.client.api'.

could you print the package info in your code, to see if it's using the updated code from this pull? I suspect you have official kubernetes package installed in your env and the code is using that by default

You can also try modifying your PYTHONPATH variable if you’re under Linux and prioritize searching for the k8s package locally.

roycaihw · 2019-09-13T19:38:27Z

included in #931

/close

k8s-ci-robot · 2019-09-13T19:38:29Z

@roycaihw: Closed this PR.

Details

In response to this:

included in #931
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2019-08-13T01:15:14Z

ref kubernetes-client/gen#93, kubernetes-client/gen#97

This is for reviewing and testing the diff of generated code in master branch. The change is basically:

pick feat: switch python client to use openapi-generator gen#97
run scripts/update-client.sh

but split into logical commits for easier review.

I plan to:

do a 11.0.0a1 release with openapi-generator in release branch (and keep using swagger-codegen in master branch for now)
switch master branch to use openapi-generator and do a 11.0.0b1 release

mostly openapi spec version constant change

to make review easier

k8s-ci-robot · 2019-08-13T01:15:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roycaihw · 2019-08-14T00:55:47Z

Test is green. This is ready for review: 7387639

/cc @micw523 @scottilee @tomplus @yliaog

user-facing changes:

kubernetes.client.apis package is renamed to kubernetes.client.api
- [python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types

non-user-facing changes:

kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

k8s-ci-robot · 2019-08-14T00:55:49Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Test is green. This is ready for review: 7387639
/cc @micw523 @scottilee @tomplus @yliaog
user-facing changes:
kubernetes.client.apis package is renamed to kubernetes.client.api
[python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types
non-user-facing changes:
kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

micw523 · 2019-08-14T14:55:55Z

I remember openapi-generator uses flake8 as the main Python linter and that's why you see the #noqa flags scattered everywhere in the code. We may want to make the switch too in the future since these flags are not recognized by pycodestyle.

The code style test is green right now - I don't think we need to act right now but I may just send in a PR switching us to flake8 when this is merged.

micw523 · 2019-08-14T14:58:21Z

 ## Documentation for API Endpoints

-All URIs are relative to *https://localhost*
+All URIs are relative to *http://localhost*


https -> http?

This is from the code generator. The documentation change looks reasonable to me, since by default the generated client doesn't have TLS set up

micw523 · 2019-08-14T15:05:41Z

-**selector** | [**V1LabelSelector**](V1LabelSelector.md) | Label query over pods whose evictions are managed by the disruption budget. | [optional] 
+**max_unavailable** | [**object**](.md) | An eviction is allowed if at most \&quot;maxUnavailable\&quot; pods selected by \&quot;selector\&quot; are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with \&quot;minAvailable\&quot;. | [optional] 
+**min_available** | [**object**](.md) | An eviction is allowed if at least \&quot;minAvailable\&quot; pods selected by \&quot;selector\&quot; will still be available after the eviction, i.e. even in the absence of the evicted pod. So for example you can prevent all voluntary evictions by specifying \&quot;100%\&quot;. | [optional] 
+**selector** | [**V1LabelSelector**](V1LabelSelector.md) | | [optional] 


Seems like the description of a few parameters have disappeared. The loss of descriptions is very consistent across docs.

The openapi spec didn't change. @tomplus Do you know what may cause the doc change in the generators?

scottilee · 2019-08-15T05:01:17Z

 from kubernetes import config
 from kubernetes.client import Configuration
-from kubernetes.client.apis import core_v1_api
+from kubernetes.client.api import core_v1_api


Is this right? I get an error: ModuleNotFoundError: No module named 'kubernetes.client.api'.

could you print the package info in your code, to see if it's using the updated code from this pull? I suspect you have official kubernetes package installed in your env and the code is using that by default

You can also try modifying your PYTHONPATH variable if you’re under Linux and prioritize searching for the k8s package locally.

roycaihw · 2019-09-13T19:38:27Z

included in #931

/close

k8s-ci-robot · 2019-09-13T19:38:29Z

@roycaihw: Closed this PR.

Details

In response to this:

included in #931
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2019-08-13T01:15:14Z

ref kubernetes-client/gen#93, kubernetes-client/gen#97

This is for reviewing and testing the diff of generated code in master branch. The change is basically:

pick feat: switch python client to use openapi-generator gen#97
run scripts/update-client.sh

but split into logical commits for easier review.

I plan to:

do a 11.0.0a1 release with openapi-generator in release branch (and keep using swagger-codegen in master branch for now)
switch master branch to use openapi-generator and do a 11.0.0b1 release

mostly openapi spec version constant change

to make review easier

k8s-ci-robot · 2019-08-13T01:15:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roycaihw · 2019-08-14T00:55:47Z

Test is green. This is ready for review: 7387639

/cc @micw523 @scottilee @tomplus @yliaog

user-facing changes:

kubernetes.client.apis package is renamed to kubernetes.client.api
- [python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types

non-user-facing changes:

kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

k8s-ci-robot · 2019-08-14T00:55:49Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Test is green. This is ready for review: 7387639
/cc @micw523 @scottilee @tomplus @yliaog
user-facing changes:
kubernetes.client.apis package is renamed to kubernetes.client.api
[python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types
non-user-facing changes:
kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

micw523 · 2019-08-14T14:55:55Z

I remember openapi-generator uses flake8 as the main Python linter and that's why you see the #noqa flags scattered everywhere in the code. We may want to make the switch too in the future since these flags are not recognized by pycodestyle.

The code style test is green right now - I don't think we need to act right now but I may just send in a PR switching us to flake8 when this is merged.

micw523 · 2019-08-14T14:58:21Z

 ## Documentation for API Endpoints

-All URIs are relative to *https://localhost*
+All URIs are relative to *http://localhost*


https -> http?

This is from the code generator. The documentation change looks reasonable to me, since by default the generated client doesn't have TLS set up

micw523 · 2019-08-14T15:05:41Z

-**selector** | [**V1LabelSelector**](V1LabelSelector.md) | Label query over pods whose evictions are managed by the disruption budget. | [optional] 
+**max_unavailable** | [**object**](.md) | An eviction is allowed if at most \&quot;maxUnavailable\&quot; pods selected by \&quot;selector\&quot; are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with \&quot;minAvailable\&quot;. | [optional] 
+**min_available** | [**object**](.md) | An eviction is allowed if at least \&quot;minAvailable\&quot; pods selected by \&quot;selector\&quot; will still be available after the eviction, i.e. even in the absence of the evicted pod. So for example you can prevent all voluntary evictions by specifying \&quot;100%\&quot;. | [optional] 
+**selector** | [**V1LabelSelector**](V1LabelSelector.md) | | [optional] 


Seems like the description of a few parameters have disappeared. The loss of descriptions is very consistent across docs.

The openapi spec didn't change. @tomplus Do you know what may cause the doc change in the generators?

scottilee · 2019-08-15T05:01:17Z

 from kubernetes import config
 from kubernetes.client import Configuration
-from kubernetes.client.apis import core_v1_api
+from kubernetes.client.api import core_v1_api


Is this right? I get an error: ModuleNotFoundError: No module named 'kubernetes.client.api'.

could you print the package info in your code, to see if it's using the updated code from this pull? I suspect you have official kubernetes package installed in your env and the code is using that by default

You can also try modifying your PYTHONPATH variable if you’re under Linux and prioritize searching for the k8s package locally.

roycaihw · 2019-09-13T19:38:27Z

included in #931

/close

k8s-ci-robot · 2019-09-13T19:38:29Z

@roycaihw: Closed this PR.

Details

In response to this:

included in #931
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2019-08-13T01:15:14Z

ref kubernetes-client/gen#93, kubernetes-client/gen#97

This is for reviewing and testing the diff of generated code in master branch. The change is basically:

pick feat: switch python client to use openapi-generator gen#97
run scripts/update-client.sh

but split into logical commits for easier review.

I plan to:

do a 11.0.0a1 release with openapi-generator in release branch (and keep using swagger-codegen in master branch for now)
switch master branch to use openapi-generator and do a 11.0.0b1 release

mostly openapi spec version constant change

to make review easier

k8s-ci-robot · 2019-08-13T01:15:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roycaihw · 2019-08-14T00:55:47Z

Test is green. This is ready for review: 7387639

/cc @micw523 @scottilee @tomplus @yliaog

user-facing changes:

kubernetes.client.apis package is renamed to kubernetes.client.api
- [python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types

non-user-facing changes:

kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

k8s-ci-robot · 2019-08-14T00:55:49Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Test is green. This is ready for review: 7387639
/cc @micw523 @scottilee @tomplus @yliaog
user-facing changes:
kubernetes.client.apis package is renamed to kubernetes.client.api
[python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types
non-user-facing changes:
kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

micw523 · 2019-08-14T14:55:55Z

I remember openapi-generator uses flake8 as the main Python linter and that's why you see the #noqa flags scattered everywhere in the code. We may want to make the switch too in the future since these flags are not recognized by pycodestyle.

The code style test is green right now - I don't think we need to act right now but I may just send in a PR switching us to flake8 when this is merged.

micw523 · 2019-08-14T14:58:21Z

 ## Documentation for API Endpoints

-All URIs are relative to *https://localhost*
+All URIs are relative to *http://localhost*


https -> http?

This is from the code generator. The documentation change looks reasonable to me, since by default the generated client doesn't have TLS set up

micw523 · 2019-08-14T15:05:41Z

-**selector** | [**V1LabelSelector**](V1LabelSelector.md) | Label query over pods whose evictions are managed by the disruption budget. | [optional] 
+**max_unavailable** | [**object**](.md) | An eviction is allowed if at most \&quot;maxUnavailable\&quot; pods selected by \&quot;selector\&quot; are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with \&quot;minAvailable\&quot;. | [optional] 
+**min_available** | [**object**](.md) | An eviction is allowed if at least \&quot;minAvailable\&quot; pods selected by \&quot;selector\&quot; will still be available after the eviction, i.e. even in the absence of the evicted pod. So for example you can prevent all voluntary evictions by specifying \&quot;100%\&quot;. | [optional] 
+**selector** | [**V1LabelSelector**](V1LabelSelector.md) | | [optional] 


Seems like the description of a few parameters have disappeared. The loss of descriptions is very consistent across docs.

The openapi spec didn't change. @tomplus Do you know what may cause the doc change in the generators?

scottilee · 2019-08-15T05:01:17Z

 from kubernetes import config
 from kubernetes.client import Configuration
-from kubernetes.client.apis import core_v1_api
+from kubernetes.client.api import core_v1_api


Is this right? I get an error: ModuleNotFoundError: No module named 'kubernetes.client.api'.

could you print the package info in your code, to see if it's using the updated code from this pull? I suspect you have official kubernetes package installed in your env and the code is using that by default

You can also try modifying your PYTHONPATH variable if you’re under Linux and prioritize searching for the k8s package locally.

roycaihw · 2019-09-13T19:38:27Z

included in #931

/close

k8s-ci-robot · 2019-09-13T19:38:29Z

@roycaihw: Closed this PR.

Details

In response to this:

included in #931
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2019-08-13T01:15:14Z

ref kubernetes-client/gen#93, kubernetes-client/gen#97

This is for reviewing and testing the diff of generated code in master branch. The change is basically:

pick feat: switch python client to use openapi-generator gen#97
run scripts/update-client.sh

but split into logical commits for easier review.

I plan to:

do a 11.0.0a1 release with openapi-generator in release branch (and keep using swagger-codegen in master branch for now)
switch master branch to use openapi-generator and do a 11.0.0b1 release

mostly openapi spec version constant change

to make review easier

k8s-ci-robot · 2019-08-13T01:15:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roycaihw · 2019-08-14T00:55:47Z

Test is green. This is ready for review: 7387639

/cc @micw523 @scottilee @tomplus @yliaog

user-facing changes:

kubernetes.client.apis package is renamed to kubernetes.client.api
- [python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types

non-user-facing changes:

kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

k8s-ci-robot · 2019-08-14T00:55:49Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Test is green. This is ready for review: 7387639
/cc @micw523 @scottilee @tomplus @yliaog
user-facing changes:
kubernetes.client.apis package is renamed to kubernetes.client.api
[python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types
non-user-facing changes:
kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

micw523 · 2019-08-14T14:55:55Z

I remember openapi-generator uses flake8 as the main Python linter and that's why you see the #noqa flags scattered everywhere in the code. We may want to make the switch too in the future since these flags are not recognized by pycodestyle.

The code style test is green right now - I don't think we need to act right now but I may just send in a PR switching us to flake8 when this is merged.

micw523 · 2019-08-14T14:58:21Z

 ## Documentation for API Endpoints

-All URIs are relative to *https://localhost*
+All URIs are relative to *http://localhost*


https -> http?

This is from the code generator. The documentation change looks reasonable to me, since by default the generated client doesn't have TLS set up

micw523 · 2019-08-14T15:05:41Z

-**selector** | [**V1LabelSelector**](V1LabelSelector.md) | Label query over pods whose evictions are managed by the disruption budget. | [optional] 
+**max_unavailable** | [**object**](.md) | An eviction is allowed if at most \&quot;maxUnavailable\&quot; pods selected by \&quot;selector\&quot; are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with \&quot;minAvailable\&quot;. | [optional] 
+**min_available** | [**object**](.md) | An eviction is allowed if at least \&quot;minAvailable\&quot; pods selected by \&quot;selector\&quot; will still be available after the eviction, i.e. even in the absence of the evicted pod. So for example you can prevent all voluntary evictions by specifying \&quot;100%\&quot;. | [optional] 
+**selector** | [**V1LabelSelector**](V1LabelSelector.md) | | [optional] 


Seems like the description of a few parameters have disappeared. The loss of descriptions is very consistent across docs.

The openapi spec didn't change. @tomplus Do you know what may cause the doc change in the generators?

scottilee · 2019-08-15T05:01:17Z

 from kubernetes import config
 from kubernetes.client import Configuration
-from kubernetes.client.apis import core_v1_api
+from kubernetes.client.api import core_v1_api


Is this right? I get an error: ModuleNotFoundError: No module named 'kubernetes.client.api'.

could you print the package info in your code, to see if it's using the updated code from this pull? I suspect you have official kubernetes package installed in your env and the code is using that by default

You can also try modifying your PYTHONPATH variable if you’re under Linux and prioritize searching for the k8s package locally.

roycaihw · 2019-09-13T19:38:27Z

included in #931

/close

k8s-ci-robot · 2019-09-13T19:38:29Z

@roycaihw: Closed this PR.

Details

In response to this:

included in #931
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2019-08-13T01:15:14Z

ref kubernetes-client/gen#93, kubernetes-client/gen#97

This is for reviewing and testing the diff of generated code in master branch. The change is basically:

pick feat: switch python client to use openapi-generator gen#97
run scripts/update-client.sh

but split into logical commits for easier review.

I plan to:

do a 11.0.0a1 release with openapi-generator in release branch (and keep using swagger-codegen in master branch for now)
switch master branch to use openapi-generator and do a 11.0.0b1 release

mostly openapi spec version constant change

to make review easier

k8s-ci-robot · 2019-08-13T01:15:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roycaihw · 2019-08-14T00:55:47Z

Test is green. This is ready for review: 7387639

/cc @micw523 @scottilee @tomplus @yliaog

user-facing changes:

kubernetes.client.apis package is renamed to kubernetes.client.api
- [python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types

non-user-facing changes:

kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

k8s-ci-robot · 2019-08-14T00:55:49Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Test is green. This is ready for review: 7387639
/cc @micw523 @scottilee @tomplus @yliaog
user-facing changes:
kubernetes.client.apis package is renamed to kubernetes.client.api
[python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types
non-user-facing changes:
kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

micw523 · 2019-08-14T14:55:55Z

I remember openapi-generator uses flake8 as the main Python linter and that's why you see the #noqa flags scattered everywhere in the code. We may want to make the switch too in the future since these flags are not recognized by pycodestyle.

The code style test is green right now - I don't think we need to act right now but I may just send in a PR switching us to flake8 when this is merged.

micw523 · 2019-08-14T14:58:21Z

 ## Documentation for API Endpoints

-All URIs are relative to *https://localhost*
+All URIs are relative to *http://localhost*


https -> http?

This is from the code generator. The documentation change looks reasonable to me, since by default the generated client doesn't have TLS set up

micw523 · 2019-08-14T15:05:41Z

-**selector** | [**V1LabelSelector**](V1LabelSelector.md) | Label query over pods whose evictions are managed by the disruption budget. | [optional] 
+**max_unavailable** | [**object**](.md) | An eviction is allowed if at most \&quot;maxUnavailable\&quot; pods selected by \&quot;selector\&quot; are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with \&quot;minAvailable\&quot;. | [optional] 
+**min_available** | [**object**](.md) | An eviction is allowed if at least \&quot;minAvailable\&quot; pods selected by \&quot;selector\&quot; will still be available after the eviction, i.e. even in the absence of the evicted pod. So for example you can prevent all voluntary evictions by specifying \&quot;100%\&quot;. | [optional] 
+**selector** | [**V1LabelSelector**](V1LabelSelector.md) | | [optional] 


Seems like the description of a few parameters have disappeared. The loss of descriptions is very consistent across docs.

The openapi spec didn't change. @tomplus Do you know what may cause the doc change in the generators?

scottilee · 2019-08-15T05:01:17Z

 from kubernetes import config
 from kubernetes.client import Configuration
-from kubernetes.client.apis import core_v1_api
+from kubernetes.client.api import core_v1_api


Is this right? I get an error: ModuleNotFoundError: No module named 'kubernetes.client.api'.

could you print the package info in your code, to see if it's using the updated code from this pull? I suspect you have official kubernetes package installed in your env and the code is using that by default

You can also try modifying your PYTHONPATH variable if you’re under Linux and prioritize searching for the k8s package locally.

roycaihw · 2019-09-13T19:38:27Z

included in #931

/close

k8s-ci-robot · 2019-09-13T19:38:29Z

@roycaihw: Closed this PR.

Details

In response to this:

included in #931
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw · 2019-08-13T01:15:14Z

ref kubernetes-client/gen#93, kubernetes-client/gen#97

This is for reviewing and testing the diff of generated code in master branch. The change is basically:

pick feat: switch python client to use openapi-generator gen#97
run scripts/update-client.sh

but split into logical commits for easier review.

I plan to:

do a 11.0.0a1 release with openapi-generator in release branch (and keep using swagger-codegen in master branch for now)
switch master branch to use openapi-generator and do a 11.0.0b1 release

mostly openapi spec version constant change

to make review easier

k8s-ci-robot · 2019-08-13T01:15:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

roycaihw · 2019-08-14T00:55:47Z

Test is green. This is ready for review: 7387639

/cc @micw523 @scottilee @tomplus @yliaog

user-facing changes:

kubernetes.client.apis package is renamed to kubernetes.client.api
- [python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types

non-user-facing changes:

kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

k8s-ci-robot · 2019-08-14T00:55:49Z

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: scottilee.

Note that only kubernetes-client members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Test is green. This is ready for review: 7387639
/cc @micw523 @scottilee @tomplus @yliaog
user-facing changes:
kubernetes.client.apis package is renamed to kubernetes.client.api
[python-client] Modify python templates to resolve linting errors swagger-api/swagger-codegen#6839 (comment)
generated code now uses absolute import instead of relative import
api requests won't have Content-Type specified in HTTP headers
the swagger_types attribute in all models is renamed to openapi_types
non-user-facing changes:
kubernete/.swagger-codegen is deleted, openapi-generator uses kubernetes/.openapi-generator and also .openapi-generator-ignore instead of .swagger-codegen-ignore (renamed)
various code cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

micw523 · 2019-08-14T14:55:55Z

I remember openapi-generator uses flake8 as the main Python linter and that's why you see the #noqa flags scattered everywhere in the code. We may want to make the switch too in the future since these flags are not recognized by pycodestyle.

The code style test is green right now - I don't think we need to act right now but I may just send in a PR switching us to flake8 when this is merged.

micw523 · 2019-08-14T14:58:21Z

 ## Documentation for API Endpoints

-All URIs are relative to *https://localhost*
+All URIs are relative to *http://localhost*


https -> http?

This is from the code generator. The documentation change looks reasonable to me, since by default the generated client doesn't have TLS set up

micw523 · 2019-08-14T15:05:41Z

-**selector** | [**V1LabelSelector**](V1LabelSelector.md) | Label query over pods whose evictions are managed by the disruption budget. | [optional] 
+**max_unavailable** | [**object**](.md) | An eviction is allowed if at most \&quot;maxUnavailable\&quot; pods selected by \&quot;selector\&quot; are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with \&quot;minAvailable\&quot;. | [optional] 
+**min_available** | [**object**](.md) | An eviction is allowed if at least \&quot;minAvailable\&quot; pods selected by \&quot;selector\&quot; will still be available after the eviction, i.e. even in the absence of the evicted pod. So for example you can prevent all voluntary evictions by specifying \&quot;100%\&quot;. | [optional] 
+**selector** | [**V1LabelSelector**](V1LabelSelector.md) | | [optional] 


Seems like the description of a few parameters have disappeared. The loss of descriptions is very consistent across docs.

The openapi spec didn't change. @tomplus Do you know what may cause the doc change in the generators?

scottilee · 2019-08-15T05:01:17Z

 from kubernetes import config
 from kubernetes.client import Configuration
-from kubernetes.client.apis import core_v1_api
+from kubernetes.client.api import core_v1_api


Is this right? I get an error: ModuleNotFoundError: No module named 'kubernetes.client.api'.

could you print the package info in your code, to see if it's using the updated code from this pull? I suspect you have official kubernetes package installed in your env and the code is using that by default

You can also try modifying your PYTHONPATH variable if you’re under Linux and prioritize searching for the k8s package locally.

roycaihw · 2019-09-13T19:38:27Z

included in #931

/close

k8s-ci-robot · 2019-09-13T19:38:29Z

@roycaihw: Closed this PR.

Details

In response to this:

included in #931
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roycaihw added 5 commits August 12, 2019 17:46

re-generate client using swagger-codegen
fc9dfc8
mostly openapi spec version constant change

pick openapi-generator switch
045bcd7

re-generator client using openapi-generator, but move api back to apis
7387639
to make review easier

move apis to api as openapi-generator does
596f510

change apis import to api
7ca1c36

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019

roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019

k8s-ci-robot requested review from micw523 and yliaog August 13, 2019 01:21

roycaihw added 2 commits August 13, 2019 14:11

re-create rest client patch
1e6ea6f

re-apply rest client patch
77a1d3d

k8s-ci-robot requested a review from tomplus August 14, 2019 00:55

micw523 reviewed Aug 14, 2019
View reviewed changes

scottilee reviewed Aug 15, 2019
View reviewed changes

roycaihw mentioned this pull request Aug 15, 2019
Release 11.0.0a1 #931
Merged

k8s-ci-robot closed this Sep 13, 2019

roycaihw added 5 commits August 12, 2019 17:46

re-generate client using swagger-codegen
fc9dfc8
mostly openapi spec version constant change

pick openapi-generator switch
045bcd7

re-generator client using openapi-generator, but move api back to apis
7387639
to make review easier

move apis to api as openapi-generator does
596f510

change apis import to api
7ca1c36

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019

roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019

k8s-ci-robot requested review from micw523 and yliaog August 13, 2019 01:21

roycaihw added 2 commits August 13, 2019 14:11

re-create rest client patch
1e6ea6f

re-apply rest client patch
77a1d3d

k8s-ci-robot requested a review from tomplus August 14, 2019 00:55

micw523 reviewed Aug 14, 2019
View reviewed changes

scottilee reviewed Aug 15, 2019
View reviewed changes

roycaihw mentioned this pull request Aug 15, 2019
Release 11.0.0a1 #931
Merged

k8s-ci-robot closed this Sep 13, 2019

roycaihw added 5 commits August 12, 2019 17:46

re-generate client using swagger-codegen
fc9dfc8
mostly openapi spec version constant change

pick openapi-generator switch
045bcd7

re-generator client using openapi-generator, but move api back to apis
7387639
to make review easier

move apis to api as openapi-generator does
596f510

change apis import to api
7ca1c36

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019

roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019

k8s-ci-robot requested review from micw523 and yliaog August 13, 2019 01:21

roycaihw added 2 commits August 13, 2019 14:11

re-create rest client patch
1e6ea6f

re-apply rest client patch
77a1d3d

k8s-ci-robot requested a review from tomplus August 14, 2019 00:55

micw523 reviewed Aug 14, 2019
View reviewed changes

scottilee reviewed Aug 15, 2019
View reviewed changes

roycaihw mentioned this pull request Aug 15, 2019
Release 11.0.0a1 #931
Merged

k8s-ci-robot closed this Sep 13, 2019

roycaihw added 5 commits August 12, 2019 17:46

re-generate client using swagger-codegen
fc9dfc8
mostly openapi spec version constant change

pick openapi-generator switch
045bcd7

re-generator client using openapi-generator, but move api back to apis
7387639
to make review easier

move apis to api as openapi-generator does
596f510

change apis import to api
7ca1c36

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019

roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019

k8s-ci-robot requested review from micw523 and yliaog August 13, 2019 01:21

roycaihw added 2 commits August 13, 2019 14:11

re-create rest client patch
1e6ea6f

re-apply rest client patch
77a1d3d

k8s-ci-robot requested a review from tomplus August 14, 2019 00:55

micw523 reviewed Aug 14, 2019
View reviewed changes

scottilee reviewed Aug 15, 2019
View reviewed changes

roycaihw mentioned this pull request Aug 15, 2019
Release 11.0.0a1 #931
Merged

k8s-ci-robot closed this Sep 13, 2019

roycaihw added 5 commits August 12, 2019 17:46

re-generate client using swagger-codegen
fc9dfc8
mostly openapi spec version constant change

pick openapi-generator switch
045bcd7

re-generator client using openapi-generator, but move api back to apis
7387639
to make review easier

move apis to api as openapi-generator does
596f510

change apis import to api
7ca1c36

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019

roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019

k8s-ci-robot requested review from micw523 and yliaog August 13, 2019 01:21

roycaihw added 2 commits August 13, 2019 14:11

re-create rest client patch
1e6ea6f

re-apply rest client patch
77a1d3d

k8s-ci-robot requested a review from tomplus August 14, 2019 00:55

micw523 reviewed Aug 14, 2019
View reviewed changes

scottilee reviewed Aug 15, 2019
View reviewed changes

roycaihw mentioned this pull request Aug 15, 2019
Release 11.0.0a1 #931
Merged

k8s-ci-robot closed this Sep 13, 2019

roycaihw added 5 commits August 12, 2019 17:46

re-generate client using swagger-codegen
fc9dfc8
mostly openapi spec version constant change

pick openapi-generator switch
045bcd7

re-generator client using openapi-generator, but move api back to apis
7387639
to make review easier

move apis to api as openapi-generator does
596f510

change apis import to api
7ca1c36

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019

roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019

k8s-ci-robot requested review from micw523 and yliaog August 13, 2019 01:21

roycaihw added 2 commits August 13, 2019 14:11

re-create rest client patch
1e6ea6f

re-apply rest client patch
77a1d3d

k8s-ci-robot requested a review from tomplus August 14, 2019 00:55

micw523 reviewed Aug 14, 2019
View reviewed changes

scottilee reviewed Aug 15, 2019
View reviewed changes

roycaihw mentioned this pull request Aug 15, 2019
Release 11.0.0a1 #931
Merged

k8s-ci-robot closed this Sep 13, 2019

roycaihw added 5 commits August 12, 2019 17:46

re-generate client using swagger-codegen
fc9dfc8
mostly openapi spec version constant change

pick openapi-generator switch
045bcd7

re-generator client using openapi-generator, but move api back to apis
7387639
to make review easier

move apis to api as openapi-generator does
596f510

change apis import to api
7ca1c36

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019

roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019

k8s-ci-robot requested review from micw523 and yliaog August 13, 2019 01:21

roycaihw added 2 commits August 13, 2019 14:11

re-create rest client patch
1e6ea6f

re-apply rest client patch
77a1d3d

k8s-ci-robot requested a review from tomplus August 14, 2019 00:55

micw523 reviewed Aug 14, 2019
View reviewed changes

scottilee reviewed Aug 15, 2019
View reviewed changes

roycaihw mentioned this pull request Aug 15, 2019
Release 11.0.0a1 #931
Merged

k8s-ci-robot closed this Sep 13, 2019

roycaihw added 5 commits August 12, 2019 17:46

re-generate client using swagger-codegen
fc9dfc8
mostly openapi spec version constant change

pick openapi-generator switch
045bcd7

re-generator client using openapi-generator, but move api back to apis
7387639
to make review easier

move apis to api as openapi-generator does
596f510

change apis import to api
7ca1c36

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2019

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019

roycaihw added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2019

k8s-ci-robot requested review from micw523 and yliaog August 13, 2019 01:21

roycaihw added 2 commits August 13, 2019 14:11

re-create rest client patch
1e6ea6f

re-apply rest client patch
77a1d3d

k8s-ci-robot requested a review from tomplus August 14, 2019 00:55

micw523 reviewed Aug 14, 2019
View reviewed changes

scottilee reviewed Aug 15, 2019
View reviewed changes

roycaihw mentioned this pull request Aug 15, 2019
Release 11.0.0a1 #931
Merged

k8s-ci-robot closed this Sep 13, 2019

Uh oh!

Conversation

roycaihw commented Aug 13, 2019

Uh oh!

k8s-ci-robot commented Aug 13, 2019

Uh oh!

roycaihw commented Aug 14, 2019

Uh oh!

k8s-ci-robot commented Aug 14, 2019

Uh oh!

micw523 commented Aug 14, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roycaihw commented Sep 13, 2019

Uh oh!

k8s-ci-robot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

roycaihw commented Aug 13, 2019

Uh oh!

k8s-ci-robot commented Aug 13, 2019

Uh oh!

roycaihw commented Aug 14, 2019

Uh oh!

k8s-ci-robot commented Aug 14, 2019

Uh oh!

micw523 commented Aug 14, 2019

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roycaihw commented Sep 13, 2019

Uh oh!

k8s-ci-robot commented Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development