🌱 code clean for pkg/envtest/server.go - #2180
Conversation
|
Hi @yanggangtony. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -229,18 +229,18 @@ func (te *Environment) Start() (*rest.Config, error) { | |||
|
|
|||
| if os.Getenv(envAttachOutput) == "true" { | |||
| te.AttachControlPlaneOutput = true | |||
There was a problem hiding this comment.
@yanggangtony AttachControlPlaneOutput is set to true if os.Getenv(envAttachOutput) == "true", however it can also be true if os.Getenv(envAttachOutput) != "true" and the AttachControlPlaneOutput value was set to true.
So, please create a new if te.AttachControlPlaneOutput { statement.
Signed-off-by: yanggang <gang.yang@daocloud.io>
|
@inteon |
|
@yanggangtony can you fix the typo in this PR, replace |
inteon
left a comment
There was a problem hiding this comment.
Super small code-style change
/approve
/lgtm
|
thanks for review.. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, inteon, yanggangtony The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yanggang gang.yang@daocloud.io
/kind cleanup
Code clean for evntest.server.
Because the variable
AttachControlPlaneOutputis only used in theos.Getenv(envAttachOutput)method..Maybe we should clean the code for that condition.