Skip to content

fix(gen-apidocs): bucket ByKind by group+kind to avoid cross-group collisions - #447

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
Caesarsage:fix/bykind-group-aware
May 10, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
Caesarsage:fix/bykind-group-aware

Conversation

@Caesarsage

Copy link
Copy Markdown
Contributor

Key ByKind by (group, kind) instead of kind alone:

Closes: #446

@k8s-ci-robot
k8s-ci-robot requested review from feloy and onlydole May 7, 2026 16:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2026

@tengqm tengqm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Caesarsage, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 76de01d into kubernetes-sigs:master May 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gen-apidocs: ByKind keyed by name only causes cross-group IsOldVersion false positives

3 participants