Skip to content

Updated kubernetes-client owners with sai-adarsh - #583

Closed
Sai-Adarsh wants to merge 1 commit into
kubernetes:masterfrom
Sai-Adarsh:master
Closed

Updated kubernetes-client owners with sai-adarsh#583
Sai-Adarsh wants to merge 1 commit into
kubernetes:masterfrom
Sai-Adarsh:master

Conversation

@Sai-Adarsh

@Sai-AdarshSai-Adarsh commented Mar 8, 2019

Copy link
Copy Markdown

Would like to join a GitHub team of kubernetes-client, and highly interested to join as a reviewer. Have previously merged a fix (kubernetes-client/python#734).

@k8s-ci-robotk8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 8, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @Sai-Adarsh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robotk8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sai-Adarsh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: spiffxp

If they are not already assigned, you can assign the PR to them by writing /assign @spiffxp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sai-Adarsh

Copy link
Copy Markdown
Author

/assign @justaugustus


reviewers:
- justaugustus
- sai-adarsh

@nikhitanikhitaMar 8, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@nikhita: Closed this PR.

Details

In response to this:

@Sai-Adarsh the reviwers are defined as per https://github.com/kubernetes/community/tree/master/github-management#new-membership-coordinator. :)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita

Copy link
Copy Markdown
Member

If you'd like to review kubernetes-client/python PRs, you need to add yourself as a reviewer here: https://github.com/kubernetes-client/python/blob/master/OWNERS

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.needs-ok-to-testIndicates a PR that requires an org member to verify it is safe to test.size/XSDenotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Sai-Adarsh@k8s-ci-robot@nikhita@justaugustus