Conversation
|
Summary:
|
2 similar comments
|
Summary:
|
|
Summary:
|
|
Summary:
|
2 similar comments
|
Summary:
|
|
Summary:
|
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
|
Summary:
|
1 similar comment
|
Summary:
|
matthyx
force-pushed
the
zero
branch
2 times, most recently
from
August 1, 2023 08:39
7225a0c to
472450d
Compare
|
Summary:
|
|
Summary:
|
matthyx
force-pushed
the
zero
branch
8 times, most recently
from
August 1, 2023 13:29
b905565 to
90bd9c8
Compare
|
Summary:
|
matthyx
force-pushed
the
zero
branch
2 times, most recently
from
August 2, 2023 13:11
ab6fe2a to
82e7396
Compare
|
Summary:
|
|
Summary:
|
|
Summary:
|
|
Summary:
|
|
Summary:
|
|
Summary:
|
matthyx
force-pushed
the
zero
branch
3 times, most recently
from
August 3, 2023 12:52
3c8847f to
400f302
Compare
|
Summary:
|
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
|
Summary:
|
matthyx
marked this pull request as ready for review
August 3, 2023 14:25
|
Summary:
|
1 similar comment
|
Summary:
|
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
|
Summary:
|
|
/improve |
dwertent
approved these changes
Aug 4, 2023
dwertent
left a comment
There was a problem hiding this comment.
Well done!
Please see my comments :)
| EnableRelevancy bool `mapstructure:"relevantCVEServiceEnabled"` | ||
| InitialDelay time.Duration `mapstructure:"initialDelay"` | ||
| MaxSniffingTime time.Duration `mapstructure:"maxSniffingTimePerContainer"` | ||
| UpdateDataPeriod time.Duration `mapstructure:"updateDataPeriod"` |
There was a problem hiding this comment.
We should add this to the helm chart as well
There was a problem hiding this comment.
Also, we should have default values (if missing from config)
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
what we should modify in the helm chart is the updateDataPeriod as well as the resources...
| }) | ||
| } | ||
|
|
||
| func (b BoltFileHandler) AddFiles(bucket string, files map[string]bool) error { |
There was a problem hiding this comment.
We should consider removing the boltdb support so we wont need to maintain it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is with full_path enabled for trace_open and trace_openat:
