Conversation
Signed-off-by: entlein <einentlein@gmail.com>
📝 WalkthroughWalkthroughChangesResolved full-path handling
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
entlein
marked this pull request as ready for review
August 6, 2026 08:11
entlein
marked this pull request as draft
August 7, 2026 16:50
Contributor
Author
|
Closing in favor of #889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it could be as simple as this, currently testing for various side effects as tag=
sbob-rc5s-osp-> Edit: its only half the rent, there is more to the story. This current patch does help, but I havnt had time to check where thosescrambledlookups were introduced.More info can be found here:
k8sstormcenter/bob#183
Summary by CodeRabbit
Bug Fixes
Tests