🐛 Fix dashboard-lint CI proposal referencing nonexistent script - #6934
Conversation
The workflow-proposals/dashboard-lint.yml proposal (added in #6745) references scripts/lint-dashboards.py, which does not exist in this repo. The real, tested, wired-up lint lives at scripts/lint-dashboard.mjs (Node.js, exposed as `npm run lint:dashboard`, unit-tested in scripts/lint-dashboard-helpers.test.mjs). If this proposal were promoted into .github/workflows/ as-is, the job would fail immediately (pip install pyyaml + python3 scripts/lint-dashboards.py against a file that isn't there). This updates the proposal to invoke the actual script via npm/node so it is correct and ready for a human/merge-capable agent to promote. Verified locally: `npm run lint:dashboard` passes against the current cluster-objects/dashboard.json and alerts.yaml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: hive-telemetry <223556219+Copilot@users.noreply.github.com>
|
Important Held for human sign-off on the direction, not on the code. This PR's only tracked rationale is #6933, which the hive filed itself — issue #6933 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117). The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
❌ Deploy Preview for kubestellar-docs failed. Why did it fail? →
|
|
Hi @kubestellar-hive[bot]. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hold released: self-authorization hold disabled by config (#5117) |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
Fixes #6933
What
.github/workflow-proposals/dashboard-lint.ymlinvokedpython3 scripts/lint-dashboards.py, a script that doesn't exist in this repo. It's updated to invoke the real, tested dashboard/alert-rule lint vianpm run lint:dashboard(backed byscripts/lint-dashboard.mjs).Why
The proposal (from #6745) was never promoted into
.github/workflows/, and if it had been, it would have failed immediately — there is noscripts/lint-dashboards.pyin this repo. Meanwhilescripts/lint-dashboard.mjsalready exists, is exposed asnpm run lint:dashboard, and has 26 passing unit tests inscripts/lint-dashboard-helpers.test.mjs. This PR makes the proposal match reality so it's ready to promote.Verification
Scope note
This PR only touches
.github/workflow-proposals/dashboard-lint.yml— not.github/workflows/. Promoting the fixed proposal into an active.github/workflows/dashboard-lint.ymlstill requires a human or a merge-capable agent; this agent's token doesn't carry theworkflowspermission needed to create/update files under.github/workflows/.— hive: agent=telemetry backend=copilot model=claude-sonnet-4-6