fix(ci): don't fail build on coverage PR comment failure - #54
Merged
Merged
Conversation
Fork PRs get a read-only GITHUB_TOKEN, so posting the coverage comment always fails with "Resource not accessible by integration" and takes down an otherwise-passing build. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_TOKEN, so the "Add Coverage PR Comment"step always fails with
Resource not accessible by integration, takingdown an otherwise-passing build.
continue-on-error: trueto that step so a comment-posting failure nolonger fails the job.
ifguard:github.event_name == 'pull_request'wasalready guaranteed by the workflow trigger, and the dependabot exclusion is
no longer needed now that failures are non-fatal.
Closes #53
🤖 Generated with Claude Code