fix: stamp assembly version from the release tag - #61
Merged
Merged
Conversation
The publish workflow passed the tag as -p:PackageVersion, which the SDK reads only when writing the .nuspec. AssemblyVersion, AssemblyFileVersion and AssemblyInformationalVersion default from Version, which was never set, so every published assembly carried 1.0.0.0 while the package carried the tag. Pass the tag as -p:Version instead. It is the root property the others default from, so the package version is unchanged and the assembly attributes now match.
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Pass the release tag as
-p:Versioninstead of-p:PackageVersion.Versionis the root property the others default from, so one property coversthe package and all three assembly attributes:
The package version is unchanged; only the assembly metadata is corrected.
Existing published packages are unaffected — this applies from the next tag on.
Note that
AssemblyVersionnow moves with every release, and that a prereleasetag stamps only its numeric part into
AssemblyVersion/FileVersionwhileInformationalVersionkeeps the full string. Both are standard SDK behaviour.🤖 Generated with Claude Code