Uh oh!
There was an error while loading. Please reload this page.
Add Dependabot Integration for Cargo packages - #109
Conversation
davidbtadokoro
commented
Mar 5, 2025
Hey, @ivinjabraham, thanks for yet another PR! I see that Nevertheless, I am a little skeptical about this approach as I think it can potentially spam the pull-request tab, as there may be many, many version bumps weekly. I am not vetoing the idea, as we need to do chores like this sooner or later, but I don't feel like this is a priority right now... In any case, I am going to chew a little bit more on the idea, and I will ping you back. Thanks! |
Ah great point! I now recall having this annoyance in a previous project. It definitely can create a lot of PRs and IIRC it can even cause conflicts in the lock file. Should I change the interval to be monthly or even bimonthly? |
ebe7669 to
ac65be8Compare
davidbtadokoro
left a comment
There was a problem hiding this comment.
@ivinjabraham, thanks for the answer! I thought about longer and think making it monthly is worth the shot. I also added two simple comments, so see if you can address them.
| groups: | ||
| all-dependencies: | ||
| applies-to: version-updates | ||
| patterns: | ||
| - "*" |
There was a problem hiding this comment.
Can you explain why we did this here? It seems that groups isn't obligatory. I imagine you are doing it due to version-updates, which my search pointed out doesn't consider "minor" releases like bug fixes. If I am right, maybe we can make the update unrestricted and see if it works.
| - package-ecosystem: "cargo" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
There was a problem hiding this comment.
As mentioned in your comment, lets make it monthly and see how it works out.
ac65be8 to
f00287aCompareAdded a `.github/dependabot.yml` configuration file to enable dependabot for automatically bumping versions of dependencies when possible. This helps dependencies stay up to date. Signed-off-by: Ivin Joel Abraham <ivinjabraham@gmail.com>
f00287a to
74a5f6bComparedavidbtadokoro
commented
Mar 15, 2025
Thanks again! Let's give it a shot and see if it works! The only change I made was to limit the PRs to 10 instead of 1 and the commit message from Change merged into the unstable branch 👍 |
ivinjabraham
commented
Mar 16, 2025
I haven't confirmed this in practice, but from what I read, Dependabot automatically updates an existing PR if a new version for the same crate is detected. And since we're grouping all crates into one PR, then I don't think the PR limit changes anything. That's why I made the change from 10 to 1. |
davidbtadokoro
commented
Mar 18, 2025
Oh, my bad! I didn't know about this! I will make a PR fixing this. Thanks for the heads-up! |
This PR introduces Dependabot to automate dependency updates for patch-hub. Dependabot will check for new versions of dependencies every week and if any are found, it will send a PR to
unstablebumping the versions up.