General reorganization and fix #22. - #34
Open
StoneyJackson wants to merge 11 commits into
Open
Conversation
* Move all JSON files to configs/. * Move all Python files except assignmentconvert.py under grade/. * grade/ is now the root python package for this project. * Add run_tests.py to run all the tests. Ultimately the JSON files should probably be stored along with their courses and be removed from this repository. That way, if there is a change to a course, this repository should not change.
In Python, modules are used to group related classes (and functions, attributes, constants, etc.). When importing a module, one wants to import everything related to that topic. In our case, Assignment and Command work together to form the assignment processing engine.
I think from submissions import Processor ... class ToPdf(Processor): reads better than from grade import App ... class ToPdf(App):
Command('ls "{ins}"')
should now be
Command('ls {ins}')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grademodule (grade.py)testspackage.Ultimately the JSON files should probably be stored along with their courses and
be removed from this repository. That way, if there is a change to a course,
this repository should not change.