Skip to content

delete unused context in body_limit.go - #2483

Merged
aldas merged 3 commits into
labstack:masterfrom
mobinanoorii:master
Jul 21, 2023
Merged

delete unused context in body_limit.go#2483
aldas merged 3 commits into
labstack:masterfrom
mobinanoorii:master

Conversation

@mobinanoorii

Copy link
Copy Markdown
Contributor

according to this issue, I remove unused context in limitedReader struct

Comment threadmiddleware/body_limit.go
@aldas

aldas commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

please run tests after changes and commit things that pass the tests. Currently this PR removes a field but one test still uses it.

if you are using Linux, probably MacOS also - you can just run make in CLI which will execute linter and tests for your.

@mobinanoorii

mobinanoorii commented Jul 18, 2023

Copy link
Copy Markdown
ContributorAuthor

should I update the test file too?
because of we don't need context anymore

@aldas

aldas commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

yes, tests need to be fixed as they fail after that change. As this PR is deleting that field - parts that require that field need to be changed in tests.

@mobinanoorii

Copy link
Copy Markdown
ContributorAuthor

Ok I amend my latest commit and push again

@codecov

codecovBot commented Jul 18, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01⚠️

Comparison is base (a2e7085) 92.82% compared to head (adc9aee) 92.81%.

Additional details and impacted files
@@ Coverage Diff @@## master #2483 +/- ##
==========================================
- Coverage 92.82% 92.81% -0.01% 
==========================================
Files 39 39 Lines 4624 4623 -1 ==========================================
- Hits 4292 4291 -1 
Misses 241 241 Partials 91 91 
Impacted FilesCoverage Δ
middleware/body_limit.go95.91% <100.00%> (-0.09%)⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aldas
aldas merged commit 3f8ae15 into labstack:masterJul 21, 2023
@aldasaldas mentioned this pull request Oct 11, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mobinanoorii@aldas