Uh oh!
There was an error while loading. Please reload this page.
fix(subscribe): restore NIP-05 resolution + Nostr send, derive npub automatically - #32
Merged
Merged
Conversation
…utomatically PR #31 replaced the NewsletterCTA NIP-05 flow with a manual email/npub form, dropping the Nostr notification send. Restore the original flow and integrate the events.lacrypta.ar CRM subscription into it instead: - No manual npub field. The npub is derived from the resolved NIP-05 (resolved.pubkey) and registered in the CRM automatically. - Bring back NIP-05 resolution → profile preview → email / Nostr / both notification (Resend welcome email + NIP-17 relay publish). - handleNotify now also POSTs to /api/events-subscribe (npub always; email and display name when the user opts into email) as the first step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR adds CRM list ID configuration with conflict-retry logic to the subscription route, and comprehensively rewrites the newsletter CTA to resolve NIP-05 addresses, support multi-action subscription (email, Nostr, or both), and publish notification events across Nostr relays with per-relay progress tracking. ChangesNewsletter and CRM Subscription Flow
Sequence DiagramsequenceDiagram
participant User
participant CTA as NewsletterCTA
participant Resolve as resolveInput
participant API as API Endpoints
participant Pool as SimplePool
participant Relay as Relays
User->>CTA: Enter NIP-05 address
CTA->>Resolve: Resolve NIP-05 (debounced 500ms)
Resolve->>Resolve: Query profile, fetch metadata
Resolve->>CTA: Return pubkey + profile + relays
CTA->>CTA: Update resolution status
User->>CTA: Click Notify (Nostr)
CTA->>API: POST /api/nostr-opportunity-notification
API->>CTA: Return signed event
CTA->>Pool: Initialize SimplePool with relays
Pool->>Relay: Publish event to each relay
Relay->>Pool: Update progress per relay
Pool->>CTA: Per-relay progress callbacks
CTA->>CTA: Update progress panel
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
… polish
Newsletter/subscribe refinements on top of the restored NIP-05 flow:
events-subscribe route:
- Subscribe contacts into a CRM list via EVENTS_SUBSCRIBE_LISTS (defaults to
the main newsletter list), forwarded as the `lists` array.
- Gracefully handle 409 identity_conflict on combined email+npub submissions
by retrying each identifier alone (email first) so the contact still lands
in the list.
NewsletterCTA:
- Only send `npub` when the user opts into Nostr, so email-only subscriptions
don't trigger identity_conflict.
- Button visibility: "Notificar por Nostr" is disabled until the NIP-05
resolves and hidden if it resolves badly; "Email + Nostr" is hidden until a
clean resolution; "Notificar por email" stays available (and no error text)
when the NIP-05 fails to resolve. Grid adapts to the visible button count.
- Removed the descriptive NIP-17 panel; re-added the per-relay publish
progress as its own card that auto-scrolls into view during a Nostr publish.
- Combined success line "Te notificamos email y nostr a {email}" when both
channels complete; preview card widened to match the form.
.env.example: document EVENTS_SUBSCRIBE_LISTS.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Follow-up to #31. That PR replaced the homepage
NewsletterCTANIP-05 flow with a manual email/npub form and dropped the Nostr notification send. This restores the original flow and integrates theevents.lacrypta.arCRM subscription into it instead.Changes (single file:
components/sections/NewsletterCTA.tsx)resolved.pubkey) — the user only enters a NIP-05.handleNotifynow also registers the subscriber in the events CRM viaPOST /api/events-subscribe(npub always; email + display name when the user opts into email) as the first step, before the existing Resend + Nostr notification.Verification
tsc --noEmitclean./api/events-subscribeaccepts the raw hex pubkey the component sends (resolved.pubkey), encodes it to bech32, and the CRM registers it (200 / Subscribed) — verified live.Routes the restored component depends on (
/api/subscribe,/api/nostr-opportunity-notification) already exist inmain.🤖 Generated with Claude Code
Summary by CodeRabbit