Uh oh!
There was an error while loading. Please reload this page.
Expire the home "Resultados publicados" hero one week after voting closes - #71
Conversation
The "Resultados publicados" hero stayed on the home page indefinitely after a voting round closed. Treat it as a temporary announcement on home: show it for 7 days after the round's closedAt, then render nothing (also hidden if closedAt is missing). The hackathon page keeps its results permanently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Uh oh!
There was an error while loading. Please reload this page.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesVoting hero expiration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
The closed/results state of
VotingHero(the "Resultados publicados" podium) stayed on the home page indefinitely after a voting round closed. It is now a temporary announcement on home: it shows for 7 days after the round'sclosedAtand then renders nothing. IfclosedAtis somehow missing on a closed period, home hides it too (nothing to anchor the window to).The hackathon page (
variant="page") is untouched — its Resultados tab keeps the podium and the 70/30 breakdown permanently.Why
The GAMING round closed on June 30 (~3 weeks ago) and the results hero was still the first thing logged-out visitors saw on the home page. The rule is generic: when a future round (e.g. AI AGENTS) closes, its results will appear on home automatically for a week and then disappear on their own.
Notes for review
period.closedAtis unix seconds (frozen at close bycomputeVotingRanking), converted to ms for the comparison."use cache"render) and to live updates fromuseVotingLive. At the exact 7-day boundary the cached home HTML may lag until the next revalidation; the client check hides it on hydration regardless./hackathons/gamingstill shows the full podium and final table,tsc --noEmitis clean.🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Documentation