Feature (Module): Add BetterFirework Module by IceTank · Pull Request #154 · lambda-client/lambda

IceTank · 2025-09-28T21:27:26Z

This Module adds better Fireworks utility. Features include:

Auto takeoff while standing or falling by interacting with fireworks
Auto takeoff on middle click (pick block key)
Auto firework use on middle click
Silent firework use from inventory with middle click

emyfops · 2025-10-14T13:58:06Z

+ private fun SafeContext.getFireworkAtHotbar(): Int {
+ for (i in 0..8) {
+ val itemStack: ItemStack = player.getInventory().getStack(i)
+ if (itemStack.item !== Items.FIREWORK_ROCKET) continue
+ return i
+ }
+ return -1
+ }
+
+ private fun SafeContext.getFireworkInInventoryScreen(): Int {
+ val screenHandler: PlayerScreenHandler = player.playerScreenHandler
+ for (i in PlayerScreenHandler.INVENTORY_START..<PlayerScreenHandler.INVENTORY_END) {
+ val itemStack = screenHandler.getSlot(i).stack
+ if (itemStack.item !== Items.FIREWORK_ROCKET) continue
+ return i
+ }
+ return -1
+ }


We have utils to find and swap items

I could not find any utils that tell me what inventory index the found items are in. We looked at this like 3 weeks ago. You couldn't find any either.

IceTank · 2025-10-27T09:54:49Z

@Edouard127 so we merge?

beanbag44

just small things. Also, for single line if blocks, its often cleaner to omit the braces and keep them on the same line or at least the action after the check. Like this:

if (something) doSomething()
else if (something else) doSomethingElse()

beanbag44 · 2025-10-31T11:22:18Z

+ tag = ModuleTag.MOVEMENT,
+) {
+ private var fireworkInteract by setting("Firework Interact", true, "Automatically start flying when right clicking fireworks")
+ private var fireworkInteractCancel by setting("Firework Interact Cancel", false, "Cancel block interactions while holding fireworks") { fireworkInteract }


Its annoying sometimes when you fly into a wall and try to use a firework for it to spam it on a block. Maybe this could be a general setting rather than an extension of fireworkInteract

You can just enable the Module

beanbag44 · 2025-10-31T11:22:35Z

+ description = "Automatic takeoff with fireworks",
+ tag = ModuleTag.MOVEMENT,
+) {
+ private var fireworkInteract by setting("Firework Interact", true, "Automatically start flying when right clicking fireworks")


I would have used the name "Right Click Fly" instead of "Firework Interact"

beanbag44 · 2025-10-31T11:37:39Z

+ interaction.clickSlot(player.playerScreenHandler.syncId, swap, 0, SlotActionType.SWAP, mc.player)
+
+ if (player.getInventory().selectedSlot != 0) {
+ player.networkHandler.sendPacket(UpdateSelectedSlotC2SPacket(0))


this should request the hotbar manager with keep ticks set to 0 for silent swap

beanbag44 · 2025-10-31T11:41:52Z

+ enum class TakeoffState {
+ NONE,
+ JUMPING,
+ START_FLYING


these should be in camel case

beanbag44

just one thing, aside from that i think its good

beanbag44 · 2025-11-01T23:10:26Z

+ tag = ModuleTag.MOVEMENT,
+) {
+ private var fireworkInteract by setting("Right Click Fly", true, "Automatically start flying when right clicking fireworks").group(Group.General)
+ private var fireworkInteractCancel by setting("Right Click Cancel", false, "Cancel block interactions while holding fireworks") { fireworkInteract }.group(Group.General)


i meant that this shouldn't be dependent on right click fly to be a feature. This should be its own option, separate from firework interact

…erFirework

… stuff

IceTank · 2025-11-24T16:08:23Z

@emyfops you approve?

Set default options that actually work

emyfops

lgtm

github-actionsBot added the triage Requires labelling or review label Sep 28, 2025

IceTank changed the title ~~Add BetterFirework Module~~Feature (Module): Add BetterFirework ModuleSep 28, 2025

IceTank added the feature Suggests or adds a new feature label Sep 28, 2025

emyfops suggested changes Oct 14, 2025
View reviewed changes

IceTank force-pushed the feature/module/BetterFirework branch from cfc96c2 to c1b167eCompare October 14, 2025 14:35

beanbag44 self-requested a review October 31, 2025 11:46

beanbag44 requested changes Oct 31, 2025
View reviewed changes

IceTank force-pushed the feature/module/BetterFirework branch from daebacd to e76fb57Compare November 1, 2025 21:31

beanbag44 requested changes Nov 1, 2025
View reviewed changes

IceTankand others added 6 commits November 2, 2025 15:06

Add BetterFirework Module
9fe2924

Refactor BetterFirework settings and some code
9f8f08d

Update logic handling in BetterFirework.kt
2e9dda1

Nits
10f1127

Use HotbarManager to swap to firework slots
b30d8b8

Change enums to Camel case
903aff1

IceTank force-pushed the feature/module/BetterFirework branch from ec590d4 to 99a3940Compare November 2, 2025 15:05

IceTank added 5 commits November 2, 2025 16:07

Add Universal Keybind to BetterFirework.kt
99a3940

Simplify Keyboard and Mouse Event listener
6aea738

Merge remote-tracking branch 'origin/1.21.5' into feature/module/Bett…
b9b22fb
…erFirework

Update BetterFirework to use InventoryManager for inventory switching…
052fdff
… stuff

Clean up code
7996ec9

beanbag44 requested changes Nov 23, 2025
View reviewed changes

Comment threadsrc/main/kotlin/com/lambda/module/modules/movement/BetterFirework.kt Outdated
Comment threadsrc/main/kotlin/com/lambda/module/modules/movement/BetterFirework.kt Outdated
Comment threadsrc/main/kotlin/com/lambda/module/modules/movement/BetterFirework.kt Outdated

Add mid-flight activation keybind
060a7d9

IceTank self-assigned this Nov 23, 2025

IceTank requested a review from beanbag44 November 23, 2025 17:55

IceTankand others added 4 commits November 23, 2025 18:56

Update BetterFirework code
d9bd005

Lint code
0d513e1

whens and requests
e0acb2f

forgot to update indenting
05a7d1a

beanbag44 approved these changes Nov 24, 2025
View reviewed changes

Rename silent to Inventory
f59490b
Set default options that actually work

emyfops approved these changes Nov 27, 2025
View reviewed changes

Merge branch '1.21.5' into feature/module/BetterFirework
e6d7e3c

emyfops merged commit 9554ee9 into 1.21.5Nov 27, 2025
1 check failed

Uh oh!

Conversation

IceTank commented Sep 28, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

IceTank commented Oct 27, 2025

Uh oh!

beanbag44 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

beanbag44 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IceTank commented Nov 24, 2025

Uh oh!

emyfops left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants