Uh oh!
There was an error while loading. Please reload this page.
Fix: CollectionSettings mapping stringified values instead of converting the collection to a tree - #204
Merged
Merged
Conversation
emyfops
commented
Dec 21, 2025
ContributorAuthor
closes #203 |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modifies slightly comparable collection settings by converting the entire tree directly instead of mapping the collection values to their stringified representations. Collection setting of comparable types was removed and a new flag was introduce to chose the setting core before creating the setting. This pull request also fixes the friend list being serialized using the class collection setting core.