Uh oh!
There was an error while loading. Please reload this page.
Ref: Mixin cleanup - #228
Conversation
0-x-2-2
commented
Jan 27, 2026
I don't know why you would use this over |
0-x-2-2
left a comment
There was a problem hiding this comment.
Most of these are wrong, and you shouldn't replace some of these. @Inject is perfectly safe and likely what you want most of the time.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
0-x-2-2
commented
Jan 27, 2026
Most of this is just abusing the feature. |
0-x-2-2
commented
Jan 27, 2026
But many of the old injections were also wrong and should have been using some other feature from mixinextras. |
emyfops
commented
Jan 27, 2026
I mistakenly took an error from last year and attributed to |
This reverts commit 4d0eac6.
emyfops
commented
Jan 27, 2026
I've tested for potential breaking changes and they're all good |
Due to the nature ofInject, they can cause mixin conflicts with mods that aren't up to date or don't use mixinextra features. This pull request replaces most injections by wrapping operationsThis pull request needs extensive testing as it may break current features and introduce logic bugsThis pull request cleans up the mixins and replaces some mixins with less intrusive ones