Uh oh!
There was an error while loading. Please reload this page.
add Pause When Eating to Breaking and Interact. Packet mine still progresses while your eatting but wont actually finish to your done eatting.This is because you cant eat when placing and and stuff. - #309
Open
chinesedog99 wants to merge 1 commit into
Open
Conversation
…gresses while your eatting but wont actually finish to your done eatting.This is because you cant eat when placing and and stuff.
chinesedog99
commented
Jul 4, 2026
Author
Sorry about my spelling im like half asleep 😭 |
beanbag44
self-requested a review
July 5, 2026 12:40
beanbag44
requested changes
Jul 5, 2026
Uh oh!
There was an error while loading. Please reload this page.
| val blockState = blockState(ctx.blockPos) | ||
| val progress = blockState.calcBreakDelta(ctx.blockPos) | ||
| val instantBreakable = progress >= info.getBreakThreshold() | ||
| val instantBreakable = progress >= info.getBreakThreshold() && !(breakConfig.pauseWhenEating && player.isEating) |
Member
There was a problem hiding this comment.
i'd probably move the check from here to just before startBreaking is actually called. This would also catch rebreaks too, and we dont need to start instant breakable blocks before they should be broken as they break in one tick anyway
beanbag44
commented
Jul 5, 2026
Member
nah ur good lol. I think this would be better as a general build config setting as i'd imagine if someone wants to pause breaking when eating, they'd also want to pause other interactions like placing too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.