Skip to content

[1.20.x] [All] Support major versions - #33

Merged
emyfops merged 3 commits into
masterfrom
all-modloaders-support-major-version
Jul 10, 2024
Merged

[1.20.x] [All] Support major versions#33
emyfops merged 3 commits into
masterfrom
all-modloaders-support-major-version

Conversation

@emyfops

@emyfopsemyfops commented Jul 8, 2024

Copy link
Copy Markdown
Contributor

This pull request modifies the mod's file dependency to be in range of the major version of minecraft since modloaders assure compatibility for all major versions

However, thedarkcolour/KotlinForForge could cause issues due to inconsistent version releasing and compatibility

@github-actionsgithub-actionsBot added 1.20 triage Requires labelling or review labels Jul 8, 2024
@emyfopsemyfops removed the triage Requires labelling or review label Jul 8, 2024
@emyfops

emyfops commented Jul 8, 2024

Copy link
Copy Markdown
ContributorAuthor

We could drop the use of the library for forge-like and simply transform the entrypoint objects into classes so the jvm doesn't panic when it sees a private constructor

@github-actions

github-actionsBot commented Jul 8, 2024•
edited
Loading

Copy link
Copy Markdown

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@emyfops

emyfops commented Jul 10, 2024

Copy link
Copy Markdown
ContributorAuthor

After some tests and investigations kff will not cause us any issues unlike Baritone which has not only a broken maven publish but also only one release per major mc version

@emyfopsemyfops added this to the Open Beta milestone Jul 10, 2024
@emyfops

emyfops commented Jul 10, 2024

Copy link
Copy Markdown
ContributorAuthor

Tests

For some reasons Fabric simply don't boot up, nothing related to the mod but I know it works just fine
I was able to launch the mod using NeoForge on any version but #34 prevented me to actually play

@emyfops
emyfops merged commit 1052a24 into masterJul 10, 2024
@emyfops
emyfops deleted the all-modloaders-support-major-version branch July 10, 2024 21:02
emyfops added a commit that referenced this pull request Jul 10, 2024
@emyfops
Squashed commit of the following:
5aeaa3c
commit 1052a24
Author: Edouard127 <46357922+Edouard127@users.noreply.github.com>
Date: Wed Jul 10 17:02:29 2024 -0400
[1.20.x] Support all major versions (#33)
This pull request modifies the mod's file dependency to be in range of
the major version of minecraft since modloaders assure compatibility for
all major versions
@emyfopsemyfops changed the title [1.20.x] Support all major versions[1.20.x] [All] Support major versionsOct 30, 2024
@github-actionsgithub-actionsBot added the triage Requires labelling or review label Oct 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

triageRequires labelling or review

Projects

None yet

Milestone

Open Beta

Development

Successfully merging this pull request may close these issues.

1 participant

@emyfops