Skip to content

[1.20.4] Ref: Remove NeoForge support - #66

Merged
emyfops merged 2 commits into
masterfrom
remove-neoforge-support
Aug 27, 2024
Merged

[1.20.4] Ref: Remove NeoForge support#66
emyfops merged 2 commits into
masterfrom
remove-neoforge-support

Conversation

@emyfops

@emyfopsemyfops commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

After thoroughly debugging reflections issues in NeoForge, the maintainer Orion confirmed that the uri scheme is incompatible with org.reflections.
There are no way to have platform independent reflections utils if we have NeoForge in our project.

Closes#37, closes#38

@github-actionsgithub-actionsBot added the triage Requires labelling or review label Aug 26, 2024

@AvanatikerAvanatiker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your research!

@AvanatikerAvanatiker changed the title Remove NeoForge support[1.20.x] [NeoForge]: Remove NeoForge supportAug 27, 2024
@emyfops
emyfops merged commit 1e9755c into masterAug 27, 2024
@emyfops
emyfops deleted the remove-neoforge-support branch August 27, 2024 00:20
@emyfopsemyfops changed the title [1.20.x] [NeoForge]: Remove NeoForge support[1.20.4] [NeoForge]: Remove NeoForge supportJan 8, 2025
@emyfopsemyfops added 1.20 refactor and removed triage Requires labelling or review labels Jan 8, 2025
@emyfopsemyfops changed the title [1.20.4] [NeoForge]: Remove NeoForge support[1.20.4] Ref: Remove NeoForge supportJan 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.20.x] [NeoForge] Commands not registered [1.20.x] [NeoForge] Reflections fails to resolve VFSs

2 participants

@emyfops@Avanatiker