Uh oh!
There was an error while loading. Please reload this page.
[1.20.4] Feat: New gui, texture api and buffer api#98
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Copyright 2025 Lambda | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
| package com.lambda.mixin.render; | ||
| import com.lambda.module.modules.client.LambdaMoji; | ||
| import net.minecraft.client.font.TextRenderer; | ||
| import net.minecraft.client.gui.DrawContext; | ||
| import net.minecraft.client.gui.hud.ChatHud; | ||
| import net.minecraft.text.OrderedText; | ||
| import org.spongepowered.asm.mixin.Mixin; | ||
| import org.spongepowered.asm.mixin.injection.At; | ||
| import org.spongepowered.asm.mixin.injection.Redirect; | ||
| @Mixin(ChatHud.class) | ||
| public class ChatHudMixin { | ||
| @Redirect(method = "render", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/DrawContext;drawTextWithShadow(Lnet/minecraft/client/font/TextRenderer;Lnet/minecraft/text/OrderedText;III)I")) | ||
| int redirectRenderCall(DrawContext instance, TextRenderer textRenderer, OrderedText text, int x, int y, int color) { | ||
| return instance.drawTextWithShadow(textRenderer, LambdaMoji.INSTANCE.parse(text, x, y, color), 0, y, 16777215 + (color << 24)); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,64 @@ | ||||||||||||||||||||||
| /* | ||||||||||||||||||||||
| * Copyright 2025 Lambda | ||||||||||||||||||||||
| * | ||||||||||||||||||||||
| * This program is free software: you can redistribute it and/or modify | ||||||||||||||||||||||
| * it under the terms of the GNU General Public License as published by | ||||||||||||||||||||||
| * the Free Software Foundation, either version 3 of the License, or | ||||||||||||||||||||||
| * (at your option) any later version. | ||||||||||||||||||||||
| * | ||||||||||||||||||||||
| * This program is distributed in the hope that it will be useful, | ||||||||||||||||||||||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||||||||||||||||||||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||||||||||||||||||||||
| * GNU General Public License for more details. | ||||||||||||||||||||||
| * | ||||||||||||||||||||||
| * You should have received a copy of the GNU General Public License | ||||||||||||||||||||||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||||||||||||||||||||||
| */ | ||||||||||||||||||||||
| package com.lambda.mixin.render; | ||||||||||||||||||||||
| import com.lambda.Lambda; | ||||||||||||||||||||||
| import com.lambda.module.modules.render.MapPreview; | ||||||||||||||||||||||
| import net.minecraft.client.MinecraftClient; | ||||||||||||||||||||||
| import net.minecraft.client.font.TextRenderer; | ||||||||||||||||||||||
| import net.minecraft.client.gui.DrawContext; | ||||||||||||||||||||||
| import net.minecraft.client.gui.screen.Screen; | ||||||||||||||||||||||
| import net.minecraft.client.gui.screen.ingame.HandledScreen; | ||||||||||||||||||||||
| import net.minecraft.client.gui.tooltip.HoveredTooltipPositioner; | ||||||||||||||||||||||
| import net.minecraft.client.gui.tooltip.TooltipBackgroundRenderer; | ||||||||||||||||||||||
| import net.minecraft.client.gui.tooltip.TooltipComponent; | ||||||||||||||||||||||
| import net.minecraft.client.gui.tooltip.TooltipPositioner; | ||||||||||||||||||||||
| import net.minecraft.client.item.TooltipData; | ||||||||||||||||||||||
| import net.minecraft.item.ItemStack; | ||||||||||||||||||||||
| import net.minecraft.item.Items; | ||||||||||||||||||||||
| import net.minecraft.text.Text; | ||||||||||||||||||||||
| import org.spongepowered.asm.mixin.Final; | ||||||||||||||||||||||
| import org.spongepowered.asm.mixin.Mixin; | ||||||||||||||||||||||
| import org.spongepowered.asm.mixin.Shadow; | ||||||||||||||||||||||
| import org.spongepowered.asm.mixin.injection.At; | ||||||||||||||||||||||
| import org.spongepowered.asm.mixin.injection.Inject; | ||||||||||||||||||||||
| import org.spongepowered.asm.mixin.injection.callback.CallbackInfo; | ||||||||||||||||||||||
| import java.util.List; | ||||||||||||||||||||||
| import java.util.Optional; | ||||||||||||||||||||||
| import java.util.stream.Collectors; | ||||||||||||||||||||||
| @Mixin(DrawContext.class) | ||||||||||||||||||||||
| public abstract class DrawContextMixin { | ||||||||||||||||||||||
| @Shadow protected abstract void drawTooltip(TextRenderer textRenderer, List<TooltipComponent> components, int x, int y, TooltipPositioner positioner); | ||||||||||||||||||||||
| @Inject(method = "drawTooltip(Lnet/minecraft/client/font/TextRenderer;Ljava/util/List;Ljava/util/Optional;II)V", at = @At("HEAD"), cancellable = true) | ||||||||||||||||||||||
| void drawItemTooltip(TextRenderer textRenderer, List<Text> text, Optional<TooltipData> data, int x, int y, CallbackInfo ci) { | ||||||||||||||||||||||
| List<TooltipComponent> list = text.stream().map(Text::asOrderedText).map(TooltipComponent::of).collect(Collectors.toList()); | ||||||||||||||||||||||
| data.ifPresent(datax -> list.add(1, TooltipComponent.of(datax))); | ||||||||||||||||||||||
| var screen = (HandledScreen) Lambda.getMc().currentScreen; | ||||||||||||||||||||||
| if (screen.focusedSlot != null) { | ||||||||||||||||||||||
| var stack = screen.focusedSlot.getStack(); | ||||||||||||||||||||||
| if (stack.isOf(Items.FILLED_MAP)) list.add(1, new MapPreview.MapComponent(stack)); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
Comment on lines
+55
to
+59
There was a problem hiding this comment. Add null check before casting screen. The current implementation assumes the current screen is always a HandledScreen, which could lead to ClassCastException. - var screen = (HandledScreen) Lambda.getMc().currentScreen;- if (screen.focusedSlot != null) {+ Screen currentScreen = Lambda.getMc().currentScreen;+ if (currentScreen instanceof HandledScreen screen && screen.focusedSlot != null) {
var stack = screen.focusedSlot.getStack();
if (stack.isOf(Items.FILLED_MAP)) list.add(1, new MapPreview.MapComponent(stack));
}📝 Committable suggestion
Suggested change
| ||||||||||||||||||||||
| drawTooltip(textRenderer, list, x, y, HoveredTooltipPositioner.INSTANCE); | ||||||||||||||||||||||
| ci.cancel(); | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
| } | ||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add safeguards for async suggestion handling.
The current implementation has a potential race condition where pendingSuggestions might be modified between the check and usage.
📝 Committable suggestion