Uh oh!
There was an error while loading. Please reload this page.
Add tests borrowed from Hiccup's test suite and make small tweaks to match Hiccup/Reagent behavior. - #4
Open
alysbrooks wants to merge 8 commits into
Open
Add tests borrowed from Hiccup's test suite and make small tweaks to match Hiccup/Reagent behavior.#4alysbrooks wants to merge 8 commits into
alysbrooks wants to merge 8 commits into
Conversation
alysbrooks
marked this pull request as draft
March 20, 2023 16:47
alysbrooks
commented
May 26, 2023
MemberAuthor
Based on looking into it further, MPL and EPL are very similar and as far as I can tell, can be combined freely. |
alysbrooks
commented
May 26, 2023
MemberAuthor
Latest version of Reagent's test suite: https://github.com/reagent-project/reagent/blob/master/src/reagent/impl/template.cljs. While I'm just integrating Hiccup tests for now, I'm trying to avoid introducing any incompatibilities. |
alysbrooksforce-pushed
the
alys/borrow-tests
branch
from
May 26, 2023 20:54
1cb4232 to
2dc4b3eComparealysbrooks
marked this pull request as ready for review
May 26, 2023 20:56
alysbrooks
commented
Jun 13, 2023
MemberAuthor
I think we can merge this after #5. |
alysbrooks
commented
Aug 1, 2023
MemberAuthor
I believe that #7 would have been caught by these tests. |
MemberAuthor
Caught more issues introduced (I'm pretty sure) by #5:
The latter might be due to the interaction between #5 and this PR since I think the fragment test existed prior to this PR. Never mind, that second issue was caused by a typo I introduced during rebase. |
alysbrooksforce-pushed
the
alys/borrow-tests
branch
from
August 1, 2023 04:47
906c6de to
64e47e1Compare
added 8 commits
July 31, 2023 23:49
For example, `['div]` and `["div"] are now allowed. This ensures compatability with the original Hiccup and also Reagent
Document a few discrepancies I've noticed between our libraryy and others.
We throw a different exception than Hiccup does.
This matches the behavior of Reagent and the original Hiccup.
For example, in `[:div#foo {:id "bar"}]`, the id would be bar and not
foo.Our output differs slightly in ways that don't make any semantic difference.
Revise wording and add bullet about `style` attribute.
Remove some issues that were in the original Hiccup tests.
alysbrooksforce-pushed
the
alys/borrow-tests
branch
from
August 1, 2023 04:49
64e47e1 to
c2dd8a5Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, the only divergence that has a semantic difference is our handling of conflicts between attributes in the map and tag. I think we want to follow Reagent's handling, but I don't know what that is yet.