Uh oh!
There was an error while loading. Please reload this page.
Add bfloat16 extension array - #1002
Merged
Merged
Conversation
wjones127force-pushed
the
wjones127/bfloat16
branch
from
July 11, 2023 17:39
4b74569 to
5e8e8f1Comparewjones127force-pushed
the
wjones127/bfloat16
branch
from
July 12, 2023 21:44
14cc4ea to
7e5966dComparewjones127
marked this pull request as ready for review
July 12, 2023 22:10
eddyxu
reviewed
Jul 14, 2023
| from ml_dtypes import bfloat16 | ||
| from lance.arrow import PandasBFloat16Array, BFloat16Array | ||
| np_array = np.array([1.1, 2.1, 3.4], dtype=bfloat16) |
Member
There was a problem hiding this comment.
Could you make sure that it works with tensorflow bf16?
ContributorAuthor
There was a problem hiding this comment.
tensorflow converts to numpy with the ml_dtypes.bfloat16, so I think we are good here 👍
wjones127force-pushed
the
wjones127/bfloat16
branch
2 times, most recently
from
July 14, 2023 21:43
ff466a2 to
ba01bb7Comparewjones127force-pushed
the
wjones127/bfloat16
branch
from
July 14, 2023 21:47
ba01bb7 to
521fc09Compareeddyxu
approved these changes
Jul 14, 2023
eddyxu
left a comment
Member
There was a problem hiding this comment.
LGTM.
please make sure every file has a license header.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#994