Uh oh!
There was an error while loading. Please reload this page.
feat: add client sdk review - #1
Closed
MaxMoskalenko wants to merge 1 commit into
Closed
Conversation
MaxMoskalenko
commented
Apr 1, 2025
ContributorAuthor
philanton added a commit
that referenced
this pull request
May 27, 2026
- build-node-project.yml: drop the `bootstrap-build-script` input. The bootstrap project is always built with `npm run build:ci`, which removes the caller-controlled string interpolation into `run:` and closes the template-injection vector flagged by zizmor. - Helm `playground.component.image`: wrap `.tag` in `required` so an empty `image.tag` fails at template time with a clear error instead of producing a broken `repo:` reference that would only surface as ImagePullBackOff at pod startup. - HTTPRoute `backendRefs[].port`: default off `externalPort` to match `service.yaml`'s `ports[].port`, so the route still resolves when external/internal ports diverge. - Dockerfile: switch the runtime stage to `nginxinc/nginx-unprivileged` and run as the `nginx` UID (101). The variant already listens on 8080 and keeps its pid file under /tmp, so no extra chown of /var/run is needed; we only chown the html tree, env.js template, and `/docker-entrypoint.d` so the entrypoint can render env.js as the non-root user. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
philanton added a commit
that referenced
this pull request
May 27, 2026
- build-node-project.yml: drop the `bootstrap-build-script` input. The bootstrap project is always built with `npm run build:ci`, which removes the caller-controlled string interpolation into `run:` and closes the template-injection vector flagged by zizmor. - Helm `playground.component.image`: wrap `.tag` in `required` so an empty `image.tag` fails at template time with a clear error instead of producing a broken `repo:` reference that would only surface as ImagePullBackOff at pod startup. - HTTPRoute `backendRefs[].port`: default off `externalPort` to match `service.yaml`'s `ports[].port`, so the route still resolves when external/internal ports diverge. - Dockerfile: switch the runtime stage to `nginxinc/nginx-unprivileged` and run as the `nginx` UID (101). The variant already listens on 8080 and keeps its pid file under /tmp, so no extra chown of /var/run is needed; we only chown the html tree, env.js template, and `/docker-entrypoint.d` so the entrypoint can render env.js as the non-root user. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.