Uh oh!
There was an error while loading. Please reload this page.
Support field in dataclass member initialization - #2280
Merged
ubaidsk merged 2 commits intoAug 17, 2023
Conversation
ubaidsk
marked this pull request as draft
August 16, 2023 23:38
ubaidskforce-pushed
the
support_field_in_dataclass_mem_init
branch
from
August 16, 2023 23:40
4a10c8b to
9bdb90eCompareubaidsk
marked this pull request as ready for review
August 16, 2023 23:45
certik
approved these changes
Aug 17, 2023
| b: bool = True | ||
| c: list[i32] = field(default_factory=lambda: [1, 2, 3]) | ||
| d: i32[3] = field(default_factory=lambda: array([4, 5, 6])) | ||
| e: i32 = field(default=-5) |
Contributor
There was a problem hiding this comment.
Is this the same as:
Suggested change
| e: i32=field(default=-5) | |
| e: i32=-5 |
?
CollaboratorAuthor
There was a problem hiding this comment.
Yes, I think they are equivalent.
Contributor
There was a problem hiding this comment.
If they are equivalent, then I would almost not support the duplicate way of doing it ("just one way of doing things").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards #2276