Uh oh!
There was an error while loading. Please reload this page.
Remove dataclass emulation - #2285
Merged
Merged
Conversation
ubaidsk
marked this pull request as draft
August 19, 2023 14:13
ubaidskforce-pushed
the
remove_dataclass_emulation
branch
from
August 19, 2023 14:29
7377ff9 to
ba6507dCompareCollaboratorAuthor
I think this PR would hopefully pass after rebasing on top of #2284. PS: Reference tests might need to be updated. I will complete it after the rebase. |
certikforce-pushed
the
remove_dataclass_emulation
branch
from
August 19, 2023 19:12
ba6507d to
0017058Comparecertik
reviewed
Aug 19, 2023
| arg.__class_getitem__ = __class_getitem__ | ||
| return py_dataclass(arg) | ||
Contributor
There was a problem hiding this comment.
Beautiful! That's exactly what we need.
ubaidskforce-pushed
the
remove_dataclass_emulation
branch
from
August 19, 2023 19:37
0017058 to
8759288Compareubaidsk
marked this pull request as ready for review
August 19, 2023 19:41
certik
approved these changes
Aug 19, 2023
certik
left a comment
Contributor
There was a problem hiding this comment.
I think this works! Thanks, great job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards #2276, #2274