Uh oh!
There was an error while loading. Please reload this page.
Fix symbolic pass for handling IntrinsicElementalFunction in print() - #2665
Merged
ubaidsk merged 8 commits intoApr 27, 2024
Conversation
kmr-srbh
commented
Apr 25, 2024
ContributorAuthor
@Shaikh-Ubaid could you please suggest some more testcases? |
ubaidsk
reviewed
Apr 25, 2024
Uh oh!
There was an error while loading. Please reload this page.
ubaidsk
commented
Apr 25, 2024
Collaborator
fromlpythonimporti32deff():
a :list[i32]= [1, 2, 3, 4,]
print(a.pop(),a)
f()Can you add this exact test case? |
ubaidsk
marked this pull request as draft
April 25, 2024 20:05
ubaidsk
reviewed
Apr 26, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ubaidsk
commented
Apr 26, 2024
Collaborator
Please mark as "Ready for review" when ready. |
kmr-srbh
marked this pull request as ready for review
April 26, 2024 14:01
kmr-srbh
commented
Apr 26, 2024
ContributorAuthor
@Shaikh-Ubaid could you please look into the reason for the failing checks? They seem unrelated to the PR. |
kmr-srbhforce-pushed
the
fix-symblic-pass-for-printing-intrinsic-elemental-function
branch
from
April 27, 2024 05:07
658e561 to
e38ee36Compareubaidsk
marked this pull request as draft
April 27, 2024 07:01
kmr-srbh
marked this pull request as ready for review
April 27, 2024 08:30
ubaidsk
approved these changes
Apr 27, 2024
ubaidsk
left a comment
Collaborator
There was a problem hiding this comment.
Perfect! Thanks. It looks great!
ubaidskforce-pushed
the
fix-symblic-pass-for-printing-intrinsic-elemental-function
branch
from
April 27, 2024 09:00
d322154 to
1e15742Compareubaidsk
enabled auto-merge (squash)
April 27, 2024 09:00
assem2002 pushed a commit
to assem2002/lpython
that referenced
this pull request
Apr 28, 2024
…()` (lcompilers#2665) * Fix symbolic pass for handling `IntrinsicElementalFunction` in `print()` * Tests: Add tests and update references * Fix mistakenly commented out lines * Tests: Add testcase and update references * Tests: Update references * Style changes * Remove C backend * Tests: Add asserts and update test reference
assem2002 pushed a commit
to assem2002/lpython
that referenced
this pull request
Apr 28, 2024
…()` (lcompilers#2665) * Fix symbolic pass for handling `IntrinsicElementalFunction` in `print()` * Tests: Add tests and update references * Fix mistakenly commented out lines * Tests: Add testcase and update references * Tests: Update references * Style changes * Remove C backend * Tests: Add asserts and update test reference
kmr-srbh
deleted the
fix-symblic-pass-for-printing-intrinsic-elemental-function
branch
May 2, 2024 13:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#2457