Skip to content

Pmd features sql - #588

Open
PZahnen wants to merge 2 commits into
masterfrom
pmd-features-sql
Open

Pmd features sql#588
PZahnen wants to merge 2 commits into
masterfrom
pmd-features-sql

Conversation

@PZahnen

@PZahnenPZahnen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

105 TODOs left:

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:157
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:223
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureCreatorValues.java:72
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:115
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:141
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:233
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:269
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:359
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:373
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:484
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:120
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:163
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:164
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:170
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureProviderSqlFactory.java:85
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:63
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:69
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:266
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:550
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:580
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:701
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:783
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1545
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1676
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1752
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1759
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2578
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2627
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2709
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2836
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2852
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/JoinGenerator.java:251
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:78
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:109
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:111
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:152
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:92
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:99
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:46
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:139
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:17
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:37
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:59
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:64
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:86
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:92
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:131
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:138
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:168
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:183
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:184
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:198
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:76
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:86
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:107
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:112
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:264
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:274
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:277
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:299
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:300
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:316
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:320
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlMultiplicityTracker.java:38
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:779
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:807
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:841
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:863
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:891
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1210
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1447
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:100
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:212
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureTokenStatsCollector.java:43
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaMappingSql.java:35
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaSql.java:153
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:170
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:462
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:66
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:89
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:38
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:57
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:111
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:194
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:265
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:654
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQueryOptions.java:133
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:64
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:124
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaGeneratorSql.java:350
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:47
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:48
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SourceSchemaValidatorSql.java:206
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:119
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:131
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:286
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:322
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:109
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:439
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:494
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:36
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:168
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:181
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:293
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/package-info.java:9

@PZahnen
PZahnen requested a review from azahnenJuly 28, 2026 13:01
github-actions[bot]
github-actionsBot reviewed Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
String.format(
"%s.%s", parentRelation.get().getName(), parentRelation.get().getSourceField()));
columns2.add(0, parentRelation.get().getTargetField());
// TODO: is this merged?

@github-actionsgithub-actionsBotJul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO: is this merged?

github-actions[bot]
github-actionsBot reviewed Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
&& schema.isOne2One()
&& Objects.equals(
parentRelation.get().getSortKey(), parentRelation.get().getSourceField())) {
// TODO fullPath, sortKey

@github-actionsgithub-actionsBotJul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO fullPath, sortKey

github-actions[bot]
github-actionsBot reviewed Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
String idKey = String.format("%s.%s", table, joins.get(0).getSortKey()); // TODO: primary key
String idKey =
String.format(
FORMAT_QUALIFIED_COLUMN, table, joins.get(0).getSortKey()); // TODO: primary key

@github-actionsgithub-actionsBotJul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO: primary key

github-actions[bot]
github-actionsBot reviewed Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java

private final SqlPathDefaults defaults;
private final Cql cql;
// TODO: remove

@github-actionsgithub-actionsBotJul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO: remove

github-actions[bot]
github-actionsBot reviewed Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java
String.format("invalid sourcePath '%s', expected column", path));
String flags = Optional.ofNullable(matcher.group(MatcherGroups.FLAGS.name())).orElse("");

// TODO

@github-actionsgithub-actionsBotJul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.
TODO

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@azahnenazahnenAwaiting requested review from azahnenazahnen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PZahnen
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Pmd features sql by PZahnen · Pull Request #588 · ldproxy/xtraplatform-spatial · GitHub
Skip to content
Pmd features sql - #588
Open
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Open
Pmd features sql#588
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Conversation
@PZahnen
@PZahnenPZahnen
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
105 TODOs left:
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:157

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:223

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureCreatorValues.java:72

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:115

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:141

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:233

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:269

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:359

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:373

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:484

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:120

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:163

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:164

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureProviderSqlFactory.java:85

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:63

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:69

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:266

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:550

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:580

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:701

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:783

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1545

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1676

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1752

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1759

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2578

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2627

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2709

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2836

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2852

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/JoinGenerator.java:251

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:78

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:152

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:99

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:46

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:139

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:17

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:37

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:59

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:138

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:183

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:184

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:198

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:76

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:107

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:112

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:264

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:274

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:277

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:299

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:300

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:316

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:320

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlMultiplicityTracker.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:779

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:807

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:841

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:863

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:891

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1210

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1447

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:100

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:212

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureTokenStatsCollector.java:43

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaMappingSql.java:35

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaSql.java:153

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:462

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:66

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:89

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:57

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:194

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:265

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:654

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQueryOptions.java:133

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:124

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaGeneratorSql.java:350

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:47

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:48

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SourceSchemaValidatorSql.java:206

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:119

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:286

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:322

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:439

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:494

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:36

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:181

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:293

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/package-info.java:9
@PZahnen
PZahnen
requested a review
from azahnenJuly 28, 2026 13:01
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String.format(
 "%s.%s", parentRelation.get().getName(), parentRelation.get().getSourceField()));
 columns2.add(0, parentRelation.get().getTargetField());
 // TODO: is this merged?
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: is this merged?
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 && schema.isOne2One()
 && Objects.equals(
 parentRelation.get().getSortKey(), parentRelation.get().getSourceField())) {
 // TODO fullPath, sortKey
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO fullPath, sortKey
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String idKey = String.format("%s.%s", table, joins.get(0).getSortKey()); // TODO: primary key
 String idKey =
 String.format(
 FORMAT_QUALIFIED_COLUMN, table, joins.get(0).getSortKey()); // TODO: primary key
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: primary key
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java

 private final SqlPathDefaults defaults;
 private final Cql cql;
 // TODO: remove
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: remove
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java
 String.format("invalid sourcePath '%s', expected column", path));
 String flags = Optional.ofNullable(matcher.group(MatcherGroups.FLAGS.name())).orElse("");

 // TODO
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@azahnenazahnenAwaiting requested review from azahnenazahnen is a code owner

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@PZahnen

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Pmd features sql by PZahnen · Pull Request #588 · ldproxy/xtraplatform-spatial · GitHub
Skip to content
Pmd features sql - #588
Open
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Open
Pmd features sql#588
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Conversation
@PZahnen
@PZahnenPZahnen
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
105 TODOs left:
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:157

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:223

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureCreatorValues.java:72

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:115

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:141

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:233

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:269

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:359

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:373

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:484

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:120

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:163

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:164

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureProviderSqlFactory.java:85

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:63

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:69

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:266

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:550

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:580

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:701

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:783

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1545

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1676

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1752

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1759

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2578

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2627

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2709

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2836

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2852

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/JoinGenerator.java:251

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:78

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:152

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:99

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:46

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:139

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:17

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:37

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:59

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:138

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:183

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:184

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:198

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:76

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:107

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:112

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:264

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:274

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:277

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:299

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:300

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:316

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:320

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlMultiplicityTracker.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:779

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:807

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:841

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:863

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:891

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1210

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1447

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:100

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:212

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureTokenStatsCollector.java:43

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaMappingSql.java:35

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaSql.java:153

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:462

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:66

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:89

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:57

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:194

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:265

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:654

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQueryOptions.java:133

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:124

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaGeneratorSql.java:350

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:47

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:48

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SourceSchemaValidatorSql.java:206

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:119

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:286

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:322

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:439

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:494

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:36

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:181

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:293

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/package-info.java:9
@PZahnen
PZahnen
requested a review
from azahnenJuly 28, 2026 13:01
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String.format(
 "%s.%s", parentRelation.get().getName(), parentRelation.get().getSourceField()));
 columns2.add(0, parentRelation.get().getTargetField());
 // TODO: is this merged?
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: is this merged?
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 && schema.isOne2One()
 && Objects.equals(
 parentRelation.get().getSortKey(), parentRelation.get().getSourceField())) {
 // TODO fullPath, sortKey
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO fullPath, sortKey
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String idKey = String.format("%s.%s", table, joins.get(0).getSortKey()); // TODO: primary key
 String idKey =
 String.format(
 FORMAT_QUALIFIED_COLUMN, table, joins.get(0).getSortKey()); // TODO: primary key
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: primary key
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java

 private final SqlPathDefaults defaults;
 private final Cql cql;
 // TODO: remove
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: remove
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java
 String.format("invalid sourcePath '%s', expected column", path));
 String flags = Optional.ofNullable(matcher.group(MatcherGroups.FLAGS.name())).orElse("");

 // TODO
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@azahnenazahnenAwaiting requested review from azahnenazahnen is a code owner

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@PZahnen

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Pmd features sql by PZahnen · Pull Request #588 · ldproxy/xtraplatform-spatial · GitHub
Skip to content
Pmd features sql - #588
Open
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Open
Pmd features sql#588
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Conversation
@PZahnen
@PZahnenPZahnen
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
105 TODOs left:
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:157

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:223

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureCreatorValues.java:72

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:115

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:141

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:233

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:269

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:359

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:373

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:484

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:120

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:163

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:164

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureProviderSqlFactory.java:85

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:63

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:69

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:266

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:550

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:580

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:701

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:783

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1545

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1676

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1752

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1759

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2578

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2627

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2709

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2836

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2852

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/JoinGenerator.java:251

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:78

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:152

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:99

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:46

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:139

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:17

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:37

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:59

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:138

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:183

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:184

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:198

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:76

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:107

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:112

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:264

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:274

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:277

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:299

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:300

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:316

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:320

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlMultiplicityTracker.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:779

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:807

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:841

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:863

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:891

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1210

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1447

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:100

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:212

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureTokenStatsCollector.java:43

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaMappingSql.java:35

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaSql.java:153

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:462

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:66

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:89

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:57

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:194

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:265

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:654

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQueryOptions.java:133

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:124

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaGeneratorSql.java:350

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:47

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:48

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SourceSchemaValidatorSql.java:206

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:119

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:286

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:322

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:439

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:494

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:36

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:181

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:293

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/package-info.java:9
@PZahnen
PZahnen
requested a review
from azahnenJuly 28, 2026 13:01
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String.format(
 "%s.%s", parentRelation.get().getName(), parentRelation.get().getSourceField()));
 columns2.add(0, parentRelation.get().getTargetField());
 // TODO: is this merged?
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: is this merged?
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 && schema.isOne2One()
 && Objects.equals(
 parentRelation.get().getSortKey(), parentRelation.get().getSourceField())) {
 // TODO fullPath, sortKey
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO fullPath, sortKey
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String idKey = String.format("%s.%s", table, joins.get(0).getSortKey()); // TODO: primary key
 String idKey =
 String.format(
 FORMAT_QUALIFIED_COLUMN, table, joins.get(0).getSortKey()); // TODO: primary key
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: primary key
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java

 private final SqlPathDefaults defaults;
 private final Cql cql;
 // TODO: remove
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: remove
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java
 String.format("invalid sourcePath '%s', expected column", path));
 String flags = Optional.ofNullable(matcher.group(MatcherGroups.FLAGS.name())).orElse("");

 // TODO
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@azahnenazahnenAwaiting requested review from azahnenazahnen is a code owner

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@PZahnen

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Pmd features sql by PZahnen · Pull Request #588 · ldproxy/xtraplatform-spatial · GitHub
Skip to content
Pmd features sql - #588
Open
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Open
Pmd features sql#588
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Conversation
@PZahnen
@PZahnenPZahnen
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
105 TODOs left:
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:157

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:223

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureCreatorValues.java:72

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:115

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:141

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:233

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:269

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:359

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:373

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:484

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:120

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:163

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:164

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureProviderSqlFactory.java:85

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:63

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:69

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:266

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:550

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:580

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:701

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:783

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1545

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1676

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1752

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1759

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2578

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2627

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2709

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2836

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2852

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/JoinGenerator.java:251

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:78

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:152

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:99

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:46

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:139

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:17

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:37

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:59

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:138

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:183

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:184

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:198

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:76

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:107

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:112

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:264

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:274

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:277

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:299

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:300

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:316

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:320

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlMultiplicityTracker.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:779

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:807

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:841

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:863

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:891

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1210

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1447

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:100

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:212

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureTokenStatsCollector.java:43

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaMappingSql.java:35

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaSql.java:153

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:462

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:66

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:89

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:57

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:194

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:265

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:654

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQueryOptions.java:133

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:124

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaGeneratorSql.java:350

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:47

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:48

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SourceSchemaValidatorSql.java:206

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:119

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:286

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:322

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:439

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:494

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:36

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:181

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:293

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/package-info.java:9
@PZahnen
PZahnen
requested a review
from azahnenJuly 28, 2026 13:01
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String.format(
 "%s.%s", parentRelation.get().getName(), parentRelation.get().getSourceField()));
 columns2.add(0, parentRelation.get().getTargetField());
 // TODO: is this merged?
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: is this merged?
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 && schema.isOne2One()
 && Objects.equals(
 parentRelation.get().getSortKey(), parentRelation.get().getSourceField())) {
 // TODO fullPath, sortKey
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO fullPath, sortKey
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String idKey = String.format("%s.%s", table, joins.get(0).getSortKey()); // TODO: primary key
 String idKey =
 String.format(
 FORMAT_QUALIFIED_COLUMN, table, joins.get(0).getSortKey()); // TODO: primary key
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: primary key
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java

 private final SqlPathDefaults defaults;
 private final Cql cql;
 // TODO: remove
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: remove
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java
 String.format("invalid sourcePath '%s', expected column", path));
 String flags = Optional.ofNullable(matcher.group(MatcherGroups.FLAGS.name())).orElse("");

 // TODO
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@azahnenazahnenAwaiting requested review from azahnenazahnen is a code owner

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@PZahnen

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Pmd features sql by PZahnen · Pull Request #588 · ldproxy/xtraplatform-spatial · GitHub
Skip to content
Pmd features sql - #588
Open
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Open
Pmd features sql#588
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Conversation
@PZahnen
@PZahnenPZahnen
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
105 TODOs left:
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:157

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:223

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureCreatorValues.java:72

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:115

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:141

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:233

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:269

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:359

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:373

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:484

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:120

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:163

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:164

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureProviderSqlFactory.java:85

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:63

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:69

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:266

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:550

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:580

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:701

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:783

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1545

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1676

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1752

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1759

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2578

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2627

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2709

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2836

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2852

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/JoinGenerator.java:251

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:78

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:152

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:99

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:46

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:139

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:17

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:37

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:59

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:138

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:183

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:184

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:198

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:76

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:107

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:112

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:264

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:274

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:277

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:299

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:300

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:316

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:320

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlMultiplicityTracker.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:779

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:807

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:841

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:863

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:891

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1210

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1447

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:100

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:212

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureTokenStatsCollector.java:43

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaMappingSql.java:35

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaSql.java:153

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:462

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:66

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:89

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:57

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:194

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:265

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:654

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQueryOptions.java:133

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:124

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaGeneratorSql.java:350

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:47

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:48

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SourceSchemaValidatorSql.java:206

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:119

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:286

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:322

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:439

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:494

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:36

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:181

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:293

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/package-info.java:9
@PZahnen
PZahnen
requested a review
from azahnenJuly 28, 2026 13:01
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String.format(
 "%s.%s", parentRelation.get().getName(), parentRelation.get().getSourceField()));
 columns2.add(0, parentRelation.get().getTargetField());
 // TODO: is this merged?
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: is this merged?
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 && schema.isOne2One()
 && Objects.equals(
 parentRelation.get().getSortKey(), parentRelation.get().getSourceField())) {
 // TODO fullPath, sortKey
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO fullPath, sortKey
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String idKey = String.format("%s.%s", table, joins.get(0).getSortKey()); // TODO: primary key
 String idKey =
 String.format(
 FORMAT_QUALIFIED_COLUMN, table, joins.get(0).getSortKey()); // TODO: primary key
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: primary key
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java

 private final SqlPathDefaults defaults;
 private final Cql cql;
 // TODO: remove
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: remove
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java
 String.format("invalid sourcePath '%s', expected column", path));
 String flags = Optional.ofNullable(matcher.group(MatcherGroups.FLAGS.name())).orElse("");

 // TODO
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@azahnenazahnenAwaiting requested review from azahnenazahnen is a code owner

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@PZahnen

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Pmd features sql by PZahnen · Pull Request #588 · ldproxy/xtraplatform-spatial · GitHub
Skip to content
Pmd features sql - #588
Open
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Open
Pmd features sql#588
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Conversation
@PZahnen
@PZahnenPZahnen
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
105 TODOs left:
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:157

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:223

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureCreatorValues.java:72

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:115

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:141

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:233

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:269

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:359

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:373

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:484

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:120

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:163

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:164

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureProviderSqlFactory.java:85

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:63

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:69

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:266

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:550

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:580

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:701

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:783

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1545

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1676

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1752

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1759

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2578

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2627

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2709

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2836

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2852

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/JoinGenerator.java:251

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:78

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:152

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:99

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:46

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:139

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:17

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:37

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:59

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:138

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:183

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:184

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:198

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:76

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:107

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:112

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:264

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:274

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:277

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:299

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:300

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:316

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:320

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlMultiplicityTracker.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:779

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:807

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:841

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:863

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:891

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1210

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1447

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:100

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:212

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureTokenStatsCollector.java:43

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaMappingSql.java:35

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaSql.java:153

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:462

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:66

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:89

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:57

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:194

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:265

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:654

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQueryOptions.java:133

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:124

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaGeneratorSql.java:350

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:47

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:48

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SourceSchemaValidatorSql.java:206

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:119

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:286

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:322

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:439

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:494

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:36

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:181

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:293

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/package-info.java:9
@PZahnen
PZahnen
requested a review
from azahnenJuly 28, 2026 13:01
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String.format(
 "%s.%s", parentRelation.get().getName(), parentRelation.get().getSourceField()));
 columns2.add(0, parentRelation.get().getTargetField());
 // TODO: is this merged?
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: is this merged?
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 && schema.isOne2One()
 && Objects.equals(
 parentRelation.get().getSortKey(), parentRelation.get().getSourceField())) {
 // TODO fullPath, sortKey
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO fullPath, sortKey
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String idKey = String.format("%s.%s", table, joins.get(0).getSortKey()); // TODO: primary key
 String idKey =
 String.format(
 FORMAT_QUALIFIED_COLUMN, table, joins.get(0).getSortKey()); // TODO: primary key
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: primary key
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java

 private final SqlPathDefaults defaults;
 private final Cql cql;
 // TODO: remove
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: remove
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java
 String.format("invalid sourcePath '%s', expected column", path));
 String flags = Optional.ofNullable(matcher.group(MatcherGroups.FLAGS.name())).orElse("");

 // TODO
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@azahnenazahnenAwaiting requested review from azahnenazahnen is a code owner

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@PZahnen

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Pmd features sql by PZahnen · Pull Request #588 · ldproxy/xtraplatform-spatial · GitHub
Skip to content
Pmd features sql - #588
Open
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Open
Pmd features sql#588
PZahnen wants to merge 2 commits into
masterfrom 
pmd-features-sql
Conversation
@PZahnen
@PZahnenPZahnen
commented
Jul 28, 2026

Copy link


Copy Markdown

Contributor
105 TODOs left:
xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:157

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/SqlPathSyntax.java:223

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureCreatorValues.java:72

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:115

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:141

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:233

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureDecoderSql.java:269

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:359

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:373

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureEncoderSql.java:484

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:120

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:163

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:164

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureMutationsSql.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureProviderSqlFactory.java:85

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:63

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:69

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FeatureQueryEncoderSql.java:266

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:550

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:580

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:701

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:783

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1545

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1676

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1752

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:1759

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2578

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2627

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2709

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2836

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/FilterEncoderSql.java:2852

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/JoinGenerator.java:251

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:78

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaBuilderSql.java:152

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/MutationSchemaDeriver.java:99

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:46

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/PathParserSql.java:139

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:17

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:37

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:59

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:92

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:138

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:183

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:184

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator.java:198

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:76

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:86

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:107

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:112

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:264

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:274

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:277

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:299

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:300

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:316

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java:320

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlMultiplicityTracker.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:779

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:807

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:841

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:863

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:891

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1210

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSql.java:1447

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:100

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureProviderSqlData.java:212

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/FeatureTokenStatsCollector.java:43

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaMappingSql.java:35

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SchemaSql.java:153

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:170

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlConnector.java:462

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:66

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPath.java:89

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:38

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:57

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:111

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:194

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:265

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java:654

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQueryOptions.java:133

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:64

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlQuerySchema.java:124

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaGeneratorSql.java:350

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:47

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SchemaInfo.java:48

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SourceSchemaValidatorSql.java:206

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:119

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:131

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:286

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlClientRx.java:322

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:109

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:439

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlConnectorRx.java:494

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:36

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:168

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:181

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/infra/db/SqlRowVals.java:293

xtraplatform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/package-info.java:9
@PZahnen
PZahnen
requested a review
from azahnenJuly 28, 2026 13:01
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String.format(
 "%s.%s", parentRelation.get().getName(), parentRelation.get().getSourceField()));
 columns2.add(0, parentRelation.get().getTargetField());
 // TODO: is this merged?
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: is this merged?
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 && schema.isOne2One()
 && Objects.equals(
 parentRelation.get().getSortKey(), parentRelation.get().getSourceField())) {
 // TODO fullPath, sortKey
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO fullPath, sortKey
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...form-features-sql/src/main/java/de/ii/xtraplatform/features/sql/app/SqlInsertGenerator2.java
 String idKey = String.format("%s.%s", table, joins.get(0).getSortKey()); // TODO: primary key
 String idKey =
 String.format(
 FORMAT_QUALIFIED_COLUMN, table, joins.get(0).getSortKey()); // TODO: primary key
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: primary key
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java

 private final SqlPathDefaults defaults;
 private final Cql cql;
 // TODO: remove
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO: remove
github-actions[bot]
github-actionsBot
reviewed
Jul 28, 2026
View reviewed changes
Comment thread...latform-features-sql/src/main/java/de/ii/xtraplatform/features/sql/domain/SqlPathParser.java
 String.format("invalid sourcePath '%s', expected column", path));
 String flags = Optional.ofNullable(matcher.group(MatcherGroups.FLAGS.name())).orElse("");

 // TODO
@github-actionsgithub-actionsBotJul 28, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new Todo was discovered. If it is not a priority right now,consider marking it for later attention.

TODO
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments
@azahnenazahnenAwaiting requested review from azahnenazahnen is a code owner

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@PZahnen