Skip to content

Allow to use code coverage with PHPSpec 5.0. - #38

Closed
shulard wants to merge 4 commits into
leanphp:masterfrom
friends-of-phpspec:upgrade
Closed

Allow to use code coverage with PHPSpec 5.0.#38
shulard wants to merge 4 commits into
leanphp:masterfrom
friends-of-phpspec:upgrade

Conversation

@shulard

Copy link
Copy Markdown

Hello,

I've created this little PR to upgrade the dependencies and allow to use this awesome CodeCoverage wrapper on latest library releases.

This also allow to use the new PCov coverage driver which is lighter : https://github.com/krakjoe/pcov

Allow to use phpunit/php-code-coverage 7.0 and phpspec/phpspec 5.0.
Comment threadsrc/Listener/CodeCoverageListener.php Outdated
@Nyholm

Copy link
Copy Markdown
Contributor

Friendly ping

@drupol

Copy link
Copy Markdown

Ping @ek9 :-)

@drupoldrupol left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely give my 👍 for this.

@drupol

Copy link
Copy Markdown

@Nyholm I tried to ping @ek9 by email but I got an email back, it seems that the email is no more working, and the domain name as well.

The maintainer doesn't have any contribution in the last year (https://github.com/ek9).

Do you think we should fork this ?

@drupol

Copy link
Copy Markdown

Ok guys, I made the fork: https://packagist.org/packages/drupol/phpspec-code-coverage

As soon as we have news from the original maintainer I'll delete my fork.

@drupoldrupol mentioned this pull request Jul 4, 2019
@shulardshulard closed this Jan 10, 2020
@shulard
shulard deleted the upgrade branch January 10, 2020 14:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@shulard@Nyholm@drupol@aur1mas@bartosz-maciaszek@andrzejkupczyk