Uh oh!
There was an error while loading. Please reload this page.
Improve action that manages issue headers - #28
Conversation
0c7e9fa to
d27caa4Compare- Move shared part to a separate file - Trigger on open new issue event - Remove header from templates
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rtibbles
left a comment
There was a problem hiding this comment.
Code changes make sense - a couple of comments related to events.
| on: | ||
| issues: | ||
| types: [opened, labeled, unlabeled] |
There was a problem hiding this comment.
Just to cover some edge cases we can add reopened and transferred to this list.
There was a problem hiding this comment.
Ah yes, thank you. I only added reopened here. I played around with transferred and the way it works is that a receiving repository will run opened event on issues that are transferred into it, so it's covered. However I updated the script to handle better both reopened and transferred issues. Tested successfully.
Uh oh!
There was an error while loading. Please reload this page.
| manage-issue-header: | ||
| runs-on: ubuntu-latest | ||
| if: | | ||
| github.event.action == 'opened' || |
There was a problem hiding this comment.
Would need to add the other event names here too, presumably.
MisRob
commented
Jul 14, 2025
@rtibbles Companion pull requests:
We should merge this one and the five above together. |
MisRob
commented
Jul 14, 2025
@rtibbles I also pushed upgrade of dependencies and caching of node dependencies here. Tested the latest version on |
| - name: Install dependencies | ||
| run: npm install | ||
| run: yarn install --frozen-lockfile |
There was a problem hiding this comment.
This is yarn's version of npm ci - I've recently learned it's recommended approach in workflows. This is also a a reason why I am committing yarn.lock. When I have a while, I will upgrade and improve other community related workflows similarly.
Summary
Improve action that manages issue headers:
I've developed and previewed in my replica of LE's GitHub, and also tested in
test-actions40caf0f.References
Follow-ups for @rtibbles recent feedback.
Reviewer guidance
Please don't merge. After approval, I will open companion PRs in the five repositories, and then we can merge everything together.