Channel details editor tabs don't automatically reflect share mode

[jayoshih]

Summary

When I open the share modal directly, the details tab is underlined by default

Category

Select one: BUG

How to reproduce

1. Before running devserver, run "yarn run devsetup" if you haven't done so already to have test data available.
2. Login as user "a@a.com", password: "a"
3. Open a channel you can edit
4. In the channel editor, click channel options dropdown in upper right corner
5. Select "Share channel"

Expected

• A user arrives on URL that ends with /sharing (instead of using sharing=true URL query parameter)
• "Sharing" tab is underlined

Real-life consequences

• Slightly annoying
• Regarding developers, this will solve part of our routing tech debt and will make any further work on this page easier

[khangmach]

this happens to me as well when choosing to edit channel details. See this gif

[jayoshih]

Probably best to use the router to determine the tab

[MisRob]

Yes, it would be ideal to connect those two tabs to the router in a regular way. It would also be nice to have two separate views for these tabs (if it's not done already) as it fits into our efforts to have a plain routes structure where we have a view for each root route.

[marcellamaki]

Fixed with #2643