Uh oh!
There was an error while loading. Please reload this page.
Admin page updates - #1977
Conversation
jayoshih
commented
Jun 30, 2020
Going to work on adding frontend tests soon |
…into vue-admin # Conflicts: # contentcuration/contentcuration/views/admin.py
jayoshih
commented
Jul 2, 2020
Will open followup PR with tests |
Codecov Report
@@ Coverage Diff @@## develop #1977 +/- ##
===========================================
+ Coverage 79.11% 79.38% +0.26%
===========================================
Files 277 274 -3 Lines 13539 13134 -405 ===========================================
- Hits 10712 10427 -285 + Misses 2827 2707 -120
Continue to review full report at Codecov.
|
| fileSizeInTerabytes: '{n, number, integer} TB', | ||
| }); | ||
| const ONE_B = 1; |
There was a problem hiding this comment.
Was about to comment on the constants.js above:
Maybe we should import these constants into
mixins.js?
There was a problem hiding this comment.
Yep! I moved it to constants so that I can use it under other components (in this case UserStorage)
| PRIVACY: 'privacy_policy', | ||
| }; | ||
| export const policyDates = { | ||
| [policies.PRIVACY]: new Date(2018, 4, 25), |
There was a problem hiding this comment.
Do we have this date stored anywhere else? Is this just based on a git commit?
There was a problem hiding this comment.
We've mostly been hardcoding it in to keep track of the dates each new version was published
| <template #header> | ||
| <span class="notranslate">{{ channel.name }}</span> | ||
| </template> | ||
| <template v-if="adminMode" #tabs> |
There was a problem hiding this comment.
I think eventually it might make sense to break out the 'info' tab into a component and just have an admin specific modal that uses the info component and the sharing component - just the 'adminMode' gave me a lilttle pause, as adding additional mode props to components is often a sign we are trying to make one component do too much work!
There was a problem hiding this comment.
Now that you mention it, I might be able to just use the Details component for its own modal
Description
Admin channel page:
Admin user page:
Issues fixed
Implementation Notes (optional)
Includes changes from #1962 to avoid merge conflicts if possible
Does this introduce any tech-debt items?
Things to fix in channel CRUD follow up:
Things to fix in user CRUD follow up:
Checklist
docslabel been added if this introduces a change that needs to be updated in the user docs?CHANGELOGlabel been added to this pull request? Items with this label will be added to the CHANGELOG at a later timepages,components, andlayoutsdirectories as described in the docs?