Skip to content

Turn ChannelItem cards into real links - #2186

Merged
micahscopes merged 1 commit into
learningequality:developfrom
micahscopes:channel-cards-are-full-on-links-these-days
Sep 3, 2020
Merged

Turn ChannelItem cards into real links#2186
micahscopes merged 1 commit into
learningequality:developfrom
micahscopes:channel-cards-are-full-on-links-these-days

Conversation

@micahscopes

Copy link
Copy Markdown
Contributor

Description

Makes ChannelItem cards into actual links, for accessibility benefits, the ability to open in a new window or tab, etc.

Issue Addressed (if applicable)

Fixes#2156

Steps to Test

  • While logged in, try right-clicking a channel card and opening it in a new tab. Ensure that the tree editor opens.
  • While logged out, try right-clicking a channel card and opening in a new tab. Ensure that the channel details modal opens.

Implementation Notes (optional)

At a high level, how did you implement this?

I used the v-card component's to and href properties. The href property was necessary because the channel tree view is in a different single page application, but in order to navigate to the channel details modal, it's necessary to use the to property.

Does this introduce any tech-debt items?

If we ever consolidate everything into one single page application, we can simplify this a lot.

Checklist

  • Is the code clean and well-commented?
  • Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  • Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  • Are there tests for this change?
  • Are all user-facing strings translated properly (if applicable)?
  • Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Are views organized into pages, components, and layouts directories as described in the docs?
  • Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  • Are there any new interactions that need to be added to the QA Sheet?
  • Are there opportunities for using Google Analytics here (if applicable)?
  • If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  • Are the migrations safe for a large db (if applicable)?

Reviewers

If you are looking to assign a reviewer, here are some options:

  • Jordan jayoshih (full stack)
  • Aron aronasorman (back end, devops)
  • Micah micahscopes (full stack)
  • Kevin kollivier (back end)
  • Ivan ivanistheone (Ricecooker)
  • Richard rtibbles (full stack, Kolibri)
  • Radina @radinamatic (documentation)

@codecov

codecovBot commented Sep 2, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2186 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #2186 +/- ##
===========================================
- Coverage 80.64% 80.63% -0.01% 
===========================================
Files 288 288 Lines 14035 14030 -5 ===========================================
- Hits 11318 11313 -5 
Misses 2717 2717 
Impacted FilesCoverage Δ
...ntcuration/contentcuration/viewsets/contentnode.py82.21% <0.00%> (-0.42%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f20954...716b773. Read the comment docs.

@MisRobMisRob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good, thank you Micah

@MisRob

Copy link
Copy Markdown
Member

If we ever consolidate everything into one single page application, we can simplify this a lot.

Yes, that would be good

@micahscopes
micahscopes merged commit 2f234bf into learningequality:developSep 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

channel cards are not implemented as links

2 participants

@micahscopes@MisRob