') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Use GOOGLE_APPLICATION_CREDENTIALS as the auth mechanism for connecting to sheets by aronasorman · Pull Request #2594 · learningequality/studio · GitHub
Skip to content

Use GOOGLE_APPLICATION_CREDENTIALS as the auth mechanism for connecting to sheets - #2594

Merged
jayoshih merged 3 commits into
learningequality:developfrom
aronasorman:fix-feedback-sheets
Nov 23, 2020
Merged

Use GOOGLE_APPLICATION_CREDENTIALS as the auth mechanism for connecting to sheets#2594
jayoshih merged 3 commits into
learningequality:developfrom
aronasorman:fix-feedback-sheets

Conversation

@aronasorman

@aronasormanaronasorman commented Nov 23, 2020

Copy link
Copy Markdown
Collaborator

Description

We now use google's application default credentials mechanism for authenticating with google sheets. This allows us to be more flexible in terms of how we authenticate in production and local testing.

Local testing can now use the GOOGLE_APPLICATION_CREDENTIALS env var to point to a service account json file, or can use gcloud auth activate-service-account to activate the service account login once and not have to worry about the service account key location.

Aron Asor added 2 commits November 23, 2020 08:26
Aron Asor
upgrade gspread version
279026b
We now use the simpler API
Aron Asor
use gcloud's application default credentials to authenticate to gspread
b6d3846
Makes production creds much simpler to manage
@codecov

codecovBot commented Nov 23, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2594 (bc5c21a) into develop (bb83dce) will increase coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@ Coverage Diff @@## develop #2594 +/- ##
========================================
Coverage 84.65% 84.66% ========================================
Files 296 296 Lines 15011 15007 -4 ========================================
- Hits 12708 12705 -3 + Misses 2303 2302 -1
Impacted FilesCoverage Δ
...tentcuration/contentcuration/utils/google_drive.py24.32% <25.00%> (-4.95%)⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb83dce...bc5c21a. Read the comment docs.

@jayoshih
jayoshih merged commit 847163d into learningequality:developNov 23, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jayoshihjayoshihjayoshih approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aronasorman@jayoshih