Update ‘page_size’ query param when it is updated on the the Administration User/Channel tables

[jonboiser]

Please remove any unused sections

Description

1. Adds a missing line in administration/mixins.js to update the page_size query param when the two-way binded pagination object and it's rowsPerPage field change.
2. Removes rowsPerPage, and totalItems from being added to the URL query paramas, since they are not necessary
3. Removes sortBy and descending query params from URL when they are null

Issue Addressed (if applicable)

Fixes#2362

[micahscopes]

Awesome! I'll take a look.

[jredrejo]

Oh man, this would have saved me some headaches in #2607
what about the ordering param that appears sometimes together or instead of sortBy? Did you do something with it too?

[jonboiser]

@jredrejo When I was testing this, I found that the ordering query param was being added to the URL as a side-effect of sorting the table, but I don't think that is what the table itself is using to determine the sort column. So in this line, I remove it from the URL (but make note that it is tech debt that ordering is coming from somewhere. I just don't know where yet)

https://github.com/learningequality/studio/pull/2617/files#diff-926677bcff46eabb0a5543ccea0ea00a97dca6501133b6e69806a87e2a3b15beR148

[jredrejo]

Code looks fine, tested it with the latest changes in the backend for this page in develop and everything seems to work fine.
I still would like to make that ordering parameter that's duplicating the sortBy parameter but that's not an essential part for this PR.

@jonboiser One last question, by curiosity: are lodash pickBy and omit functions faster than a normal Array.filter, or is it just the code looks more readable from your pov?

[jonboiser]

@jredrejo I'll add the ordering query param back. I removed it just for aesthetics, but if it might be useful to you later on, I don't see any harm in it being there.

One last question, by curiosity: are lodash pickBy and omit functions faster than a normal Array.filter

pickBy and omit can be applied to objects as well as arrays. Often I use it to do remove object keys with falsy values like this:

pickBy({
a: 1,
b: null,
c: undefined
}) === { a: 1 }

I'm not sure if anything this succinct exists for Objects yet.

[jredrejo]

@jredrejo I'll add the ordering query param back. I removed it just for aesthetics, but if it might be useful to you later on, I don't see any harm in it being there.

No, no, just the opposite: I want it to disappear forever!!. It is making the backend code more complex for two reasons:

1. Dealing with two parameters with the same purpose sortBy and ordered
2. Ordered sometimes is "null", others "undefined" without apparent reason 😢