Skip to content

Better error handling in change event handlers - #2624

Merged
rtibbles merged 4 commits into
learningequality:developfrom
rtibbles:error_handling
Dec 4, 2020
Merged

Better error handling in change event handlers#2624
rtibbles merged 4 commits into
learningequality:developfrom
rtibbles:error_handling

Conversation

@rtibbles

@rtibblesrtibbles commented Dec 4, 2020

Copy link
Copy Markdown
Member

Description

  • Adds discrete error handling for non-bulk actions to prevent changes being reported as errored when only one in the batch has
  • This was making IntegrityError: null value in column "created" violates not-null constraint #2621 more apparent, as errors during the creation of a single content node in a batch would then cause the frontend to prompt reinsertion of all the contentnodes
  • Changes from using auto_now_add to using a default, to ensure that null values are not set when Django does an auto upsert
  • Adds modified timestamps during bulk content node updates, adds tests for the same.
  • Catches when tag relationship creation fails due to it already existing and ensures that the operation completes successfully.

Issue Addressed (if applicable)

Steps to Test

  • Copy a lot of items to the clipboard at once
  • Make sure no errors appear
  • Update content nodes
  • Check that the 'last modified' for the channel changes

@rtibblesrtibbles added this to the Vue Refactor milestone Dec 4, 2020
@codecov

codecovBot commented Dec 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2624 (928c49a) into develop (423b912) will decrease coverage by 0.05%.
The diff coverage is 79.26%.

Impacted file tree graph

@@ Coverage Diff @@## develop #2624 +/- ##
===========================================
- Coverage 84.61% 84.55% -0.06% 
===========================================
Files 295 296 +1 Lines 15018 15071 +53 ===========================================
+ Hits 12707 12743 +36 - Misses 2311 2328 +17
Impacted FilesCoverage Δ
contentcuration/contentcuration/settings.py90.47% <ø> (ø)
contentcuration/contentcuration/utils/db_tools.py69.75% <ø> (ø)
contentcuration/contentcuration/utils/publish.py76.94% <0.00%> (ø)
contentcuration/search/viewsets/contentnode.py46.20% <ø> (ø)
contentcuration/contentcuration/viewsets/base.py88.63% <45.00%> (-2.50%)⬇️
...ntcuration/contentcuration/viewsets/contentnode.py83.43% <75.00%> (-0.42%)⬇️
...uration/contentcuration/tests/test_contentnodes.py94.79% <81.81%> (-0.39%)⬇️
...tentcuration/migrations/0124_auto_20201204_1645.py100.00% <100.00%> (ø)
contentcuration/contentcuration/models.py85.61% <100.00%> (ø)
...ation/contentcuration/tests/test_authentication.py100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048cb42...928c49a. Read the comment docs.

jredrejo
jredrejo approved these changes Dec 4, 2020
View reviewed changes

@jredrejojredrejo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles
rtibbles merged commit 1f807dc into learningequality:developDec 4, 2020
@rtibbles
rtibbles deleted the error_handling branch December 4, 2020 21:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jredrejojredrejojredrejo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Vue Refactor

Development

Successfully merging this pull request may close these issues.

IntegrityError: null value in column "created" violates not-null constraint Tag assignment sometimes tries to create duplicate tag entries

2 participants

@rtibbles@jredrejo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Better error handling in change event handlers by rtibbles · Pull Request #2624 · learningequality/studio · GitHub
Skip to content
Better error handling in change event handlers - #2624
Merged
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Dec 4, 2020
Merged
Better error handling in change event handlers#2624
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Conversation
@rtibbles
@rtibblesrtibbles
commented
Dec 4, 2020

Copy link


Copy Markdown

Member
Description
  • Adds discrete error handling for non-bulk actions to prevent changes being reported as errored when only one in the batch has
  • This was making IntegrityError: null value in column "created" violates not-null constraint #2621 more apparent, as errors during the creation of a single content node in a batch would then cause the frontend to prompt reinsertion of all the contentnodes
  • Changes from using auto_now_add to using a default, to ensure that null values are not set when Django does an auto upsert
  • Adds modified timestamps during bulk content node updates, adds tests for the same.
  • Catches when tag relationship creation fails due to it already existing and ensures that the operation completes successfully.
Issue Addressed (if applicable)
Steps to Test
  • Copy a lot of items to the clipboard at once
  • Make sure no errors appear
  • Update content nodes
  • Check that the 'last modified' for the channel changes
@rtibblesrtibbles
added this to the Vue Refactor milestone
Dec 4, 2020
@codecov
codecovBot
commented
Dec 4, 2020

Copy link


Copy Markdown

Codecov Report
Merging #2624 (928c49a) into develop (423b912) will decrease coverage by 0.05%.

The diff coverage is 79.26%.
Impacted file tree graph
@@ Coverage Diff @@## develop #2624 +/- ##
===========================================
- Coverage 84.61% 84.55% -0.06% 
===========================================
Files 295 296 +1 Lines 15018 15071 +53 ===========================================
+ Hits 12707 12743 +36 - Misses 2311 2328 +17 
Impacted FilesCoverage Δ
contentcuration/contentcuration/settings.py90.47% <ø> (ø)
contentcuration/contentcuration/utils/db_tools.py69.75% <ø> (ø)
contentcuration/contentcuration/utils/publish.py76.94% <0.00%> (ø)
contentcuration/search/viewsets/contentnode.py46.20% <ø> (ø)
contentcuration/contentcuration/viewsets/base.py88.63% <45.00%> (-2.50%)⬇️
...ntcuration/contentcuration/viewsets/contentnode.py83.43% <75.00%> (-0.42%)⬇️
...uration/contentcuration/tests/test_contentnodes.py94.79% <81.81%> (-0.39%)⬇️
...tentcuration/migrations/0124_auto_20201204_1645.py100.00% <100.00%> (ø)
contentcuration/contentcuration/models.py85.61% <100.00%> (ø)
...ation/contentcuration/tests/test_authentication.py100.00% <100.00%> (ø)
... and 11 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 048cb42...928c49a. Read the comment docs.
jredrejo
jredrejo
approved these changes
Dec 4, 2020
View reviewed changes
@jredrejojredrejo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@rtibbles
rtibbles
merged commit 1f807dc
into
learningequality:developDec 4, 2020
@rtibbles
rtibbles
deleted the

error_handling

branch
December 4, 2020 21:02
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jredrejojredrejojredrejo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

Vue Refactor

Development

Successfully merging this pull request may close these issues.

IntegrityError: null value in column "created" violates not-null constraint

Tag assignment sometimes tries to create duplicate tag entries


2 participants

@rtibbles@jredrejo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Better error handling in change event handlers by rtibbles · Pull Request #2624 · learningequality/studio · GitHub
Skip to content
Better error handling in change event handlers - #2624
Merged
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Dec 4, 2020
Merged
Better error handling in change event handlers#2624
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Conversation
@rtibbles
@rtibblesrtibbles
commented
Dec 4, 2020

Copy link


Copy Markdown

Member
Description
  • Adds discrete error handling for non-bulk actions to prevent changes being reported as errored when only one in the batch has
  • This was making IntegrityError: null value in column "created" violates not-null constraint #2621 more apparent, as errors during the creation of a single content node in a batch would then cause the frontend to prompt reinsertion of all the contentnodes
  • Changes from using auto_now_add to using a default, to ensure that null values are not set when Django does an auto upsert
  • Adds modified timestamps during bulk content node updates, adds tests for the same.
  • Catches when tag relationship creation fails due to it already existing and ensures that the operation completes successfully.
Issue Addressed (if applicable)
Steps to Test
  • Copy a lot of items to the clipboard at once
  • Make sure no errors appear
  • Update content nodes
  • Check that the 'last modified' for the channel changes
@rtibblesrtibbles
added this to the Vue Refactor milestone
Dec 4, 2020
@codecov
codecovBot
commented
Dec 4, 2020

Copy link


Copy Markdown

Codecov Report
Merging #2624 (928c49a) into develop (423b912) will decrease coverage by 0.05%.

The diff coverage is 79.26%.
Impacted file tree graph
@@ Coverage Diff @@## develop #2624 +/- ##
===========================================
- Coverage 84.61% 84.55% -0.06% 
===========================================
Files 295 296 +1 Lines 15018 15071 +53 ===========================================
+ Hits 12707 12743 +36 - Misses 2311 2328 +17 
Impacted FilesCoverage Δ
contentcuration/contentcuration/settings.py90.47% <ø> (ø)
contentcuration/contentcuration/utils/db_tools.py69.75% <ø> (ø)
contentcuration/contentcuration/utils/publish.py76.94% <0.00%> (ø)
contentcuration/search/viewsets/contentnode.py46.20% <ø> (ø)
contentcuration/contentcuration/viewsets/base.py88.63% <45.00%> (-2.50%)⬇️
...ntcuration/contentcuration/viewsets/contentnode.py83.43% <75.00%> (-0.42%)⬇️
...uration/contentcuration/tests/test_contentnodes.py94.79% <81.81%> (-0.39%)⬇️
...tentcuration/migrations/0124_auto_20201204_1645.py100.00% <100.00%> (ø)
contentcuration/contentcuration/models.py85.61% <100.00%> (ø)
...ation/contentcuration/tests/test_authentication.py100.00% <100.00%> (ø)
... and 11 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 048cb42...928c49a. Read the comment docs.
jredrejo
jredrejo
approved these changes
Dec 4, 2020
View reviewed changes
@jredrejojredrejo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@rtibbles
rtibbles
merged commit 1f807dc
into
learningequality:developDec 4, 2020
@rtibbles
rtibbles
deleted the

error_handling

branch
December 4, 2020 21:02
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jredrejojredrejojredrejo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

Vue Refactor

Development

Successfully merging this pull request may close these issues.

IntegrityError: null value in column "created" violates not-null constraint

Tag assignment sometimes tries to create duplicate tag entries


2 participants

@rtibbles@jredrejo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Better error handling in change event handlers by rtibbles · Pull Request #2624 · learningequality/studio · GitHub
Skip to content
Better error handling in change event handlers - #2624
Merged
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Dec 4, 2020
Merged
Better error handling in change event handlers#2624
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Conversation
@rtibbles
@rtibblesrtibbles
commented
Dec 4, 2020

Copy link


Copy Markdown

Member
Description
  • Adds discrete error handling for non-bulk actions to prevent changes being reported as errored when only one in the batch has
  • This was making IntegrityError: null value in column "created" violates not-null constraint #2621 more apparent, as errors during the creation of a single content node in a batch would then cause the frontend to prompt reinsertion of all the contentnodes
  • Changes from using auto_now_add to using a default, to ensure that null values are not set when Django does an auto upsert
  • Adds modified timestamps during bulk content node updates, adds tests for the same.
  • Catches when tag relationship creation fails due to it already existing and ensures that the operation completes successfully.
Issue Addressed (if applicable)
Steps to Test
  • Copy a lot of items to the clipboard at once
  • Make sure no errors appear
  • Update content nodes
  • Check that the 'last modified' for the channel changes
@rtibblesrtibbles
added this to the Vue Refactor milestone
Dec 4, 2020
@codecov
codecovBot
commented
Dec 4, 2020

Copy link


Copy Markdown

Codecov Report
Merging #2624 (928c49a) into develop (423b912) will decrease coverage by 0.05%.

The diff coverage is 79.26%.
Impacted file tree graph
@@ Coverage Diff @@## develop #2624 +/- ##
===========================================
- Coverage 84.61% 84.55% -0.06% 
===========================================
Files 295 296 +1 Lines 15018 15071 +53 ===========================================
+ Hits 12707 12743 +36 - Misses 2311 2328 +17 
Impacted FilesCoverage Δ
contentcuration/contentcuration/settings.py90.47% <ø> (ø)
contentcuration/contentcuration/utils/db_tools.py69.75% <ø> (ø)
contentcuration/contentcuration/utils/publish.py76.94% <0.00%> (ø)
contentcuration/search/viewsets/contentnode.py46.20% <ø> (ø)
contentcuration/contentcuration/viewsets/base.py88.63% <45.00%> (-2.50%)⬇️
...ntcuration/contentcuration/viewsets/contentnode.py83.43% <75.00%> (-0.42%)⬇️
...uration/contentcuration/tests/test_contentnodes.py94.79% <81.81%> (-0.39%)⬇️
...tentcuration/migrations/0124_auto_20201204_1645.py100.00% <100.00%> (ø)
contentcuration/contentcuration/models.py85.61% <100.00%> (ø)
...ation/contentcuration/tests/test_authentication.py100.00% <100.00%> (ø)
... and 11 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 048cb42...928c49a. Read the comment docs.
jredrejo
jredrejo
approved these changes
Dec 4, 2020
View reviewed changes
@jredrejojredrejo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@rtibbles
rtibbles
merged commit 1f807dc
into
learningequality:developDec 4, 2020
@rtibbles
rtibbles
deleted the

error_handling

branch
December 4, 2020 21:02
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jredrejojredrejojredrejo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

Vue Refactor

Development

Successfully merging this pull request may close these issues.

IntegrityError: null value in column "created" violates not-null constraint

Tag assignment sometimes tries to create duplicate tag entries


2 participants

@rtibbles@jredrejo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Better error handling in change event handlers by rtibbles · Pull Request #2624 · learningequality/studio · GitHub
Skip to content
Better error handling in change event handlers - #2624
Merged
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Dec 4, 2020
Merged
Better error handling in change event handlers#2624
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Conversation
@rtibbles
@rtibblesrtibbles
commented
Dec 4, 2020

Copy link


Copy Markdown

Member
Description
  • Adds discrete error handling for non-bulk actions to prevent changes being reported as errored when only one in the batch has
  • This was making IntegrityError: null value in column "created" violates not-null constraint #2621 more apparent, as errors during the creation of a single content node in a batch would then cause the frontend to prompt reinsertion of all the contentnodes
  • Changes from using auto_now_add to using a default, to ensure that null values are not set when Django does an auto upsert
  • Adds modified timestamps during bulk content node updates, adds tests for the same.
  • Catches when tag relationship creation fails due to it already existing and ensures that the operation completes successfully.
Issue Addressed (if applicable)
Steps to Test
  • Copy a lot of items to the clipboard at once
  • Make sure no errors appear
  • Update content nodes
  • Check that the 'last modified' for the channel changes
@rtibblesrtibbles
added this to the Vue Refactor milestone
Dec 4, 2020
@codecov
codecovBot
commented
Dec 4, 2020

Copy link


Copy Markdown

Codecov Report
Merging #2624 (928c49a) into develop (423b912) will decrease coverage by 0.05%.

The diff coverage is 79.26%.
Impacted file tree graph
@@ Coverage Diff @@## develop #2624 +/- ##
===========================================
- Coverage 84.61% 84.55% -0.06% 
===========================================
Files 295 296 +1 Lines 15018 15071 +53 ===========================================
+ Hits 12707 12743 +36 - Misses 2311 2328 +17 
Impacted FilesCoverage Δ
contentcuration/contentcuration/settings.py90.47% <ø> (ø)
contentcuration/contentcuration/utils/db_tools.py69.75% <ø> (ø)
contentcuration/contentcuration/utils/publish.py76.94% <0.00%> (ø)
contentcuration/search/viewsets/contentnode.py46.20% <ø> (ø)
contentcuration/contentcuration/viewsets/base.py88.63% <45.00%> (-2.50%)⬇️
...ntcuration/contentcuration/viewsets/contentnode.py83.43% <75.00%> (-0.42%)⬇️
...uration/contentcuration/tests/test_contentnodes.py94.79% <81.81%> (-0.39%)⬇️
...tentcuration/migrations/0124_auto_20201204_1645.py100.00% <100.00%> (ø)
contentcuration/contentcuration/models.py85.61% <100.00%> (ø)
...ation/contentcuration/tests/test_authentication.py100.00% <100.00%> (ø)
... and 11 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 048cb42...928c49a. Read the comment docs.
jredrejo
jredrejo
approved these changes
Dec 4, 2020
View reviewed changes
@jredrejojredrejo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@rtibbles
rtibbles
merged commit 1f807dc
into
learningequality:developDec 4, 2020
@rtibbles
rtibbles
deleted the

error_handling

branch
December 4, 2020 21:02
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jredrejojredrejojredrejo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

Vue Refactor

Development

Successfully merging this pull request may close these issues.

IntegrityError: null value in column "created" violates not-null constraint

Tag assignment sometimes tries to create duplicate tag entries


2 participants

@rtibbles@jredrejo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Better error handling in change event handlers by rtibbles · Pull Request #2624 · learningequality/studio · GitHub
Skip to content
Better error handling in change event handlers - #2624
Merged
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Dec 4, 2020
Merged
Better error handling in change event handlers#2624
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Conversation
@rtibbles
@rtibblesrtibbles
commented
Dec 4, 2020

Copy link


Copy Markdown

Member
Description
  • Adds discrete error handling for non-bulk actions to prevent changes being reported as errored when only one in the batch has
  • This was making IntegrityError: null value in column "created" violates not-null constraint #2621 more apparent, as errors during the creation of a single content node in a batch would then cause the frontend to prompt reinsertion of all the contentnodes
  • Changes from using auto_now_add to using a default, to ensure that null values are not set when Django does an auto upsert
  • Adds modified timestamps during bulk content node updates, adds tests for the same.
  • Catches when tag relationship creation fails due to it already existing and ensures that the operation completes successfully.
Issue Addressed (if applicable)
Steps to Test
  • Copy a lot of items to the clipboard at once
  • Make sure no errors appear
  • Update content nodes
  • Check that the 'last modified' for the channel changes
@rtibblesrtibbles
added this to the Vue Refactor milestone
Dec 4, 2020
@codecov
codecovBot
commented
Dec 4, 2020

Copy link


Copy Markdown

Codecov Report
Merging #2624 (928c49a) into develop (423b912) will decrease coverage by 0.05%.

The diff coverage is 79.26%.
Impacted file tree graph
@@ Coverage Diff @@## develop #2624 +/- ##
===========================================
- Coverage 84.61% 84.55% -0.06% 
===========================================
Files 295 296 +1 Lines 15018 15071 +53 ===========================================
+ Hits 12707 12743 +36 - Misses 2311 2328 +17 
Impacted FilesCoverage Δ
contentcuration/contentcuration/settings.py90.47% <ø> (ø)
contentcuration/contentcuration/utils/db_tools.py69.75% <ø> (ø)
contentcuration/contentcuration/utils/publish.py76.94% <0.00%> (ø)
contentcuration/search/viewsets/contentnode.py46.20% <ø> (ø)
contentcuration/contentcuration/viewsets/base.py88.63% <45.00%> (-2.50%)⬇️
...ntcuration/contentcuration/viewsets/contentnode.py83.43% <75.00%> (-0.42%)⬇️
...uration/contentcuration/tests/test_contentnodes.py94.79% <81.81%> (-0.39%)⬇️
...tentcuration/migrations/0124_auto_20201204_1645.py100.00% <100.00%> (ø)
contentcuration/contentcuration/models.py85.61% <100.00%> (ø)
...ation/contentcuration/tests/test_authentication.py100.00% <100.00%> (ø)
... and 11 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 048cb42...928c49a. Read the comment docs.
jredrejo
jredrejo
approved these changes
Dec 4, 2020
View reviewed changes
@jredrejojredrejo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@rtibbles
rtibbles
merged commit 1f807dc
into
learningequality:developDec 4, 2020
@rtibbles
rtibbles
deleted the

error_handling

branch
December 4, 2020 21:02
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jredrejojredrejojredrejo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

Vue Refactor

Development

Successfully merging this pull request may close these issues.

IntegrityError: null value in column "created" violates not-null constraint

Tag assignment sometimes tries to create duplicate tag entries


2 participants

@rtibbles@jredrejo

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Better error handling in change event handlers by rtibbles · Pull Request #2624 · learningequality/studio · GitHub
Skip to content
Better error handling in change event handlers - #2624
Merged
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Dec 4, 2020
Merged
Better error handling in change event handlers#2624
rtibbles merged 4 commits into
learningequality:developfrom 
rtibbles:error_handling
Conversation
@rtibbles
@rtibblesrtibbles
commented
Dec 4, 2020

Copy link


Copy Markdown

Member
Description
  • Adds discrete error handling for non-bulk actions to prevent changes being reported as errored when only one in the batch has
  • This was making IntegrityError: null value in column "created" violates not-null constraint #2621 more apparent, as errors during the creation of a single content node in a batch would then cause the frontend to prompt reinsertion of all the contentnodes
  • Changes from using auto_now_add to using a default, to ensure that null values are not set when Django does an auto upsert
  • Adds modified timestamps during bulk content node updates, adds tests for the same.
  • Catches when tag relationship creation fails due to it already existing and ensures that the operation completes successfully.
Issue Addressed (if applicable)
Steps to Test
  • Copy a lot of items to the clipboard at once
  • Make sure no errors appear
  • Update content nodes
  • Check that the 'last modified' for the channel changes
@rtibblesrtibbles
added this to the Vue Refactor milestone
Dec 4, 2020
@codecov
codecovBot
commented
Dec 4, 2020

Copy link


Copy Markdown

Codecov Report
Merging #2624 (928c49a) into develop (423b912) will decrease coverage by 0.05%.

The diff coverage is 79.26%.
Impacted file tree graph
@@ Coverage Diff @@## develop #2624 +/- ##
===========================================
- Coverage 84.61% 84.55% -0.06% 
===========================================
Files 295 296 +1 Lines 15018 15071 +53 ===========================================
+ Hits 12707 12743 +36 - Misses 2311 2328 +17 
Impacted FilesCoverage Δ
contentcuration/contentcuration/settings.py90.47% <ø> (ø)
contentcuration/contentcuration/utils/db_tools.py69.75% <ø> (ø)
contentcuration/contentcuration/utils/publish.py76.94% <0.00%> (ø)
contentcuration/search/viewsets/contentnode.py46.20% <ø> (ø)
contentcuration/contentcuration/viewsets/base.py88.63% <45.00%> (-2.50%)⬇️
...ntcuration/contentcuration/viewsets/contentnode.py83.43% <75.00%> (-0.42%)⬇️
...uration/contentcuration/tests/test_contentnodes.py94.79% <81.81%> (-0.39%)⬇️
...tentcuration/migrations/0124_auto_20201204_1645.py100.00% <100.00%> (ø)
contentcuration/contentcuration/models.py85.61% <100.00%> (ø)
...ation/contentcuration/tests/test_authentication.py100.00% <100.00%> (ø)
... and 11 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 048cb42...928c49a. Read the comment docs.
jredrejo
jredrejo
approved these changes
Dec 4, 2020
View reviewed changes
@jredrejojredrejo
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@rtibbles
rtibbles
merged commit 1f807dc
into
learningequality:developDec 4, 2020
@rtibbles
rtibbles
deleted the

error_handling

branch
December 4, 2020 21:02
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jredrejojredrejojredrejo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone

Vue Refactor

Development

Successfully merging this pull request may close these issues.

IntegrityError: null value in column "created" violates not-null constraint

Tag assignment sometimes tries to create duplicate tag entries


2 participants

@rtibbles@jredrejo