Skip to content

Run sync before publishing a channel - #2759

Merged
rtibbles merged 2 commits into
learningequality:developfrom
MisRob:sync-before-publish
Jan 13, 2021
Merged

Run sync before publishing a channel#2759
rtibbles merged 2 commits into
learningequality:developfrom
MisRob:sync-before-publish

Conversation

@MisRob

@MisRobMisRob commented Jan 13, 2021

Copy link
Copy Markdown
Member

Description

  1. Run sync before publishing a channel to ensure that all updates are included
  2. One follow-up commit to address this comment from a previous sync PR

Issue Addressed (if applicable)

Closes#2536

Steps to Test

  • Increase SYNC_IF_NO_CHANGES_FOR, for example to 20 seconds, so that you can test it comfortably
  • Make a change in a channel that you can edit (add a new topic, exercise)
  • Publish the channel
  • Make sure that /sync request has been triggered before the publish request

Checklist

  • Is the code clean and well-commented?
  • Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  • Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  • Are there tests for this change?
  • Are all user-facing strings translated properly (if applicable)?
  • Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Are views organized into pages, components, and layouts directories as described in the docs?
  • Are users' storage used being recalculated properly on any changes to their main tree files?
  • Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  • Are there any new interactions that need to be added to the QA Sheet?
  • Are there opportunities for using Google Analytics here (if applicable)?
  • If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  • Are the migrations safe for a large db (if applicable)?

@MisRob
Sync before publish
67794dc
@MisRob
Don't sync in beforeunload handler
175824d
Do not risk unfinished call and thus inconsistent
data state.
rtibbles
rtibbles reviewed Jan 13, 2021
View reviewed changes

@rtibblesrtibbles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look right, haven't manually tested yet.

rtibbles
rtibbles approved these changes Jan 13, 2021
View reviewed changes

@rtibblesrtibbles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out!

@rtibbles
rtibbles merged commit c82e609 into learningequality:developJan 13, 2021
@MisRob
MisRob deleted the sync-before-publish branch February 3, 2021 07:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtibblesrtibblesrtibbles approved these changes
@jayoshihjayoshihAwaiting requested review from jayoshih

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Force syncing on publish

2 participants

@MisRob@rtibbles
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Run sync before publishing a channel by MisRob · Pull Request #2759 · learningequality/studio · GitHub
Skip to content
Run sync before publishing a channel - #2759
Merged
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Jan 13, 2021
Merged
Run sync before publishing a channel#2759
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Conversation
@MisRob
@MisRobMisRob
commented
Jan 13, 2021

Copy link


Copy Markdown

Member
Description
  1. Run sync before publishing a channel to ensure that all updates are included
  2. One follow-up commit to address this comment from a previous sync PR
Issue Addressed (if applicable)
Closes#2536
Steps to Test
  • Increase SYNC_IF_NO_CHANGES_FOR, for example to 20 seconds, so that you can test it comfortably
  • Make a change in a channel that you can edit (add a new topic, exercise)
  • Publish the channel
  • Make sure that /sync request has been triggered before the publish request
Checklist
  •  Is the code clean and well-commented?
  •  Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  •  Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  •  Are there tests for this change?
  •  Are all user-facing strings translated properly (if applicable)?
  •  Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  •  Are all UI components LTR and RTL compliant (if applicable)?
  •  Are views organized into pages, components, and layouts directories as described in the docs?
  •  Are users' storage used being recalculated properly on any changes to their main tree files?
  •  Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  •  Are there any new interactions that need to be added to the QA Sheet?
  •  Are there opportunities for using Google Analytics here (if applicable)?
  •  If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  •  Are the migrations safe for a large db (if applicable)?
@MisRob
Sync before publish
67794dc
@MisRob
Don't sync in beforeunload handler
175824d
Do not risk unfinished call and thus inconsistent
data state.
rtibbles
rtibbles
reviewed
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look right, haven't manually tested yet.
rtibbles
rtibbles
approved these changes
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out!
@rtibbles
rtibbles
merged commit c82e609
into
learningequality:developJan 13, 2021
@MisRob
MisRob
deleted the

sync-before-publish

branch
February 3, 2021 07:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rtibblesrtibblesrtibbles approved these changes
@jayoshihjayoshihAwaiting requested review from jayoshih

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Force syncing on publish


2 participants

@MisRob@rtibbles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Run sync before publishing a channel by MisRob · Pull Request #2759 · learningequality/studio · GitHub
Skip to content
Run sync before publishing a channel - #2759
Merged
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Jan 13, 2021
Merged
Run sync before publishing a channel#2759
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Conversation
@MisRob
@MisRobMisRob
commented
Jan 13, 2021

Copy link


Copy Markdown

Member
Description
  1. Run sync before publishing a channel to ensure that all updates are included
  2. One follow-up commit to address this comment from a previous sync PR
Issue Addressed (if applicable)
Closes#2536
Steps to Test
  • Increase SYNC_IF_NO_CHANGES_FOR, for example to 20 seconds, so that you can test it comfortably
  • Make a change in a channel that you can edit (add a new topic, exercise)
  • Publish the channel
  • Make sure that /sync request has been triggered before the publish request
Checklist
  •  Is the code clean and well-commented?
  •  Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  •  Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  •  Are there tests for this change?
  •  Are all user-facing strings translated properly (if applicable)?
  •  Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  •  Are all UI components LTR and RTL compliant (if applicable)?
  •  Are views organized into pages, components, and layouts directories as described in the docs?
  •  Are users' storage used being recalculated properly on any changes to their main tree files?
  •  Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  •  Are there any new interactions that need to be added to the QA Sheet?
  •  Are there opportunities for using Google Analytics here (if applicable)?
  •  If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  •  Are the migrations safe for a large db (if applicable)?
@MisRob
Sync before publish
67794dc
@MisRob
Don't sync in beforeunload handler
175824d
Do not risk unfinished call and thus inconsistent
data state.
rtibbles
rtibbles
reviewed
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look right, haven't manually tested yet.
rtibbles
rtibbles
approved these changes
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out!
@rtibbles
rtibbles
merged commit c82e609
into
learningequality:developJan 13, 2021
@MisRob
MisRob
deleted the

sync-before-publish

branch
February 3, 2021 07:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rtibblesrtibblesrtibbles approved these changes
@jayoshihjayoshihAwaiting requested review from jayoshih

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Force syncing on publish


2 participants

@MisRob@rtibbles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Run sync before publishing a channel by MisRob · Pull Request #2759 · learningequality/studio · GitHub
Skip to content
Run sync before publishing a channel - #2759
Merged
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Jan 13, 2021
Merged
Run sync before publishing a channel#2759
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Conversation
@MisRob
@MisRobMisRob
commented
Jan 13, 2021

Copy link


Copy Markdown

Member
Description
  1. Run sync before publishing a channel to ensure that all updates are included
  2. One follow-up commit to address this comment from a previous sync PR
Issue Addressed (if applicable)
Closes#2536
Steps to Test
  • Increase SYNC_IF_NO_CHANGES_FOR, for example to 20 seconds, so that you can test it comfortably
  • Make a change in a channel that you can edit (add a new topic, exercise)
  • Publish the channel
  • Make sure that /sync request has been triggered before the publish request
Checklist
  •  Is the code clean and well-commented?
  •  Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  •  Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  •  Are there tests for this change?
  •  Are all user-facing strings translated properly (if applicable)?
  •  Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  •  Are all UI components LTR and RTL compliant (if applicable)?
  •  Are views organized into pages, components, and layouts directories as described in the docs?
  •  Are users' storage used being recalculated properly on any changes to their main tree files?
  •  Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  •  Are there any new interactions that need to be added to the QA Sheet?
  •  Are there opportunities for using Google Analytics here (if applicable)?
  •  If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  •  Are the migrations safe for a large db (if applicable)?
@MisRob
Sync before publish
67794dc
@MisRob
Don't sync in beforeunload handler
175824d
Do not risk unfinished call and thus inconsistent
data state.
rtibbles
rtibbles
reviewed
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look right, haven't manually tested yet.
rtibbles
rtibbles
approved these changes
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out!
@rtibbles
rtibbles
merged commit c82e609
into
learningequality:developJan 13, 2021
@MisRob
MisRob
deleted the

sync-before-publish

branch
February 3, 2021 07:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rtibblesrtibblesrtibbles approved these changes
@jayoshihjayoshihAwaiting requested review from jayoshih

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Force syncing on publish


2 participants

@MisRob@rtibbles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Run sync before publishing a channel by MisRob · Pull Request #2759 · learningequality/studio · GitHub
Skip to content
Run sync before publishing a channel - #2759
Merged
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Jan 13, 2021
Merged
Run sync before publishing a channel#2759
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Conversation
@MisRob
@MisRobMisRob
commented
Jan 13, 2021

Copy link


Copy Markdown

Member
Description
  1. Run sync before publishing a channel to ensure that all updates are included
  2. One follow-up commit to address this comment from a previous sync PR
Issue Addressed (if applicable)
Closes#2536
Steps to Test
  • Increase SYNC_IF_NO_CHANGES_FOR, for example to 20 seconds, so that you can test it comfortably
  • Make a change in a channel that you can edit (add a new topic, exercise)
  • Publish the channel
  • Make sure that /sync request has been triggered before the publish request
Checklist
  •  Is the code clean and well-commented?
  •  Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  •  Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  •  Are there tests for this change?
  •  Are all user-facing strings translated properly (if applicable)?
  •  Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  •  Are all UI components LTR and RTL compliant (if applicable)?
  •  Are views organized into pages, components, and layouts directories as described in the docs?
  •  Are users' storage used being recalculated properly on any changes to their main tree files?
  •  Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  •  Are there any new interactions that need to be added to the QA Sheet?
  •  Are there opportunities for using Google Analytics here (if applicable)?
  •  If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  •  Are the migrations safe for a large db (if applicable)?
@MisRob
Sync before publish
67794dc
@MisRob
Don't sync in beforeunload handler
175824d
Do not risk unfinished call and thus inconsistent
data state.
rtibbles
rtibbles
reviewed
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look right, haven't manually tested yet.
rtibbles
rtibbles
approved these changes
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out!
@rtibbles
rtibbles
merged commit c82e609
into
learningequality:developJan 13, 2021
@MisRob
MisRob
deleted the

sync-before-publish

branch
February 3, 2021 07:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rtibblesrtibblesrtibbles approved these changes
@jayoshihjayoshihAwaiting requested review from jayoshih

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Force syncing on publish


2 participants

@MisRob@rtibbles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Run sync before publishing a channel by MisRob · Pull Request #2759 · learningequality/studio · GitHub
Skip to content
Run sync before publishing a channel - #2759
Merged
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Jan 13, 2021
Merged
Run sync before publishing a channel#2759
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Conversation
@MisRob
@MisRobMisRob
commented
Jan 13, 2021

Copy link


Copy Markdown

Member
Description
  1. Run sync before publishing a channel to ensure that all updates are included
  2. One follow-up commit to address this comment from a previous sync PR
Issue Addressed (if applicable)
Closes#2536
Steps to Test
  • Increase SYNC_IF_NO_CHANGES_FOR, for example to 20 seconds, so that you can test it comfortably
  • Make a change in a channel that you can edit (add a new topic, exercise)
  • Publish the channel
  • Make sure that /sync request has been triggered before the publish request
Checklist
  •  Is the code clean and well-commented?
  •  Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  •  Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  •  Are there tests for this change?
  •  Are all user-facing strings translated properly (if applicable)?
  •  Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  •  Are all UI components LTR and RTL compliant (if applicable)?
  •  Are views organized into pages, components, and layouts directories as described in the docs?
  •  Are users' storage used being recalculated properly on any changes to their main tree files?
  •  Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  •  Are there any new interactions that need to be added to the QA Sheet?
  •  Are there opportunities for using Google Analytics here (if applicable)?
  •  If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  •  Are the migrations safe for a large db (if applicable)?
@MisRob
Sync before publish
67794dc
@MisRob
Don't sync in beforeunload handler
175824d
Do not risk unfinished call and thus inconsistent
data state.
rtibbles
rtibbles
reviewed
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look right, haven't manually tested yet.
rtibbles
rtibbles
approved these changes
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out!
@rtibbles
rtibbles
merged commit c82e609
into
learningequality:developJan 13, 2021
@MisRob
MisRob
deleted the

sync-before-publish

branch
February 3, 2021 07:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rtibblesrtibblesrtibbles approved these changes
@jayoshihjayoshihAwaiting requested review from jayoshih

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Force syncing on publish


2 participants

@MisRob@rtibbles

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Run sync before publishing a channel by MisRob · Pull Request #2759 · learningequality/studio · GitHub
Skip to content
Run sync before publishing a channel - #2759
Merged
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Jan 13, 2021
Merged
Run sync before publishing a channel#2759
rtibbles merged 2 commits into
learningequality:developfrom 
MisRob:sync-before-publish
Conversation
@MisRob
@MisRobMisRob
commented
Jan 13, 2021

Copy link


Copy Markdown

Member
Description
  1. Run sync before publishing a channel to ensure that all updates are included
  2. One follow-up commit to address this comment from a previous sync PR
Issue Addressed (if applicable)
Closes#2536
Steps to Test
  • Increase SYNC_IF_NO_CHANGES_FOR, for example to 20 seconds, so that you can test it comfortably
  • Make a change in a channel that you can edit (add a new topic, exercise)
  • Publish the channel
  • Make sure that /sync request has been triggered before the publish request
Checklist
  •  Is the code clean and well-commented?
  •  Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  •  Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  •  Are there tests for this change?
  •  Are all user-facing strings translated properly (if applicable)?
  •  Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
  •  Are all UI components LTR and RTL compliant (if applicable)?
  •  Are views organized into pages, components, and layouts directories as described in the docs?
  •  Are users' storage used being recalculated properly on any changes to their main tree files?
  •  Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
  •  Are there any new interactions that need to be added to the QA Sheet?
  •  Are there opportunities for using Google Analytics here (if applicable)?
  •  If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
  •  Are the migrations safe for a large db (if applicable)?
@MisRob
Sync before publish
67794dc
@MisRob
Don't sync in beforeunload handler
175824d
Do not risk unfinished call and thus inconsistent
data state.
rtibbles
rtibbles
reviewed
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look right, haven't manually tested yet.
rtibbles
rtibbles
approved these changes
Jan 13, 2021
View reviewed changes
@rtibblesrtibbles
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out!
@rtibbles
rtibbles
merged commit c82e609
into
learningequality:developJan 13, 2021
@MisRob
MisRob
deleted the

sync-before-publish

branch
February 3, 2021 07:08
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rtibblesrtibblesrtibbles approved these changes
@jayoshihjayoshihAwaiting requested review from jayoshih

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Force syncing on publish


2 participants

@MisRob@rtibbles