Skip to content

Add test to ensure that nodes can be saved with null complete. - #2764

Merged
rtibbles merged 1 commit into
learningequality:developfrom
rtibbles:null_complete
Jan 13, 2021
Merged

Add test to ensure that nodes can be saved with null complete.#2764
rtibbles merged 1 commit into
learningequality:developfrom
rtibbles:null_complete

Conversation

@rtibbles

Copy link
Copy Markdown
Member

Description

Adds a test to ensure that null complete is a valid value on content nodes

@codecov

codecovBot commented Jan 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2764 (229e843) into develop (b56f349) will increase coverage by 0.00%.
The diff coverage is 41.07%.

Impacted file tree graph

@@ Coverage Diff @@## develop #2764 +/- ##
========================================
Coverage 84.92% 84.92% ========================================
Files 307 309 +2 Lines 15327 15346 +19 ========================================
+ Hits 13016 13033 +17 - Misses 2311 2313 +2 
Impacted FilesCoverage Δ
...ntcuration/contentcuration/viewsets/contentnode.py83.73% <0.00%> (ø)
contentcuration/contentcuration/tasks.py62.58% <24.13%> (ø)
contentcuration/contentcuration/viewsets/user.py70.56% <33.33%> (ø)
contentcuration/contentcuration/views/admin.py73.68% <60.00%> (ø)
...uration/contentcuration/tests/test_contentnodes.py94.60% <66.66%> (-0.39%)⬇️
contentcuration/contentcuration/decorators.py56.60% <100.00%> (ø)
contentcuration/contentcuration/viewsets/file.py72.22% <100.00%> (ø)
...tentcuration/migrations/0129_auto_20210113_1723.py100.00% <0.00%> (ø)
...entcuration/migrations/0130_merge_20210113_1839.py100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c82e609...229e843. Read the comment docs.

@rtibbles
rtibbles merged commit 96a7db1 into learningequality:developJan 13, 2021
@rtibbles
rtibbles deleted the null_complete branch January 13, 2021 20:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rtibbles@micahscopes