Skip to content

Admin page fixes - #2765

Merged
micahscopes merged 17 commits into
learningequality:developfrom
jayoshih:admin
Jan 14, 2021
Merged

Admin page fixes#2765
micahscopes merged 17 commits into
learningequality:developfrom
jayoshih:admin

Conversation

@jayoshih

@jayoshihjayoshih commented Jan 13, 2021

Copy link
Copy Markdown
Contributor

Description

Fixes syncing changes on the admin page

Issue Addressed (if applicable)

Fixes#2015

Checklist

  • Is the code clean and well-commented?
  • Has the docs label been added if this introduces a change that needs to be updated in the user docs?
  • Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
  • Are there tests for this change?

@codecov

codecovBot commented Jan 13, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2765 (56c03ff) into develop (b56f349) will increase coverage by 0.02%.
The diff coverage is 53.03%.

Impacted file tree graph

@@ Coverage Diff @@## develop #2765 +/- ##
===========================================
+ Coverage 84.92% 84.94% +0.02% 
===========================================
Files 307 309 +2 Lines 15327 15355 +28 ===========================================
+ Hits 13016 13044 +28 
Misses 2311 2311 
Impacted FilesCoverage Δ
...ntcuration/contentcuration/viewsets/contentnode.py83.73% <0.00%> (ø)
contentcuration/contentcuration/tasks.py62.58% <24.13%> (ø)
contentcuration/contentcuration/views/admin.py73.68% <60.00%> (ø)
contentcuration/contentcuration/viewsets/user.py71.62% <73.33%> (+1.06%)⬆️
contentcuration/contentcuration/decorators.py56.60% <100.00%> (ø)
...ontentcuration/contentcuration/viewsets/channel.py78.94% <100.00%> (+0.49%)⬆️
contentcuration/contentcuration/viewsets/file.py72.22% <100.00%> (ø)
...tentcuration/migrations/0129_auto_20210113_1723.py100.00% <0.00%> (ø)
...entcuration/migrations/0130_merge_20210113_1839.py100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c82e609...5a32598. Read the comment docs.

@jayoshih
jayoshih requested review from micahscopes and removed request for rtibblesJanuary 14, 2021 00:29

@micahscopesmicahscopes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@micahscopes
micahscopes merged commit 6fd04aa into learningequality:developJan 14, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to ensure all actions on admin page are working

2 participants

@jayoshih@micahscopes