Skip to content

Switched type to mastery_model on extra_fields - #2832

Merged
jayoshih merged 2 commits into
learningequality:hotfixesfrom
jayoshih:masterymodel-fix
Jan 19, 2021
Merged

Switched type to mastery_model on extra_fields#2832
jayoshih merged 2 commits into
learningequality:hotfixesfrom
jayoshih:masterymodel-fix

Conversation

@jayoshih

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecovBot commented Jan 19, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2832 (e2f9d06) into hotfixes (28587f8) will increase coverage by 4.05%.
The diff coverage is 88.73%.

Impacted file tree graph

@@ Coverage Diff @@## hotfixes #2832 +/- ##
============================================
+ Coverage 80.80% 84.85% +4.05% 
============================================
Files 281 292 +11 Lines 12659 15338 +2679 ============================================
+ Hits 10229 13015 +2786 + Misses 2430 2323 -107 
Impacted FilesCoverage Δ
contentcuration/contentcuration/decorators.py56.60% <50.00%> (-37.60%)⬇️
contentcuration/contentcuration/forms.py69.06% <72.41%> (+20.61%)⬆️
...ntentcuration/contentcuration/db/models/manager.py93.49% <93.33%> (-6.51%)⬇️
contentcuration/contentcuration/api.py92.06% <100.00%> (+1.43%)⬆️
...tentcuration/contentcuration/context_processors.py100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py93.33% <100.00%> (-6.67%)⬇️
...entcuration/contentcuration/db/models/functions.py100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py36.93% <0.00%> (-63.07%)⬇️
contentcuration/contentcuration/utils/format.py21.05% <0.00%> (-49.54%)⬇️
contentcuration/contentcuration/utils/cache.py31.70% <0.00%> (-31.93%)⬇️
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13adbee...e2f9d06. Read the comment docs.

@rtibblesrtibbles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look right - couldn't find any instances missed in a search.

@jayoshih
jayoshih merged commit a59220f into learningequality:hotfixesJan 19, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jayoshih@rtibbles