Update the development setup script to reflect our `complete` validation strategy by MisRob · Pull Request #2842 · learningequality/studio

MisRob · 2021-01-20T17:55:35Z

Steps to Test

Clear IndexedDB
yarn run devsetup
Check that nodes in "Published Channel" editor are marked as complete/incomplete properly ("incomplete" error icon is visible for incomplete ones)

Checklist

Is the code clean and well-commented?
Has the docs label been added if this introduces a change that needs to be updated in the user docs?
Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
Are there tests for this change?
Are all user-facing strings translated properly (if applicable)?
Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
Are all UI components LTR and RTL compliant (if applicable)?
Are views organized into pages, components, and layouts directories as described in the docs?
Are users' storage used being recalculated properly on any changes to their main tree files?
Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
Are there any new interactions that need to be added to the QA Sheet?
Are there opportunities for using Google Analytics here (if applicable)?
If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
Are the migrations safe for a large db (if applicable)?

codecov · 2021-01-20T18:10:24Z

Codecov Report

Merging #2842 (673b715) into hotfixes (453d4f1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## hotfixes #2842 +/- ##
============================================
+ Coverage 84.85% 84.87% +0.02% 
============================================
Files 292 292 Lines 15338 15407 +69 ============================================
+ Hits 13015 13077 +62 - Misses 2323 2330 +7

Impacted Files	Coverage Δ
...ntcuration/contentcuration/tests/test_asynctask.py	`93.47% <0.00%> (-6.53%)`	⬇️
contentcuration/contentcuration/tasks_test.py	`100.00% <0.00%> (ø)`
...ntcuration/contentcuration/utils/celery_signals.py	`84.61% <0.00%> (+9.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d4f1...673b715. Read the comment docs.

rtibbles

Reduce to just the update to the dev setup command, please!

rtibbles · 2021-01-20T20:22:15Z

 channel1.main_tree.children.first().copy_to(channel4.main_tree)

 # Get validation to be reflected in nodes properly
+ ContentNode.objects.all().update(complete=True)


This is the line that I expected to see - the other changes have implications for test behaviour, so I'd rather they were left as is.

The remaining diff is just cleanup of the code I added some time ago and that is now obsolete. I'd prefer not to leave it here as is because it's confusing - it looks like that you can set those values to chosen ones when you actually can't as it will be overridden by newly introduced scripts - generate_tree is called before we start marking nodes as complete/incomplete here.
I am planning to come with a way of how to test complete/incomplete in the next PR I am working on so that we can test self-healing of incorrectly marked nodes.

I am planning to come with a way of how to test complete/incomplete in the next PR
It can be done this way at this point:
MisRob@1fddf26

I made some of these edits, as some of these utils are used during our tests, so I wanted to make sure the tests were accurately reflecting appropriate values for complete. e.g. ac072ea

Ah okay, so the issue is rather db utils parameters, not devsetup data itself. I haven't noticed that we are using utils from somewhere else - will revert that part.

MisRob · 2021-01-20T17:55:35Z

Steps to Test

Clear IndexedDB
yarn run devsetup
Check that nodes in "Published Channel" editor are marked as complete/incomplete properly ("incomplete" error icon is visible for incomplete ones)

Checklist

Is the code clean and well-commented?
Has the docs label been added if this introduces a change that needs to be updated in the user docs?
Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
Are there tests for this change?
Are all user-facing strings translated properly (if applicable)?
Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
Are all UI components LTR and RTL compliant (if applicable)?
Are views organized into pages, components, and layouts directories as described in the docs?
Are users' storage used being recalculated properly on any changes to their main tree files?
Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
Are there any new interactions that need to be added to the QA Sheet?
Are there opportunities for using Google Analytics here (if applicable)?
If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
Are the migrations safe for a large db (if applicable)?

codecov · 2021-01-20T18:10:24Z

Codecov Report

Merging #2842 (673b715) into hotfixes (453d4f1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## hotfixes #2842 +/- ##
============================================
+ Coverage 84.85% 84.87% +0.02% 
============================================
Files 292 292 Lines 15338 15407 +69 ============================================
+ Hits 13015 13077 +62 - Misses 2323 2330 +7

Impacted Files	Coverage Δ
...ntcuration/contentcuration/tests/test_asynctask.py	`93.47% <0.00%> (-6.53%)`	⬇️
contentcuration/contentcuration/tasks_test.py	`100.00% <0.00%> (ø)`
...ntcuration/contentcuration/utils/celery_signals.py	`84.61% <0.00%> (+9.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d4f1...673b715. Read the comment docs.

rtibbles

Reduce to just the update to the dev setup command, please!

rtibbles · 2021-01-20T20:22:15Z

 channel1.main_tree.children.first().copy_to(channel4.main_tree)

 # Get validation to be reflected in nodes properly
+ ContentNode.objects.all().update(complete=True)


This is the line that I expected to see - the other changes have implications for test behaviour, so I'd rather they were left as is.

The remaining diff is just cleanup of the code I added some time ago and that is now obsolete. I'd prefer not to leave it here as is because it's confusing - it looks like that you can set those values to chosen ones when you actually can't as it will be overridden by newly introduced scripts - generate_tree is called before we start marking nodes as complete/incomplete here.
I am planning to come with a way of how to test complete/incomplete in the next PR I am working on so that we can test self-healing of incorrectly marked nodes.

I am planning to come with a way of how to test complete/incomplete in the next PR
It can be done this way at this point:
MisRob@1fddf26

I made some of these edits, as some of these utils are used during our tests, so I wanted to make sure the tests were accurately reflecting appropriate values for complete. e.g. ac072ea

Ah okay, so the issue is rather db utils parameters, not devsetup data itself. I haven't noticed that we are using utils from somewhere else - will revert that part.

MisRob · 2021-01-20T17:55:35Z

Steps to Test

Clear IndexedDB
yarn run devsetup
Check that nodes in "Published Channel" editor are marked as complete/incomplete properly ("incomplete" error icon is visible for incomplete ones)

Checklist

Is the code clean and well-commented?
Has the docs label been added if this introduces a change that needs to be updated in the user docs?
Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
Are there tests for this change?
Are all user-facing strings translated properly (if applicable)?
Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
Are all UI components LTR and RTL compliant (if applicable)?
Are views organized into pages, components, and layouts directories as described in the docs?
Are users' storage used being recalculated properly on any changes to their main tree files?
Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
Are there any new interactions that need to be added to the QA Sheet?
Are there opportunities for using Google Analytics here (if applicable)?
If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
Are the migrations safe for a large db (if applicable)?

codecov · 2021-01-20T18:10:24Z

Codecov Report

Merging #2842 (673b715) into hotfixes (453d4f1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## hotfixes #2842 +/- ##
============================================
+ Coverage 84.85% 84.87% +0.02% 
============================================
Files 292 292 Lines 15338 15407 +69 ============================================
+ Hits 13015 13077 +62 - Misses 2323 2330 +7

Impacted Files	Coverage Δ
...ntcuration/contentcuration/tests/test_asynctask.py	`93.47% <0.00%> (-6.53%)`	⬇️
contentcuration/contentcuration/tasks_test.py	`100.00% <0.00%> (ø)`
...ntcuration/contentcuration/utils/celery_signals.py	`84.61% <0.00%> (+9.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d4f1...673b715. Read the comment docs.

rtibbles

Reduce to just the update to the dev setup command, please!

rtibbles · 2021-01-20T20:22:15Z

 channel1.main_tree.children.first().copy_to(channel4.main_tree)

 # Get validation to be reflected in nodes properly
+ ContentNode.objects.all().update(complete=True)


This is the line that I expected to see - the other changes have implications for test behaviour, so I'd rather they were left as is.

The remaining diff is just cleanup of the code I added some time ago and that is now obsolete. I'd prefer not to leave it here as is because it's confusing - it looks like that you can set those values to chosen ones when you actually can't as it will be overridden by newly introduced scripts - generate_tree is called before we start marking nodes as complete/incomplete here.
I am planning to come with a way of how to test complete/incomplete in the next PR I am working on so that we can test self-healing of incorrectly marked nodes.

I am planning to come with a way of how to test complete/incomplete in the next PR
It can be done this way at this point:
MisRob@1fddf26

I made some of these edits, as some of these utils are used during our tests, so I wanted to make sure the tests were accurately reflecting appropriate values for complete. e.g. ac072ea

Ah okay, so the issue is rather db utils parameters, not devsetup data itself. I haven't noticed that we are using utils from somewhere else - will revert that part.

MisRob · 2021-01-20T17:55:35Z

Steps to Test

Clear IndexedDB
yarn run devsetup
Check that nodes in "Published Channel" editor are marked as complete/incomplete properly ("incomplete" error icon is visible for incomplete ones)

Checklist

Is the code clean and well-commented?
Has the docs label been added if this introduces a change that needs to be updated in the user docs?
Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
Are there tests for this change?
Are all user-facing strings translated properly (if applicable)?
Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
Are all UI components LTR and RTL compliant (if applicable)?
Are views organized into pages, components, and layouts directories as described in the docs?
Are users' storage used being recalculated properly on any changes to their main tree files?
Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
Are there any new interactions that need to be added to the QA Sheet?
Are there opportunities for using Google Analytics here (if applicable)?
If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
Are the migrations safe for a large db (if applicable)?

codecov · 2021-01-20T18:10:24Z

Codecov Report

Merging #2842 (673b715) into hotfixes (453d4f1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## hotfixes #2842 +/- ##
============================================
+ Coverage 84.85% 84.87% +0.02% 
============================================
Files 292 292 Lines 15338 15407 +69 ============================================
+ Hits 13015 13077 +62 - Misses 2323 2330 +7

Impacted Files	Coverage Δ
...ntcuration/contentcuration/tests/test_asynctask.py	`93.47% <0.00%> (-6.53%)`	⬇️
contentcuration/contentcuration/tasks_test.py	`100.00% <0.00%> (ø)`
...ntcuration/contentcuration/utils/celery_signals.py	`84.61% <0.00%> (+9.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d4f1...673b715. Read the comment docs.

rtibbles

Reduce to just the update to the dev setup command, please!

rtibbles · 2021-01-20T20:22:15Z

 channel1.main_tree.children.first().copy_to(channel4.main_tree)

 # Get validation to be reflected in nodes properly
+ ContentNode.objects.all().update(complete=True)


This is the line that I expected to see - the other changes have implications for test behaviour, so I'd rather they were left as is.

The remaining diff is just cleanup of the code I added some time ago and that is now obsolete. I'd prefer not to leave it here as is because it's confusing - it looks like that you can set those values to chosen ones when you actually can't as it will be overridden by newly introduced scripts - generate_tree is called before we start marking nodes as complete/incomplete here.
I am planning to come with a way of how to test complete/incomplete in the next PR I am working on so that we can test self-healing of incorrectly marked nodes.

I am planning to come with a way of how to test complete/incomplete in the next PR
It can be done this way at this point:
MisRob@1fddf26

I made some of these edits, as some of these utils are used during our tests, so I wanted to make sure the tests were accurately reflecting appropriate values for complete. e.g. ac072ea

Ah okay, so the issue is rather db utils parameters, not devsetup data itself. I haven't noticed that we are using utils from somewhere else - will revert that part.

MisRob · 2021-01-20T17:55:35Z

Steps to Test

Clear IndexedDB
yarn run devsetup
Check that nodes in "Published Channel" editor are marked as complete/incomplete properly ("incomplete" error icon is visible for incomplete ones)

Checklist

Is the code clean and well-commented?
Has the docs label been added if this introduces a change that needs to be updated in the user docs?
Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
Are there tests for this change?
Are all user-facing strings translated properly (if applicable)?
Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
Are all UI components LTR and RTL compliant (if applicable)?
Are views organized into pages, components, and layouts directories as described in the docs?
Are users' storage used being recalculated properly on any changes to their main tree files?
Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
Are there any new interactions that need to be added to the QA Sheet?
Are there opportunities for using Google Analytics here (if applicable)?
If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
Are the migrations safe for a large db (if applicable)?

codecov · 2021-01-20T18:10:24Z

Codecov Report

Merging #2842 (673b715) into hotfixes (453d4f1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## hotfixes #2842 +/- ##
============================================
+ Coverage 84.85% 84.87% +0.02% 
============================================
Files 292 292 Lines 15338 15407 +69 ============================================
+ Hits 13015 13077 +62 - Misses 2323 2330 +7

Impacted Files	Coverage Δ
...ntcuration/contentcuration/tests/test_asynctask.py	`93.47% <0.00%> (-6.53%)`	⬇️
contentcuration/contentcuration/tasks_test.py	`100.00% <0.00%> (ø)`
...ntcuration/contentcuration/utils/celery_signals.py	`84.61% <0.00%> (+9.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d4f1...673b715. Read the comment docs.

rtibbles

Reduce to just the update to the dev setup command, please!

rtibbles · 2021-01-20T20:22:15Z

 channel1.main_tree.children.first().copy_to(channel4.main_tree)

 # Get validation to be reflected in nodes properly
+ ContentNode.objects.all().update(complete=True)


This is the line that I expected to see - the other changes have implications for test behaviour, so I'd rather they were left as is.

The remaining diff is just cleanup of the code I added some time ago and that is now obsolete. I'd prefer not to leave it here as is because it's confusing - it looks like that you can set those values to chosen ones when you actually can't as it will be overridden by newly introduced scripts - generate_tree is called before we start marking nodes as complete/incomplete here.
I am planning to come with a way of how to test complete/incomplete in the next PR I am working on so that we can test self-healing of incorrectly marked nodes.

I am planning to come with a way of how to test complete/incomplete in the next PR
It can be done this way at this point:
MisRob@1fddf26

I made some of these edits, as some of these utils are used during our tests, so I wanted to make sure the tests were accurately reflecting appropriate values for complete. e.g. ac072ea

Ah okay, so the issue is rather db utils parameters, not devsetup data itself. I haven't noticed that we are using utils from somewhere else - will revert that part.

MisRob · 2021-01-20T17:55:35Z

Steps to Test

Clear IndexedDB
yarn run devsetup
Check that nodes in "Published Channel" editor are marked as complete/incomplete properly ("incomplete" error icon is visible for incomplete ones)

Checklist

Is the code clean and well-commented?
Has the docs label been added if this introduces a change that needs to be updated in the user docs?
Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
Are there tests for this change?
Are all user-facing strings translated properly (if applicable)?
Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
Are all UI components LTR and RTL compliant (if applicable)?
Are views organized into pages, components, and layouts directories as described in the docs?
Are users' storage used being recalculated properly on any changes to their main tree files?
Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
Are there any new interactions that need to be added to the QA Sheet?
Are there opportunities for using Google Analytics here (if applicable)?
If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
Are the migrations safe for a large db (if applicable)?

codecov · 2021-01-20T18:10:24Z

Codecov Report

Merging #2842 (673b715) into hotfixes (453d4f1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## hotfixes #2842 +/- ##
============================================
+ Coverage 84.85% 84.87% +0.02% 
============================================
Files 292 292 Lines 15338 15407 +69 ============================================
+ Hits 13015 13077 +62 - Misses 2323 2330 +7

Impacted Files	Coverage Δ
...ntcuration/contentcuration/tests/test_asynctask.py	`93.47% <0.00%> (-6.53%)`	⬇️
contentcuration/contentcuration/tasks_test.py	`100.00% <0.00%> (ø)`
...ntcuration/contentcuration/utils/celery_signals.py	`84.61% <0.00%> (+9.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d4f1...673b715. Read the comment docs.

rtibbles

Reduce to just the update to the dev setup command, please!

rtibbles · 2021-01-20T20:22:15Z

 channel1.main_tree.children.first().copy_to(channel4.main_tree)

 # Get validation to be reflected in nodes properly
+ ContentNode.objects.all().update(complete=True)


This is the line that I expected to see - the other changes have implications for test behaviour, so I'd rather they were left as is.

The remaining diff is just cleanup of the code I added some time ago and that is now obsolete. I'd prefer not to leave it here as is because it's confusing - it looks like that you can set those values to chosen ones when you actually can't as it will be overridden by newly introduced scripts - generate_tree is called before we start marking nodes as complete/incomplete here.
I am planning to come with a way of how to test complete/incomplete in the next PR I am working on so that we can test self-healing of incorrectly marked nodes.

I am planning to come with a way of how to test complete/incomplete in the next PR
It can be done this way at this point:
MisRob@1fddf26

I made some of these edits, as some of these utils are used during our tests, so I wanted to make sure the tests were accurately reflecting appropriate values for complete. e.g. ac072ea

Ah okay, so the issue is rather db utils parameters, not devsetup data itself. I haven't noticed that we are using utils from somewhere else - will revert that part.

MisRob · 2021-01-20T17:55:35Z

Steps to Test

Clear IndexedDB
yarn run devsetup
Check that nodes in "Published Channel" editor are marked as complete/incomplete properly ("incomplete" error icon is visible for incomplete ones)

Checklist

Is the code clean and well-commented?
Has the docs label been added if this introduces a change that needs to be updated in the user docs?
Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
Are there tests for this change?
Are all user-facing strings translated properly (if applicable)?
Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
Are all UI components LTR and RTL compliant (if applicable)?
Are views organized into pages, components, and layouts directories as described in the docs?
Are users' storage used being recalculated properly on any changes to their main tree files?
Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
Are there any new interactions that need to be added to the QA Sheet?
Are there opportunities for using Google Analytics here (if applicable)?
If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
Are the migrations safe for a large db (if applicable)?

codecov · 2021-01-20T18:10:24Z

Codecov Report

Merging #2842 (673b715) into hotfixes (453d4f1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## hotfixes #2842 +/- ##
============================================
+ Coverage 84.85% 84.87% +0.02% 
============================================
Files 292 292 Lines 15338 15407 +69 ============================================
+ Hits 13015 13077 +62 - Misses 2323 2330 +7

Impacted Files	Coverage Δ
...ntcuration/contentcuration/tests/test_asynctask.py	`93.47% <0.00%> (-6.53%)`	⬇️
contentcuration/contentcuration/tasks_test.py	`100.00% <0.00%> (ø)`
...ntcuration/contentcuration/utils/celery_signals.py	`84.61% <0.00%> (+9.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d4f1...673b715. Read the comment docs.

rtibbles

Reduce to just the update to the dev setup command, please!

rtibbles · 2021-01-20T20:22:15Z

 channel1.main_tree.children.first().copy_to(channel4.main_tree)

 # Get validation to be reflected in nodes properly
+ ContentNode.objects.all().update(complete=True)


This is the line that I expected to see - the other changes have implications for test behaviour, so I'd rather they were left as is.

The remaining diff is just cleanup of the code I added some time ago and that is now obsolete. I'd prefer not to leave it here as is because it's confusing - it looks like that you can set those values to chosen ones when you actually can't as it will be overridden by newly introduced scripts - generate_tree is called before we start marking nodes as complete/incomplete here.
I am planning to come with a way of how to test complete/incomplete in the next PR I am working on so that we can test self-healing of incorrectly marked nodes.

I am planning to come with a way of how to test complete/incomplete in the next PR
It can be done this way at this point:
MisRob@1fddf26

I made some of these edits, as some of these utils are used during our tests, so I wanted to make sure the tests were accurately reflecting appropriate values for complete. e.g. ac072ea

Ah okay, so the issue is rather db utils parameters, not devsetup data itself. I haven't noticed that we are using utils from somewhere else - will revert that part.

MisRob · 2021-01-20T17:55:35Z

Steps to Test

Clear IndexedDB
yarn run devsetup
Check that nodes in "Published Channel" editor are marked as complete/incomplete properly ("incomplete" error icon is visible for incomplete ones)

Checklist

Is the code clean and well-commented?
Has the docs label been added if this introduces a change that needs to be updated in the user docs?
Has the CHANGELOG label been added to this pull request? Items with this label will be added to the CHANGELOG at a later time
Are there tests for this change?
Are all user-facing strings translated properly (if applicable)?
Has the notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)?
Are all UI components LTR and RTL compliant (if applicable)?
Are views organized into pages, components, and layouts directories as described in the docs?
Are users' storage used being recalculated properly on any changes to their main tree files?
Are there any new ways this uses user data that needs to be factored into our Privacy Policy?
Are there any new interactions that need to be added to the QA Sheet?
Are there opportunities for using Google Analytics here (if applicable)?
If the Pipfile has been changed, is the updated Pipfile.lock file also included in this PR?
Are the migrations safe for a large db (if applicable)?

codecov · 2021-01-20T18:10:24Z

Codecov Report

Merging #2842 (673b715) into hotfixes (453d4f1) will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## hotfixes #2842 +/- ##
============================================
+ Coverage 84.85% 84.87% +0.02% 
============================================
Files 292 292 Lines 15338 15407 +69 ============================================
+ Hits 13015 13077 +62 - Misses 2323 2330 +7

Impacted Files	Coverage Δ
...ntcuration/contentcuration/tests/test_asynctask.py	`93.47% <0.00%> (-6.53%)`	⬇️
contentcuration/contentcuration/tasks_test.py	`100.00% <0.00%> (ø)`
...ntcuration/contentcuration/utils/celery_signals.py	`84.61% <0.00%> (+9.10%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 453d4f1...673b715. Read the comment docs.

rtibbles

Reduce to just the update to the dev setup command, please!

rtibbles · 2021-01-20T20:22:15Z

 channel1.main_tree.children.first().copy_to(channel4.main_tree)

 # Get validation to be reflected in nodes properly
+ ContentNode.objects.all().update(complete=True)


This is the line that I expected to see - the other changes have implications for test behaviour, so I'd rather they were left as is.

The remaining diff is just cleanup of the code I added some time ago and that is now obsolete. I'd prefer not to leave it here as is because it's confusing - it looks like that you can set those values to chosen ones when you actually can't as it will be overridden by newly introduced scripts - generate_tree is called before we start marking nodes as complete/incomplete here.
I am planning to come with a way of how to test complete/incomplete in the next PR I am working on so that we can test self-healing of incorrectly marked nodes.

I am planning to come with a way of how to test complete/incomplete in the next PR
It can be done this way at this point:
MisRob@1fddf26

I made some of these edits, as some of these utils are used during our tests, so I wanted to make sure the tests were accurately reflecting appropriate values for complete. e.g. ac072ea

Ah okay, so the issue is rather db utils parameters, not devsetup data itself. I haven't noticed that we are using utils from somewhere else - will revert that part.

Update devsetup to the latest validation setup changes
b272a78

MisRob requested a review from rtibbles January 20, 2021 17:55

MisRob added the needs review label Jan 20, 2021

MisRob requested a review from micahscopes January 20, 2021 17:56

rtibbles requested changes Jan 20, 2021
View reviewed changes

MisRob requested a review from rtibbles January 21, 2021 07:19

MisRob added 2 commits January 21, 2021 18:42

Revert complete attribute deletion
049c75e

Fix syntax
673b715

rtibbles approved these changes Jan 21, 2021
View reviewed changes

rtibbles merged commit 1f29929 into learningequality:hotfixesJan 21, 2021

MisRob deleted the devsetup-complete branch February 3, 2021 07:08

Update devsetup to the latest validation setup changes
b272a78

MisRob requested a review from rtibbles January 20, 2021 17:55

MisRob added the needs review label Jan 20, 2021

MisRob requested a review from micahscopes January 20, 2021 17:56

rtibbles requested changes Jan 20, 2021
View reviewed changes

MisRob requested a review from rtibbles January 21, 2021 07:19

MisRob added 2 commits January 21, 2021 18:42

Revert complete attribute deletion
049c75e

Fix syntax
673b715

rtibbles approved these changes Jan 21, 2021
View reviewed changes

rtibbles merged commit 1f29929 into learningequality:hotfixesJan 21, 2021

MisRob deleted the devsetup-complete branch February 3, 2021 07:08

Update devsetup to the latest validation setup changes
b272a78

MisRob requested a review from rtibbles January 20, 2021 17:55

MisRob added the needs review label Jan 20, 2021

MisRob requested a review from micahscopes January 20, 2021 17:56

rtibbles requested changes Jan 20, 2021
View reviewed changes

MisRob requested a review from rtibbles January 21, 2021 07:19

MisRob added 2 commits January 21, 2021 18:42

Revert complete attribute deletion
049c75e

Fix syntax
673b715

rtibbles approved these changes Jan 21, 2021
View reviewed changes

rtibbles merged commit 1f29929 into learningequality:hotfixesJan 21, 2021

MisRob deleted the devsetup-complete branch February 3, 2021 07:08

Update devsetup to the latest validation setup changes
b272a78

MisRob requested a review from rtibbles January 20, 2021 17:55

MisRob added the needs review label Jan 20, 2021

MisRob requested a review from micahscopes January 20, 2021 17:56

rtibbles requested changes Jan 20, 2021
View reviewed changes

MisRob requested a review from rtibbles January 21, 2021 07:19

MisRob added 2 commits January 21, 2021 18:42

Revert complete attribute deletion
049c75e

Fix syntax
673b715

rtibbles approved these changes Jan 21, 2021
View reviewed changes

rtibbles merged commit 1f29929 into learningequality:hotfixesJan 21, 2021

MisRob deleted the devsetup-complete branch February 3, 2021 07:08

Update devsetup to the latest validation setup changes
b272a78

MisRob requested a review from rtibbles January 20, 2021 17:55

MisRob added the needs review label Jan 20, 2021

MisRob requested a review from micahscopes January 20, 2021 17:56

rtibbles requested changes Jan 20, 2021
View reviewed changes

MisRob requested a review from rtibbles January 21, 2021 07:19

MisRob added 2 commits January 21, 2021 18:42

Revert complete attribute deletion
049c75e

Fix syntax
673b715

rtibbles approved these changes Jan 21, 2021
View reviewed changes

rtibbles merged commit 1f29929 into learningequality:hotfixesJan 21, 2021

MisRob deleted the devsetup-complete branch February 3, 2021 07:08

Update devsetup to the latest validation setup changes
b272a78

MisRob requested a review from rtibbles January 20, 2021 17:55

MisRob added the needs review label Jan 20, 2021

MisRob requested a review from micahscopes January 20, 2021 17:56

rtibbles requested changes Jan 20, 2021
View reviewed changes

MisRob requested a review from rtibbles January 21, 2021 07:19

MisRob added 2 commits January 21, 2021 18:42

Revert complete attribute deletion
049c75e

Fix syntax
673b715

rtibbles approved these changes Jan 21, 2021
View reviewed changes

rtibbles merged commit 1f29929 into learningequality:hotfixesJan 21, 2021

MisRob deleted the devsetup-complete branch February 3, 2021 07:08

Update devsetup to the latest validation setup changes
b272a78

MisRob requested a review from rtibbles January 20, 2021 17:55

MisRob added the needs review label Jan 20, 2021

MisRob requested a review from micahscopes January 20, 2021 17:56

rtibbles requested changes Jan 20, 2021
View reviewed changes

MisRob requested a review from rtibbles January 21, 2021 07:19

MisRob added 2 commits January 21, 2021 18:42

Revert complete attribute deletion
049c75e

Fix syntax
673b715

rtibbles approved these changes Jan 21, 2021
View reviewed changes

rtibbles merged commit 1f29929 into learningequality:hotfixesJan 21, 2021

MisRob deleted the devsetup-complete branch February 3, 2021 07:08

Update devsetup to the latest validation setup changes
b272a78

MisRob requested a review from rtibbles January 20, 2021 17:55

MisRob added the needs review label Jan 20, 2021

MisRob requested a review from micahscopes January 20, 2021 17:56

rtibbles requested changes Jan 20, 2021
View reviewed changes

MisRob requested a review from rtibbles January 21, 2021 07:19

MisRob added 2 commits January 21, 2021 18:42

Revert complete attribute deletion
049c75e

Fix syntax
673b715

rtibbles approved these changes Jan 21, 2021
View reviewed changes

rtibbles merged commit 1f29929 into learningequality:hotfixesJan 21, 2021

MisRob deleted the devsetup-complete branch February 3, 2021 07:08

Uh oh!

Uh oh!

Conversation

MisRob commented Jan 20, 2021

Steps to Test

Checklist

Uh oh!

codecovBot commented Jan 20, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rtibbles left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MisRobJan 21, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

MisRob commented Jan 20, 2021

Steps to Test

Checklist

Uh oh!

codecovBot commented Jan 20, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rtibbles left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MisRobJan 21, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

MisRob commented Jan 20, 2021

Steps to Test

Checklist

Uh oh!

codecovBot commented Jan 20, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rtibbles left a comment

codecovBot commented Jan 20, 2021•
edited
Loading

MisRobJan 21, 2021•
edited
Loading

codecovBot commented Jan 20, 2021•
edited
Loading

MisRobJan 21, 2021•
edited
Loading

codecovBot commented Jan 20, 2021•
edited
Loading

MisRobJan 21, 2021•
edited
Loading

codecovBot commented Jan 20, 2021•
edited
Loading

MisRobJan 21, 2021•
edited
Loading