Skip to content

Updates to create channel internal endpoint to handle custom channel navigation creation - #2908

Merged
rtibbles merged 1 commit into
learningequality:hotfixesfrom
rtibbles:custom_navigation_updates
Feb 11, 2021
Merged

Updates to create channel internal endpoint to handle custom channel navigation creation#2908
rtibbles merged 1 commit into
learningequality:hotfixesfrom
rtibbles:custom_navigation_updates

Conversation

@rtibbles

Copy link
Copy Markdown
Member

Description

Updates the create channel endpoint to allow passing the data for a custom HTML5 app to attach to the root node of a channel, and the extra fields setting that is needed to flag the root node as a custom navigation topic.

@codecov

codecovBot commented Feb 4, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2908 (7f5454c) into hotfixes (28587f8) will increase coverage by 4.63%.
The diff coverage is 93.00%.

Impacted file tree graph

@@ Coverage Diff @@## hotfixes #2908 +/- ##
============================================
+ Coverage 80.80% 85.44% +4.63% 
============================================
Files 281 298 +17 Lines 12659 15819 +3160 ============================================
+ Hits 10229 13516 +3287 + Misses 2430 2303 -127 
Impacted FilesCoverage Δ
contentcuration/contentcuration/decorators.py56.60% <50.00%> (-37.60%)⬇️
...ntentcuration/contentcuration/db/models/manager.py91.20% <90.98%> (-8.80%)⬇️
contentcuration/contentcuration/forms.py82.85% <94.31%> (+34.40%)⬆️
contentcuration/contentcuration/api.py92.06% <100.00%> (+1.43%)⬆️
...tentcuration/contentcuration/context_processors.py100.00% <100.00%> (ø)
...ontentcuration/contentcuration/db/advisory_lock.py100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py93.33% <100.00%> (-6.67%)⬇️
...entcuration/contentcuration/db/models/functions.py100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py36.93% <0.00%> (-63.07%)⬇️
contentcuration/contentcuration/utils/format.py21.05% <0.00%> (-49.54%)⬇️
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caaadfe...7f5454c. Read the comment docs.

@kollivierkollivier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles
rtibbles merged commit e293d69 into learningequality:hotfixesFeb 11, 2021
@rtibbles
rtibbles deleted the custom_navigation_updates branch February 11, 2021 17:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rtibbles@kollivier