Skip to content

Fix activate channel endpoint behaviour - #2918

Merged
rtibbles merged 1 commit into
learningequality:hotfixesfrom
rtibbles:no_double_counting
Feb 9, 2021
Merged

Fix activate channel endpoint behaviour#2918
rtibbles merged 1 commit into
learningequality:hotfixesfrom
rtibbles:no_double_counting

Conversation

@rtibbles

Copy link
Copy Markdown
Member

Description

  • Ensures proper behaviour of the activate channel endpoint by ensuring that staged files and active files are properly compared against current usage.
  • Adds tests for the activate channel endpoint
  • Properly wraps the activate channel endpoint so that it gets a non-anonymous user from the request

@codecov

codecovBot commented Feb 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2918 (7fafb00) into hotfixes (28587f8) will increase coverage by 4.73%.
The diff coverage is 93.00%.

Impacted file tree graph

@@ Coverage Diff @@## hotfixes #2918 +/- ##
============================================
+ Coverage 80.80% 85.53% +4.73% 
============================================
Files 281 299 +18 Lines 12659 15827 +3168 ============================================
+ Hits 10229 13538 +3309 + Misses 2430 2289 -141 
Impacted FilesCoverage Δ
contentcuration/contentcuration/decorators.py56.60% <50.00%> (-37.60%)⬇️
...ntentcuration/contentcuration/db/models/manager.py91.20% <90.98%> (-8.80%)⬇️
contentcuration/contentcuration/forms.py82.85% <94.31%> (+34.40%)⬆️
contentcuration/contentcuration/api.py92.06% <100.00%> (+1.43%)⬆️
...tentcuration/contentcuration/context_processors.py100.00% <100.00%> (ø)
...ontentcuration/contentcuration/db/advisory_lock.py100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py93.33% <100.00%> (-6.67%)⬇️
...entcuration/contentcuration/db/models/functions.py100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py36.93% <0.00%> (-63.07%)⬇️
contentcuration/contentcuration/utils/format.py21.05% <0.00%> (-49.54%)⬇️
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b190d51...c83ee67. Read the comment docs.

@kollivierkollivier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles
rtibbles merged commit e0bbec6 into learningequality:hotfixesFeb 9, 2021
@rtibbles
rtibbles deleted the no_double_counting branch February 9, 2021 00:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rtibbles@kollivier