Skip to content

Fix bug in activate_channel endpoint - #2931

Merged
rtibbles merged 1 commit into
learningequality:hotfixesfrom
rtibbles:activate_channel_body
Feb 11, 2021
Merged

Fix bug in activate_channel endpoint#2931
rtibbles merged 1 commit into
learningequality:hotfixesfrom
rtibbles:activate_channel_body

Conversation

@rtibbles

Copy link
Copy Markdown
Member

Description

Completes the update of the activate_channel endpoint to a DRF APIView by using request.data

Issue Addressed (if applicable)

Fixes#2930

@kollivierkollivier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov

codecovBot commented Feb 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2931 (053f721) into hotfixes (28587f8) will increase coverage by 4.73%.
The diff coverage is 93.00%.

Impacted file tree graph

@@ Coverage Diff @@## hotfixes #2931 +/- ##
============================================
+ Coverage 80.80% 85.53% +4.73% 
============================================
Files 281 299 +18 Lines 12659 15827 +3168 ============================================
+ Hits 10229 13538 +3309 + Misses 2430 2289 -141 
Impacted FilesCoverage Δ
contentcuration/contentcuration/decorators.py56.60% <50.00%> (-37.60%)⬇️
...ntentcuration/contentcuration/db/models/manager.py91.20% <90.98%> (-8.80%)⬇️
contentcuration/contentcuration/forms.py82.85% <94.31%> (+34.40%)⬆️
contentcuration/contentcuration/api.py92.06% <100.00%> (+1.43%)⬆️
...tentcuration/contentcuration/context_processors.py100.00% <100.00%> (ø)
...ontentcuration/contentcuration/db/advisory_lock.py100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py93.33% <100.00%> (-6.67%)⬇️
...entcuration/contentcuration/db/models/functions.py100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py36.93% <0.00%> (-63.07%)⬇️
contentcuration/contentcuration/utils/format.py21.05% <0.00%> (-49.54%)⬇️
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fcca0f...baf6bc7. Read the comment docs.

@rtibbles
rtibbles merged commit d1a9de9 into learningequality:hotfixesFeb 11, 2021
@rtibbles
rtibbles deleted the activate_channel_body branch February 11, 2021 16:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RawPostDataException: You cannot access body after reading from request's data stream

2 participants

@rtibbles@kollivier