Skip to content

Rename RouterNames -> RouteNames - #2939

Merged
rtibbles merged 1 commit into
learningequality:developfrom
jonboiser:rename-routernames
Feb 12, 2021
Merged

Rename RouterNames -> RouteNames#2939
rtibbles merged 1 commit into
learningequality:developfrom
jonboiser:rename-routernames

Conversation

@jonboiser

@jonboiserjonboiser commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

Renames all RouterNames tokens to RouteNames.

Fixes#2028

@rtibbles

rtibbles commented Feb 11, 2021

Copy link
Copy Markdown
Member

@jonboiser as this is not a bug fix, could you retarget this to develop?

@jonboiser
jonboiser changed the base branch from hotfixes to developFebruary 11, 2021 18:08
@jonboiser
jonboiserforce-pushed the rename-routernames branch 2 times, most recently from ef829bd to b1760a8CompareFebruary 11, 2021 18:12
@codecov

codecovBot commented Feb 11, 2021•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2939 (e1d34f3) into develop (950e24f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## develop #2939 +/- ##
========================================
Coverage 84.85% 84.85% ========================================
Files 292 292 Lines 15338 15338 ========================================
Hits 13015 13015 Misses 2323 2323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f4c9a...526c1a8. Read the comment docs.

MisRob
MisRob approved these changes Feb 12, 2021
View reviewed changes

@MisRobMisRob left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jonboiser. I've checked the diff and clicked through the important paths in the app. Everything looks good to me. Before merging, could you please run yarn lint-all:fix to fix the failing linting check?

Do you have githooks installed for Studio? This should run automatically before a commit.

@rtibbles
rtibbles merged commit 2e4b7d2 into learningequality:developFeb 12, 2021
@rtibblesrtibbles mentioned this pull request Feb 12, 2021
Closed
@MisRobMisRob mentioned this pull request Feb 17, 2021
Merged
@jonboiser
jonboiser deleted the rename-routernames branch February 17, 2021 21:45
@bjesterbjester mentioned this pull request Apr 26, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MisRobMisRobMisRob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Studio: Frontend Tech Debt and KDS In...

Development

Successfully merging this pull request may close these issues.

Routes constants naming

3 participants

@jonboiser@rtibbles@MisRob