Skip to content

Replace VDialog with KModal in "Related resources tab" - #2980

Merged
MisRob merged 1 commit into
learningequality:developfrom
MisRob:kds-kmodal-relatedresourcestab
Feb 23, 2021
Merged

Replace VDialog with KModal in "Related resources tab"#2980
MisRob merged 1 commit into
learningequality:developfrom
MisRob:kds-kmodal-relatedresourcestab

Conversation

@MisRob

Copy link
Copy Markdown
Member

Description

Replace VDialog with KModal in "Related resources tab"

Issue Addressed

Part of learningequality/kolibri-design-system#156

Before/After Screenshots

BeforeAfter
beforeafter

Steps to Test

  • Navigate to a channel editor
  • Open edit modal for a resource
  • Navigate to "Related" tab
  • Click "Show me" link under the title

@nucleogenesisnucleogenesis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MisRob
MisRob merged commit 405d819 into learningequality:developFeb 23, 2021
@MisRob
MisRob deleted the kds-kmodal-relatedresourcestab branch March 15, 2021 12:35
@pcenov

Copy link
Copy Markdown
Member

Tested at https://hotfixes.studio.learningequality.org/ - looks great.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MisRob@pcenov@nucleogenesis