Uh oh!
There was an error while loading. Please reload this page.
Delete channels from the channel edit view - #2988
Merged
sairina merged 1 commit intoFeb 24, 2021
Merged
Conversation
micahscopes
commented
Feb 24, 2021
| this.showProgressModal = true; | ||
| }, | ||
| deleteChannel() { | ||
| deleteChannelModal() { |
ContributorAuthor
There was a problem hiding this comment.
deleteChannel also happened to be the name of a vuex action that was mapped into this component, so these were conflicting.
micahscopes
commented
Feb 24, 2021
| // Call endpoint directly in case we need to navigate to new page | ||
| return this.transaction({ mode: 'rw', source: IGNORED_SOURCE }, () => { | ||
| return this.table.update(id, { deleted: true }).then(() => { | ||
| return client.patch(this.modelUrl(id), { deleted: true }); |
ContributorAuthor
There was a problem hiding this comment.
Dexie doesn't support using these kinds of promises inside of transactions, see here.
Member
There was a problem hiding this comment.
This might be a useful code comment?
micahscopesforce-pushed
the
delete-channels-in-edit-page
branch
2 times, most recently
from
February 24, 2021 15:04
fa7095f to
f9e1040Comparemicahscopesforce-pushed
the
delete-channels-in-edit-page
branch
from
February 24, 2021 15:07
f9e1040 to
295bf95Comparemetodimilevqa
commented
Mar 2, 2021
I confirm the fix is successful with #3000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes deletion of channels from the channel edit page.
Issue Addressed (if applicable)
Fixes#2894
Steps to Test
Implementation Notes (optional)
At a high level, how did you implement this?
There were two small bugs: