Skip to content

Add additional fields for pending channels - #2994

Merged
rtibbles merged 1 commit into
learningequality:hotfixesfrom
sairina:filter-query
Feb 26, 2021
Merged

Add additional fields for pending channels#2994
rtibbles merged 1 commit into
learningequality:hotfixesfrom
sairina:filter-query

Conversation

@sairina

@sairinasairina commented Feb 25, 2021

Copy link
Copy Markdown
Contributor

Description

When dealing with invitations, the model for Channels had not been updated to include revoked, declined, and accepted, as per the new Invitation models. This PR updates that in the pending_channels

Checklist

Delete any items that don't apply

  • Is the code clean and well-commented?
  • Are views organized into pages, components, and layouts directories as described in the docs?

@codecov

codecovBot commented Feb 25, 2021

Copy link
Copy Markdown

Codecov Report

Merging #2994 (3ef91ae) into hotfixes (28587f8) will increase coverage by 4.94%.
The diff coverage is 92.92%.

Impacted file tree graph

@@ Coverage Diff @@## hotfixes #2994 +/- ##
============================================
+ Coverage 80.80% 85.74% +4.94% 
============================================
Files 281 298 +17 Lines 12659 15845 +3186 ============================================
+ Hits 10229 13587 +3358 + Misses 2430 2258 -172 
Impacted FilesCoverage Δ
contentcuration/contentcuration/decorators.py56.60% <50.00%> (-37.60%)⬇️
...ntentcuration/contentcuration/db/models/manager.py91.20% <90.98%> (-8.80%)⬇️
contentcuration/contentcuration/forms.py82.35% <94.04%> (+33.89%)⬆️
contentcuration/contentcuration/api.py92.06% <100.00%> (+1.43%)⬆️
...tentcuration/contentcuration/context_processors.py100.00% <100.00%> (ø)
...ontentcuration/contentcuration/db/advisory_lock.py100.00% <100.00%> (ø)
...tcuration/contentcuration/db/models/expressions.py93.33% <100.00%> (-6.67%)⬇️
...entcuration/contentcuration/db/models/functions.py100.00% <100.00%> (ø)
...ation/contentcuration/tests/test_rest_framework.py36.93% <0.00%> (-63.07%)⬇️
contentcuration/contentcuration/utils/format.py21.05% <0.00%> (-49.54%)⬇️
... and 181 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3364062...b896b92. Read the comment docs.

@sairina
sairina marked this pull request as ready for review February 26, 2021 22:13
@rtibbles

Copy link
Copy Markdown
Member

Follow up from #2529

@rtibbles
rtibbles merged commit 0db6be3 into learningequality:hotfixesFeb 26, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@sairina@rtibbles