Hotfixes release for last 2 sprints ending 2021-08-02 by bjester · Pull Request #3247 · learningequality/studio

bjester · 2021-07-19T23:37:05Z

Summary

Fixes handling of default setting for randomization of exercise questions
Fixes issue resulting in duplicate server syncing requests when multiple tabs are used
Fixes cross-origin issue when signing out
Fixes cosmetic issue in related resources management
Fixes potential performance issue when editing markdown
Fixes bug in developer setup after Django upgrade
Adds cron job to invoke garbage collection command which now cleans up completed tasks
Small code refactors from technical debt identified by deepsource.io and SonarCloud

PR	Issues	Category	QA Focus
#3253	#3244	Bug fix	Verify channel exercise setting in export
#3251, #3256	#3191	Bug fix	Edit channel with multiple tabs open
#3255	N/A	Cosmetic fix	Previewing related resource in drawer
#3254	N/A	Bug fix	Sign out clears local data
#3252	N/A	Bug fix	Adding topic doesn't cause console error
#3236	N/A	Performance	Edit rich exercise content
#3066	N/A	Tech debt	Critical workflows
#3221	N/A	Tech debt	Critical workflows
#3220	N/A	Tech debt	Critical workflows
#3222	N/A	Tech debt	Critical workflows
#3219	N/A	Tech debt	Critical workflows
#3223	N/A	Tech debt	Critical workflows
#3229	N/A	Tech debt	Critical workflows
#3211	N/A	Tech debt	Critical workflows
#3230	N/A	Tech debt	Critical workflows
#3232	N/A	Tech debt	Critical workflows
#3228	N/A	Tech debt	Critical workflows
#3231	N/A	Tech debt	Critical workflows
#3242	N/A	Tech debt	Critical workflows
#3238	N/A	Tech debt	Critical workflows
#3241	N/A	Tech debt	Critical workflows
#3239	N/A	Tech debt	Critical workflows
#3240	N/A	Tech debt	Critical workflows
#3237	N/A	Tech debt	Critical workflows
#3257	N/A	Security update	N/A
#3233	N/A	Dev fix	N/A

QA Scenarios

Verify exercise randomization setting in channel export

Open a channel for editing
Click ADD and select New Exercise
Do not change the setting for Randomize question order for learners
Add Title, Mastery model, License, and at least one question then save the exercise
Publish the channel
Manually download the channel database https://hotfixes.studio.learningequality.org/content/databases/<CHANNEL_ID>.sqlite3
Use SQLite browser tool or CLI to inspect content_assessmentmetadata table and verify randomize value is 1
Repeat scenario, unsetting the randomize option

Edit channel with multiple tabs open

Open a channel for editing
Duplicate the tab
Open the Developer Console in both tabs and go to the Network tab of each console
Refresh both tabs
Ensure only one tab registers requests to a sync URL

Previewing related resource in drawer

Open a channel for editing
Add or edit an exercise
Click RELATED tab
Click either ADD NEXT STEP or ADD PREVIOUS STEP
Click PREVIEW on a resource
Verify you can scroll to the bottom of the preview drawer

Sign out clears local data

Open a channel for editing
Open the Developer Console and go to the Application tab
Sign out
Verify that there's no data inside Developer Console > Application > Storage > IndexedDB > Kolibri Studio > contentnode

Adding topic doesn't cause console error

Open a channel for editing
Open the Developer Console and go to the Console tab
Click ADD and select New Topic
Verify there's no error in console

Edit rich exercise content

Open a channel for editing
Click ADD and select New Exercise
Add Title, Mastery model, and License
Click the QUESTIONS tab
Click NEW QUESTION
Use tools to add rich text into the Question, Answer, and/or Hint textboxes

Critical workflows

…urce-fix-a29486d6 Replace `==`/`!=` with `===`/`!==`

…urce-fix-ddeef224 Replace `assertEquals` with `assertEqual`

…urce-fix-5580e907 Replace list comprehension with set comprehension

…urce-fix-89e9f703 Remove unnecessary use of comprehension

…urce-fix-2ef385ca Remove reimported module

…urce-fix-f1d0fd14 Remove assert statement from non-test files

…urce-fix-c273c78e Replace short hand type conversions with JavaScript methods

…atement

…urce-fix-d330b87d Remove length check in favour of truthiness of the object

…urce-fix-59592cc6 Use literal syntax instead of function calls to create data structure

…urce-fix-44ffe5ee Use identity check for comparison to a singleton

…urce-fix-918e0e01 Refactor unnecessary `else` / `elif` when `if` block has a `raise` statement

Catch integrity error to handle both sides of missing prerequisite relationships.

Fix setup

…rability Fix cross-origin event listener vulnerability.

Handle a ref being undefined during computed prop computation.

Make randomize default to true in the frontend

Co-authored-by: Richard Tibbles <richard@learningequality.org>

…asks-cronjob add cronjob that clears old tasks every midnight

Lint.

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>

Remove API request consolidation across tabs.

…abot/npm_and_yarn/path-parse-1.0.7 Bump path-parse from 1.0.6 to 1.0.7

sonarqubecloud · 2021-08-12T16:55:24Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

radinamatic · 2021-08-12T23:41:50Z

Apologies for the delay, @pcenov finished running the critical workflows on Friday, only I was dragging my feet to confirm specific test scenarios for this sprint...

PR	Issues	Category	QA Focus	Status	img
#3253	#3244	Bug fix	Verify channel exercise setting in export	✔️
#3251, #3256	#3191	Bug fix	Edit channel with multiple tabs open	✔️
#3255	N/A	Cosmetic fix	Previewing related resource in drawer	✔️
#3254	N/A	Bug fix	Sign out clears local data	✔️
#3252	N/A	Bug fix	Adding topic doesn't cause console error	✔️
#3236	N/A	Performance	Edit rich exercise content	✔️	Few errors in the console while uploading images in question, answer and hint fields, and one during publishing, which completed successfully irregardless.

radinamatic · 2021-08-17T05:50:41Z

@bjester this looks good to go in production, no regressions in sight! 💯 👏🏽

deepsource-autofixBotand others added 30 commits July 6, 2021 14:25

Replace short hand type conversions with JavaScript methods
3c50dd1

Remove unnecessary use of comprehension
979bcab

Replace assertEquals with assertEqual
e1795a4

Replace ==/!= with ===/!==
0343954

Replace list comprehension with set comprehension
e26b581

Remove reimported module
361cb4d

Merge pull requestlearningequality#3221from learningequality/deepso…
71980d2
…urce-fix-a29486d6 Replace `==`/`!=` with `===`/`!==`

Update models reference
3c417f5

Merge pull requestlearningequality#3220from learningequality/deepso…
92f22d7
…urce-fix-ddeef224 Replace `assertEquals` with `assertEqual`

Merge pull requestlearningequality#3222from learningequality/deepso…
24f806c
…urce-fix-5580e907 Replace list comprehension with set comprehension

Merge pull requestlearningequality#3219from learningequality/deepso…
8c61b6f
…urce-fix-89e9f703 Remove unnecessary use of comprehension

Merge pull requestlearningequality#3223from learningequality/deepso…
b6fc37b
…urce-fix-2ef385ca Remove reimported module

Use identity check for comparison to a singleton
c1bcb29

Lint
70836ca

Remove assert statement from non-test files
4947bda

Merge pull requestlearningequality#3229from learningequality/deepso…
83ce9cf
…urce-fix-f1d0fd14 Remove assert statement from non-test files

Merge pull requestlearningequality#3211from learningequality/deepso…
63be85b
…urce-fix-c273c78e Replace short hand type conversions with JavaScript methods

Remove length check in favour of truthiness of the object
f6e6aed

Refactor unnecessary else / elif when if block has a raise st…
b92cae0
…atement

Use literal syntax instead of function calls to create data structure
f04f2c5

Merge pull requestlearningequality#3230from learningequality/deepso…
21266b3
…urce-fix-d330b87d Remove length check in favour of truthiness of the object

Merge pull requestlearningequality#3232from learningequality/deepso…
7436409
…urce-fix-59592cc6 Use literal syntax instead of function calls to create data structure

Merge pull requestlearningequality#3228from learningequality/deepso…
3ab9a3b
…urce-fix-44ffe5ee Use identity check for comparison to a singleton

Merge pull requestlearningequality#3231from learningequality/deepso…
aed2a29
…urce-fix-918e0e01 Refactor unnecessary `else` / `elif` when `if` block has a `raise` statement

Warn when trying to publish channel with incomplete root node.
cbf53c7
Catch integrity error to handle both sides of missing prerequisite relationships.

Don't mark root nodes as incomplete.
cad81de

Don't await synchronous function
8849cd4

Merge pull requestlearningequality#3233from rtibbles/fix_setup
4bdda0f
Fix setup

Use regex test instead of match for existence
7868225

Remove redundant None default
211a369

rtibblesand others added 2 commits August 4, 2021 16:28

Reference properties that actually exist!
f3e1a0b

Merge pull requestlearningequality#3254from rtibbles/original_vulne…
d302bcd
…rability Fix cross-origin event listener vulnerability.

bjester changed the title ~~Hotfixes release for sprint ending 2021-07-19~~Hotfixes release for last 2 sprints ending 2021-08-02Aug 4, 2021

Aron Asorand others added 20 commits August 4, 2021 19:33

add cronjob that clears old tasks every midnight
5b57646

Prevent unnecessary MPTT operations in garbage collection.
a4be8dd

Add task clean up to garbage collection.
76ed3f8

Do garbage collection cronjob instead of just task cleanup.
5f9b055

Merge pull requestlearningequality#3252from rtibbles/undefined_
dee1290
Handle a ref being undefined during computed prop computation.

Merge pull requestlearningequality#3253from rtibbles/randomize
3523d71
Make randomize default to true in the frontend

Remove API request consolidation across tabs.
ae74ae3

Consolidate garbage collection tests.
c502574

Update k8s/templates/garbage-collect-cronjob.yaml
7acb364
Co-authored-by: Richard Tibbles <richard@learningequality.org>

Merge pull requestlearningequality#3066from aronasorman/clear-old-t…
8c4cf8e
…asks-cronjob add cronjob that clears old tasks every midnight

Universally mock client and urls.
5711dd4

Cleanup logging in tests to make errors stand out better.
555b307

Clean up yarn test commands.
b9eabae

Consolidate global mocks.
6d40f84

Add defensive checks.
9a9eddd

Stub/mock async behaviour.
79388d2

Mock async created calls in channelsetmodal tests.
98b5105
Lint.

Merge pull requestlearningequality#3256from rtibbles/fetch_not_request
830d965
Remove API request consolidation across tabs.

Merge pull requestlearningequality#3257from learningequality/depend…
d695e45
…abot/npm_and_yarn/path-parse-1.0.7 Bump path-parse from 1.0.6 to 1.0.7

bjester marked this pull request as ready for review August 12, 2021 16:59

rtibbles approved these changes Aug 12, 2021
View reviewed changes

rtibbles merged commit 967ba6e into learningequality:hotfixesAug 12, 2021

bjester mentioned this pull request Aug 17, 2021
Master release of last 2 sprints ending 2021-08-02 #3264
Merged

Navigation Menu

Uh oh!

Uh oh!

Hotfixes release for last 2 sprints ending 2021-08-02 - #3247

Hotfixes release for last 2 sprints ending 2021-08-02#3247
rtibbles merged 74 commits into
learningequality:hotfixesfrom
bjester:sprint-release-2021-07-19

bjester commented Jul 19, 2021•
edited
Loading

Uh oh!

sonarqubecloudBot commented Aug 12, 2021

Uh oh!

radinamatic commented Aug 12, 2021•
edited
Loading

Uh oh!

radinamatic commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

bjester commented Jul 19, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

QA Scenarios

Verify exercise randomization setting in channel export

Edit channel with multiple tabs open

Previewing related resource in drawer

Sign out clears local data

Adding topic doesn't cause console error

Edit rich exercise content

Critical workflows

Uh oh!

sonarqubecloudBot commented Aug 12, 2021

Uh oh!

radinamatic commented Aug 12, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radinamatic commented Aug 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bjester commented Jul 19, 2021•
edited
Loading

radinamatic commented Aug 12, 2021•
edited
Loading